Re: [PATCH v3 03/17] powerpc: Add PFO support to the VIO bus

2012-05-10 Thread Robert Jennings
* Benjamin Herrenschmidt (b...@kernel.crashing.org) wrote: Hrm... I don't like that much: + if (op-timeout) + deadline = jiffies + msecs_to_jiffies(op-timeout); + + while (true) { + hret = plpar_hcall_norets(H_COP, op-flags, +

Re: [PATCH v3 03/17] powerpc: Add PFO support to the VIO bus

2012-04-30 Thread Benjamin Herrenschmidt
Hrm... I don't like that much: + if (op-timeout) + deadline = jiffies + msecs_to_jiffies(op-timeout); + + while (true) { + hret = plpar_hcall_norets(H_COP, op-flags, + vdev-resource_id, + op-in,

Re: [PATCH v3 03/17] powerpc: Add PFO support to the VIO bus

2012-04-30 Thread Benjamin Herrenschmidt
Else, what about ceding the processor ? Or at the very least reducing the thread priority for a bit ? Shouldn't we also enforce to always have a timeout ? IE. Something like 30s or so if nothing specified to avoid having the kernel just hard lock... In general I don't like that sort of