Re: [PATCH] crypto: aead - move aead_request_cast helper to aead.h

On Wed, Jan 27, 2016 at 02:09:16PM -0800, Tadeusz Struk wrote: > Move the helper function to common header for everybody to use. > > Signed-off-by: Tadeusz Struk This should go into internal/aead.h if at all. Longer term we should look for ways to do away with direct

Re: [PATCH] crypto: aead - move aead_request_cast helper to aead.h

On Mon, Feb 01, 2016 at 07:46:59AM -0800, Tadeusz Struk wrote: > > Yes, I though about it, but I followed skcipher. The skcipher_request_cast() > helper is in crypto/skcipher.h not in crypto/internal/skcipher.h > Shouldn't this be consistent? Yes it should be moved into internal as well. Cheers,

Re: [PATCH] crypto: aead - move aead_request_cast helper to aead.h

On 02/01/2016 01:46 AM, Herbert Xu wrote: >> Move the helper function to common header for everybody to use. >> > >> > Signed-off-by: Tadeusz Struk > This should go into internal/aead.h if at all. Yes, I though about it, but I followed skcipher. The

[PATCH] crypto: aead - move aead_request_cast helper to aead.h

Move the helper function to common header for everybody to use. Signed-off-by: Tadeusz Struk --- drivers/crypto/atmel-aes.c |6 -- include/crypto/aead.h |6 ++ 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/crypto/atmel-aes.c