Re: [PATCH] crypto: fix memdup.cocci warnings

[Herbert Xu]

On Fri, Feb 16, 2018 at 12:40:13AM +0800, kbuild test robot wrote:
> From: Fengguang Wu 
> 
> drivers/crypto/ccree/cc_cipher.c:629:15-22: WARNING opportunity for kmemdep
> 
>  Use kmemdup rather than duplicating its implementation
> 
> Generated by: scripts/coccinelle/api/memdup.cocci
> 
> Fixes: 63ee04c8b491 ("crypto: ccree - add skcipher support")
> CC: Gilad Ben-Yossef 
> Signed-off-by: Fengguang Wu 

Patch applied.  Thanks.
-- 
Email: Herbert Xu 
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

[PATCH] crypto: fix memdup.cocci warnings

[kbuild test robot]

From: Fengguang Wu 

drivers/crypto/ccree/cc_cipher.c:629:15-22: WARNING opportunity for kmemdep

 Use kmemdup rather than duplicating its implementation

Generated by: scripts/coccinelle/api/memdup.cocci

Fixes: 63ee04c8b491 ("crypto: ccree - add skcipher support")
CC: Gilad Ben-Yossef 
Signed-off-by: Fengguang Wu 
---

 cc_cipher.c |3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

--- a/drivers/crypto/ccree/cc_cipher.c
+++ b/drivers/crypto/ccree/cc_cipher.c
@@ -626,12 +626,11 @@ static int cc_cipher_process(struct skci
/* The IV we are handed may be allocted from the stack so
 * we must copy it to a DMAable buffer before use.
 */
-   req_ctx->iv = kmalloc(ivsize, flags);
+   req_ctx->iv = kmemdup(iv, ivsize, flags);
if (!req_ctx->iv) {
rc = -ENOMEM;
goto exit_process;
}
-   memcpy(req_ctx->iv, iv, ivsize);
 
/*For CTS in case of data size aligned to 16 use CBC mode*/
if (((nbytes % AES_BLOCK_SIZE) == 0) &&