Re: [PATCH] crypto: img-hash: remove unnecessary static in img_hash_remove()

[Herbert Xu]

Gustavo A. R. Silva  wrote:
> Remove unnecessary static on local variable hdev. Such variable
> is initialized before being used, on every execution path throughout
> the function. The static has no benefit and, removing it reduces the
> object file size.
> 
> This issue was detected using Coccinelle and the following semantic patch:
> https://github.com/GustavoARSilva/coccinelle/blob/master/static/static_unused.cocci
> 
> In the following log you can see a significant difference in the object
> file size. This log is the output of the size command, before and after
> the code change:
> 
> before:
>   textdata bss dec hex filename
>  148426464 128   2143453ba drivers/crypto/img-hash.o
> 
> after:
>   textdata bss dec hex filename
>  147896376  64   2122952ed drivers/crypto/img-hash.o
> 
> Signed-off-by: Gustavo A. R. Silva 

Patch applied.  Thanks.
-- 
Email: Herbert Xu 
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

[PATCH] crypto: img-hash: remove unnecessary static in img_hash_remove()

[Gustavo A. R. Silva]

Remove unnecessary static on local variable hdev. Such variable
is initialized before being used, on every execution path throughout
the function. The static has no benefit and, removing it reduces the
object file size.

This issue was detected using Coccinelle and the following semantic patch:
https://github.com/GustavoARSilva/coccinelle/blob/master/static/static_unused.cocci

In the following log you can see a significant difference in the object
file size. This log is the output of the size command, before and after
the code change:

before:
   textdata bss dec hex filename
  148426464 128   2143453ba drivers/crypto/img-hash.o

after:
   textdata bss dec hex filename
  147896376  64   2122952ed drivers/crypto/img-hash.o

Signed-off-by: Gustavo A. R. Silva 
---
 drivers/crypto/img-hash.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/crypto/img-hash.c b/drivers/crypto/img-hash.c
index 0c6a917..b87000a 100644
--- a/drivers/crypto/img-hash.c
+++ b/drivers/crypto/img-hash.c
@@ -1054,7 +1054,7 @@ static int img_hash_probe(struct platform_device *pdev)
 
 static int img_hash_remove(struct platform_device *pdev)
 {
-   static struct img_hash_dev *hdev;
+   struct img_hash_dev *hdev;
 
hdev = platform_get_drvdata(pdev);
spin_lock(_hash.lock);
-- 
2.5.0