Re: [PATCH] crypto: sun4i-ss: add missing statesize

2015-11-17 Thread Herbert Xu
On Fri, Nov 13, 2015 at 02:10:28PM +0100, LABBE Corentin wrote: > sun4i-ss implementaton of md5/sha1 is via ahash algorithms. > Commit 8996eafdcbad ("crypto: ahash - ensure statesize is non-zero") > made impossible to load them without giving statesize. This patch > specifiy statesize for sha1 and

Re: [PATCH] crypto: sun4i-ss: add missing statesize

2015-11-17 Thread LABBE Corentin
On Tue, Nov 17, 2015 at 10:09:38PM +0800, Herbert Xu wrote: > On Fri, Nov 13, 2015 at 02:10:28PM +0100, LABBE Corentin wrote: > > sun4i-ss implementaton of md5/sha1 is via ahash algorithms. > > Commit 8996eafdcbad ("crypto: ahash - ensure statesize is non-zero") > > made impossible to load them

Re: [PATCH] crypto: sun4i-ss: add missing statesize

2015-11-17 Thread Herbert Xu
On Tue, Nov 17, 2015 at 03:26:03PM +0100, LABBE Corentin wrote: > > I have lots of user reporting that they cannot use the device since it wont > load. > For me it need to go stable since it respect all "stable rules", simple, > tested, minimal, and fix a real bug that bother people. Well it

Re: [PATCH] crypto: sun4i-ss: add missing statesize

2015-11-17 Thread Greg KH
On Tue, Nov 17, 2015 at 10:27:42PM +0800, Herbert Xu wrote: > On Tue, Nov 17, 2015 at 03:26:03PM +0100, LABBE Corentin wrote: > > > > I have lots of user reporting that they cannot use the device since it wont > > load. > > For me it need to go stable since it respect all "stable rules", simple,

[PATCH] crypto: sun4i-ss: add missing statesize

2015-11-13 Thread LABBE Corentin
sun4i-ss implementaton of md5/sha1 is via ahash algorithms. Commit 8996eafdcbad ("crypto: ahash - ensure statesize is non-zero") made impossible to load them without giving statesize. This patch specifiy statesize for sha1 and md5. Fixes: 6298e948215f ("crypto: sunxi-ss - Add Allwinner Security

Re: [PATCH] crypto: sun4i-ss: add missing statesize

2015-11-11 Thread Maxime Ripard
On Mon, Nov 09, 2015 at 11:58:48AM +0800, Herbert Xu wrote: > Christoph Biedl wrote: > > > > Fixes: should rather point to the commit that caused the breakage in my > > opinion. Which did this by intention: > > Absolutely not. That patch is correct and if

Re: [PATCH] crypto: sun4i-ss: add missing statesize

2015-11-08 Thread Christoph Biedl
Maxime Ripard wrote... > > > > This patch specifiy statesize for sha1 and md5. > > > > > > > > Signed-off-by: LABBE Corentin > > > > Cc: sta...@vger.kernel.org > > > > > > Please also add a Fixes tag (and the stable version it applies to). > > > > I don't see the

Re: [PATCH] crypto: sun4i-ss: add missing statesize

2015-11-08 Thread Herbert Xu
Christoph Biedl wrote: > > Fixes: should rather point to the commit that caused the breakage in my > opinion. Which did this by intention: Absolutely not. That patch is correct and if you revert that you will simply end up registering a broken driver into

Re: [PATCH] crypto: sun4i-ss: add missing statesize

2015-11-08 Thread Herbert Xu
On Mon, Nov 09, 2015 at 08:27:06AM +0100, LABBE Corentin wrote: > sun4i-ss implementaton of md5/sha1 is via ahash algorithms. > A recent change make impossible to load them without giving statesize. > This patch specifiy statesize for sha1 and md5. > > Fixes: 8996eafdcbad ("crypto: ahash - ensure

Re: [PATCH] crypto: sun4i-ss: add missing statesize

2015-11-05 Thread Maxime Ripard
Hi, On Thu, Nov 05, 2015 at 08:48:57AM +0100, LABBE Corentin wrote: > sun4i-ss implementaton of md5/sha1 is via ahash algorithms. > A recent change make impossible to load them without giving statesize. Which one? > This patch specifiy statesize for sha1 and md5. > > Signed-off-by: LABBE

Re: [PATCH] crypto: sun4i-ss: add missing statesize

2015-11-05 Thread Herbert Xu
On Thu, Nov 05, 2015 at 08:07:19AM -0800, Maxime Ripard wrote: > > On Thu, Nov 05, 2015 at 08:48:57AM +0100, LABBE Corentin wrote: > > sun4i-ss implementaton of md5/sha1 is via ahash algorithms. > > A recent change make impossible to load them without giving statesize. > > Which one? We

[PATCH] crypto: sun4i-ss: add missing statesize

2015-11-04 Thread LABBE Corentin
sun4i-ss implementaton of md5/sha1 is via ahash algorithms. A recent change make impossible to load them without giving statesize. This patch specifiy statesize for sha1 and md5. Signed-off-by: LABBE Corentin Cc: sta...@vger.kernel.org ---

[PATCH] crypto: sun4i-ss: add missing statesize

2015-10-20 Thread LABBE Corentin
sun4i-ss implementaton of md5/sha1 is via ahash algorithms. A recent change make impossible to load them without giving statesize. This patch specifiy statesize for sha1 and md5. Signed-off-by: LABBE Corentin --- drivers/crypto/sunxi-ss/sun4i-ss-core.c | 2 ++ 1 file