Re: [PATCH] hw_random: timeriomem-rng: Remove 'max < 4' condition check

[PrasannaKumar Muralidharan]

Hi Rick,

On 22 August 2017 at 22:23, Rick Altherr  wrote:
> On Tue, Aug 22, 2017 at 9:22 AM, PrasannaKumar Muralidharan
>  wrote:
>>
>> In read routiene max is always >= 4. The check whether 'max < 4' is not
>> necessary. Remove it.
>
> Missed that in the header.

It was added recently so you could have not missed it.

>
> Acked-By: Rick Altherr 
>
>>
>> Signed-off-by: PrasannaKumar Muralidharan 
>> ---
>>  drivers/char/hw_random/timeriomem-rng.c | 7 ---
>>  1 file changed, 7 deletions(-)
>>
>> diff --git a/drivers/char/hw_random/timeriomem-rng.c 
>> b/drivers/char/hw_random/timeriomem-rng.c
>> index 03ff548..f615684 100644
>> --- a/drivers/char/hw_random/timeriomem-rng.c
>> +++ b/drivers/char/hw_random/timeriomem-rng.c
>> @@ -53,13 +53,6 @@ static int timeriomem_rng_read(struct hwrng *hwrng, void 
>> *data,
>> int period_us = ktime_to_us(priv->period);
>>
>> /*
>> -* The RNG provides 32-bits per read.  Ensure there is enough space 
>> for
>> -* at minimum one read.
>> -*/
>> -   if (max < sizeof(u32))
>> -   return 0;
>> -
>> -   /*
>>  * There may not have been enough time for new data to be generated
>>  * since the last request.  If the caller doesn't want to wait, let 
>> them
>>  * bail out.  Otherwise, wait for the completion.  If the new data 
>> has
>> --
>> 2.10.0
>>

Regards,
PrasannaKumar

Re: [PATCH] hw_random: timeriomem-rng: Remove 'max < 4' condition check

[Rick Altherr]

On Tue, Aug 22, 2017 at 9:22 AM, PrasannaKumar Muralidharan
 wrote:
>
> In read routiene max is always >= 4. The check whether 'max < 4' is not
> necessary. Remove it.

Missed that in the header.

Acked-By: Rick Altherr 

>
> Signed-off-by: PrasannaKumar Muralidharan 
> ---
>  drivers/char/hw_random/timeriomem-rng.c | 7 ---
>  1 file changed, 7 deletions(-)
>
> diff --git a/drivers/char/hw_random/timeriomem-rng.c 
> b/drivers/char/hw_random/timeriomem-rng.c
> index 03ff548..f615684 100644
> --- a/drivers/char/hw_random/timeriomem-rng.c
> +++ b/drivers/char/hw_random/timeriomem-rng.c
> @@ -53,13 +53,6 @@ static int timeriomem_rng_read(struct hwrng *hwrng, void 
> *data,
> int period_us = ktime_to_us(priv->period);
>
> /*
> -* The RNG provides 32-bits per read.  Ensure there is enough space 
> for
> -* at minimum one read.
> -*/
> -   if (max < sizeof(u32))
> -   return 0;
> -
> -   /*
>  * There may not have been enough time for new data to be generated
>  * since the last request.  If the caller doesn't want to wait, let 
> them
>  * bail out.  Otherwise, wait for the completion.  If the new data has
> --
> 2.10.0
>

[PATCH] hw_random: timeriomem-rng: Remove 'max < 4' condition check

[PrasannaKumar Muralidharan]

In read routiene max is always >= 4. The check whether 'max < 4' is not
necessary. Remove it.

Signed-off-by: PrasannaKumar Muralidharan 
---
 drivers/char/hw_random/timeriomem-rng.c | 7 ---
 1 file changed, 7 deletions(-)

diff --git a/drivers/char/hw_random/timeriomem-rng.c 
b/drivers/char/hw_random/timeriomem-rng.c
index 03ff548..f615684 100644
--- a/drivers/char/hw_random/timeriomem-rng.c
+++ b/drivers/char/hw_random/timeriomem-rng.c
@@ -53,13 +53,6 @@ static int timeriomem_rng_read(struct hwrng *hwrng, void 
*data,
int period_us = ktime_to_us(priv->period);
 
/*
-* The RNG provides 32-bits per read.  Ensure there is enough space for
-* at minimum one read.
-*/
-   if (max < sizeof(u32))
-   return 0;
-
-   /*
 * There may not have been enough time for new data to be generated
 * since the last request.  If the caller doesn't want to wait, let them
 * bail out.  Otherwise, wait for the completion.  If the new data has
-- 
2.10.0