Re: [PATCH] hwrng: omap - Only fail if pm_runtime_get_sync returns < 0

2016-09-22 Thread Herbert Xu
On Tue, Sep 20, 2016 at 10:25:40AM -0500, Dave Gerlach wrote: > Currently omap-rng checks the return value of pm_runtime_get_sync and > reports failure if anything is returned, however it should be checking > if ret < 0 as pm_runtime_get_sync return 0 on success but also can return > 1 if the

[PATCH] hwrng: omap - Only fail if pm_runtime_get_sync returns < 0

2016-09-20 Thread Dave Gerlach
Currently omap-rng checks the return value of pm_runtime_get_sync and reports failure if anything is returned, however it should be checking if ret < 0 as pm_runtime_get_sync return 0 on success but also can return 1 if the device was already active which is not a failure case. Only values < 0 are