Re: [PATCH] kernel/padata.c: Register hotcpu notifier after initialization
On Tue, Aug 27, 2013 at 11:30:41AM +0200, Steffen Klassert wrote: On Fri, Aug 23, 2013 at 01:12:33PM +0200, Richard Weinberger wrote: padata_cpu_callback() takes pinst-lock, to avoid taking an uninitialized lock, register the notifier after it's initialization. Signed-off-by: Richard Weinberger rich...@nod.at Looks ok, Acked-by: Steffen Klassert steffen.klass...@secunet.com Also applied. -- Email: Herbert Xu herb...@gondor.apana.org.au Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line unsubscribe linux-crypto in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] kernel/padata.c: Register hotcpu notifier after initialization
On Fri, Aug 23, 2013 at 01:12:33PM +0200, Richard Weinberger wrote: padata_cpu_callback() takes pinst-lock, to avoid taking an uninitialized lock, register the notifier after it's initialization. Signed-off-by: Richard Weinberger rich...@nod.at Looks ok, Acked-by: Steffen Klassert steffen.klass...@secunet.com -- To unsubscribe from this list: send the line unsubscribe linux-crypto in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] kernel/padata.c: Register hotcpu notifier after initialization
padata_cpu_callback() takes pinst-lock, to avoid taking an uninitialized lock, register the notifier after it's initialization. Signed-off-by: Richard Weinberger rich...@nod.at --- kernel/padata.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/kernel/padata.c b/kernel/padata.c index 072f4ee..8e1bf9d 100644 --- a/kernel/padata.c +++ b/kernel/padata.c @@ -1086,18 +1086,18 @@ struct padata_instance *padata_alloc(struct workqueue_struct *wq, pinst-flags = 0; -#ifdef CONFIG_HOTPLUG_CPU - pinst-cpu_notifier.notifier_call = padata_cpu_callback; - pinst-cpu_notifier.priority = 0; - register_hotcpu_notifier(pinst-cpu_notifier); -#endif - put_online_cpus(); BLOCKING_INIT_NOTIFIER_HEAD(pinst-cpumask_change_notifier); kobject_init(pinst-kobj, padata_attr_type); mutex_init(pinst-lock); +#ifdef CONFIG_HOTPLUG_CPU + pinst-cpu_notifier.notifier_call = padata_cpu_callback; + pinst-cpu_notifier.priority = 0; + register_hotcpu_notifier(pinst-cpu_notifier); +#endif + return pinst; err_free_masks: -- 1.8.3.1 -- To unsubscribe from this list: send the line unsubscribe linux-crypto in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
