Re: [PATCH 1/4] Twofish cipher - split out common c code

2006-06-20 Thread Herbert Xu
On Mon, Jun 19, 2006 at 04:12:37PM +0200, Joachim Fritschi wrote: This patch is now based on the cryptodev tree. The last patches where against 2.6.17. I somehow missed you announcement about the api change (ctx - tfm). I also did the formating changes and the header fix you asked for.

Re: [PATCH 1/4] Twofish cipher - split out common c code

2006-06-20 Thread Herbert Xu
On Tue, Jun 20, 2006 at 08:26:11PM +1000, herbert wrote: BTW, I had to add a few missing bits to twofish_common.c. Next time please make sure that you provide at least a MODULE_LICENSE and a module_exit function. Actually a module_exit function isn't required in this case but a licence

Re: [PATCH 1/4] Twofish cipher - split out common c code

2006-06-18 Thread Herbert Xu
On Fri, Jun 16, 2006 at 01:58:52PM +0200, Joachim Fritschi wrote: I have done the changes you requested. twofish and twofish_common are now 2 seperate modules. twofish_common is hidden from the user and can be shared by both generic-c and the asm implementation. Thanks, but unfortunately

Re: [PATCH 1/4] Twofish cipher - split out common c code

2006-06-08 Thread Joachim Fritschi
On Thursday 08 June 2006 03:57, Herbert Xu wrote: On Wed, Jun 07, 2006 at 09:37:23PM +0200, Joachim Fritschi wrote: diff -uprN linux-2.6.17-rc5/crypto/Makefile linux-2.6.17-rc5.twofish/crypto/Makefile --- linux-2.6.17-rc5/crypto/Makefile2006-06-07 18:43:24.0 +0200

Re: [PATCH 1/4] Twofish cipher - split out common c code

2006-06-07 Thread Andi Kleen
On Wednesday 07 June 2006 21:37, Joachim Fritschi wrote: On Sunday 04 June 2006 15:16, Joachim Fritschi wrote: I have revised my initial twofish assembler patchset according to the criticims i recieved on this list: This patch splits up the twofish crypto routine into a common part ( key