Re: [PATCH 1/2] crypto: n2 - remove null check before kfree

[David Miller]

From: Himanshu Jha 
Date: Sun, 27 Aug 2017 02:45:29 +0530

> kfree on NULL pointer is a no-op and therefore checking it is redundant.
> 
> Signed-off-by: Himanshu Jha 

Acked-by: David S. Miller 

[PATCH 1/2] crypto: n2 - remove null check before kfree

[Himanshu Jha]

kfree on NULL pointer is a no-op and therefore checking it is redundant.

Signed-off-by: Himanshu Jha 
---
 drivers/crypto/n2_core.c | 12 
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/drivers/crypto/n2_core.c b/drivers/crypto/n2_core.c
index a9fd8b9..48de52c 100644
--- a/drivers/crypto/n2_core.c
+++ b/drivers/crypto/n2_core.c
@@ -1962,10 +1962,8 @@ static struct n2_crypto *alloc_n2cp(void)
 
 static void free_n2cp(struct n2_crypto *np)
 {
-   if (np->cwq_info.ino_table) {
-   kfree(np->cwq_info.ino_table);
-   np->cwq_info.ino_table = NULL;
-   }
+   kfree(np->cwq_info.ino_table);
+   np->cwq_info.ino_table = NULL;
 
kfree(np);
 }
@@ -2079,10 +2077,8 @@ static struct n2_mau *alloc_ncp(void)
 
 static void free_ncp(struct n2_mau *mp)
 {
-   if (mp->mau_info.ino_table) {
-   kfree(mp->mau_info.ino_table);
-   mp->mau_info.ino_table = NULL;
-   }
+   kfree(mp->mau_info.ino_table);
+   mp->mau_info.ino_table = NULL;
 
kfree(mp);
 }
-- 
2.7.4