Re: [PATCH v2 5/5] hwrng: amd: Rework of the amd768-hwrng driver

2016-08-26 Thread Jason Cooper
Hi Corentin, On Fri, Aug 26, 2016 at 10:38:02AM +0200, LABBE Corentin wrote: > On Thu, Aug 25, 2016 at 02:56:38PM +, Jason Cooper wrote: > > On Thu, Aug 25, 2016 at 02:16:35PM +0200, LABBE Corentin wrote: > > > This patch convert the hwrng interface used by amd768-rng to its new API > > > by

Re: [PATCH v2 5/5] hwrng: amd: Rework of the amd768-hwrng driver

2016-08-26 Thread LABBE Corentin
On Thu, Aug 25, 2016 at 02:56:38PM +, Jason Cooper wrote: > Hi Corentin, > > On Thu, Aug 25, 2016 at 02:16:35PM +0200, LABBE Corentin wrote: > > This patch convert the hwrng interface used by amd768-rng to its new API > > by replacing data_read()/data_present() by read(). > > > >

Re: [PATCH v2 5/5] hwrng: amd: Rework of the amd768-hwrng driver

2016-08-25 Thread Jason Cooper
Hi Corentin, On Thu, Aug 25, 2016 at 02:16:35PM +0200, LABBE Corentin wrote: > This patch convert the hwrng interface used by amd768-rng to its new API > by replacing data_read()/data_present() by read(). > > Furthermore, Instead of having two global variable, it's better to use a > private

[PATCH v2 5/5] hwrng: amd: Rework of the amd768-hwrng driver

2016-08-25 Thread LABBE Corentin
This patch convert the hwrng interface used by amd768-rng to its new API by replacing data_read()/data_present() by read(). Furthermore, Instead of having two global variable, it's better to use a private struct. This will permit to remove amd_pdev variable. Finally, Instead of accessing hw