Re: [PATCH v4 1/6] SP800-90A Deterministic Random Bit Generator

2014-04-11 Thread Stephan Mueller
Am Freitag, 11. April 2014, 11:20:21 schrieb Joe Perches: Hi Joe, > > It looks like const could be used a bit more often. > > For instance: > perhaps uses of key could be changed to const unsigned char *key Good point. I will try to find areas where const can be used. However, due to the use

Re: [PATCH v4 1/6] SP800-90A Deterministic Random Bit Generator

2014-04-11 Thread Joe Perches
On Fri, 2014-04-11 at 20:07 +0200, Stephan Mueller wrote: > Changes v4: > * change return codes of generate functions to signed int to convey error >codes and to match the kernel crypto API expecations on the generate >function. > * add BUG_ON throughout drbg_healthcheck_sanity() since an