On Sun, May 31, 2009 at 03:01:19PM +0200, Martin Willi wrote:
>
> Yes, it fixes HMAC calculation with enabled SLAB debugging.
Thanks for confirming. I'll push the fix through.
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~}
Home Page: http://gondor.apana.org.au/~herbe
> You must getting an sg entry that crosses a page boundary, rather than
> two sg entries that both stay within a page.
Yes.
> These things are very rare, and usually occurs as
> a result of SLAB debugging causing kmalloc to return memory that
> crosses page boundaries.
Indeed, SLAB_DEBUG was en
On Fri, May 29, 2009 at 12:04:32PM +0200, Martin Willi wrote:
>
> After doing further tests, it seems that this is additionally related to
> User-Mode-Linux and/or it's TUN/TAP network driver. I couldn't reproduce
> the issue on a x64 with e1000.
> I think the bug is actually in the UML network c
> > Switching the hash implementations to the new shash API introduced a
> > regression. HMACs are created incorrectly if the data is scattered over
> > multiple pages, resulting in very unreliable IPsec tunnels.
>
> What are the symptoms?
After doing further tests, it seems that this is addition
On Fri, May 29, 2009 at 04:19:31PM +1000, Herbert Xu wrote:
>
> Here's a patch to detect this for future reference.
>
> commit dfddf5dbe683cfdeb84bd218a1f819c09f5ea44a
> Author: Herbert Xu
> Date: Fri May 29 16:05:42 2009 +1000
>
> crypto: testmgr - Check all test vector lengths
I also n
On Thu, May 28, 2009 at 05:09:08PM +0200, Martin Willi wrote:
>
> Switching the hash implementations to the new shash API introduced a
> regression. HMACs are created incorrectly if the data is scattered over
> multiple pages, resulting in very unreliable IPsec tunnels.
What are the symptoms?
>
Hi,
Switching the hash implementations to the new shash API introduced a
regression. HMACs are created incorrectly if the data is scattered over
multiple pages, resulting in very unreliable IPsec tunnels.
The appended patch adds a silly hmac(sha1) test vector larger than a 4KB
page and fails on c
