Re: WARNING: kernel stack regs has bad 'bp' value (2)

2017-12-27 Thread Dmitry Vyukov 
On Wed, Dec 27, 2017 at 7:29 PM, Dmitry Vyukov  wrote:
> On Thu, Nov 30, 2017 at 10:17 AM, Eric Biggers  wrote:
>> On Tue, Nov 28, 2017 at 10:36:01AM -0800, syzbot wrote:
>>> WARNING: kernel stack regs at 8801c1e5f468 in syzkaller196611:6199 has
>>> bad 'bp' value 0001
>>> unwind stack type:0 next_sp:  (null) mask:0x6 graph_idx:0
>>> 8801db4075a8: 8801db407630 (0x8801db407630)
>>> 8801db4075b0: 8128a84e (__save_stack_trace+0x6e/0xd0)
>>> 8801db4075b8:  ...
>>> 8801db4075c0: 8801c1e58000 (0x8801c1e58000)
>>> 8801db4075c8: 8801c1e6 (0x8801c1e6)
>>> 8801db4075d0:  ...
>>> 8801db4075d8: 0006 (0x6)
>>> 8801db4075e0: 8801c1e4e000 (0x8801c1e4e000)
>>> 8801db4075e8: 0101 (0x101)
>>> 8801db4075f0:  ...
>>> 8801db4075f8: 8801db4075a8 (0x8801db4075a8)
>>> 8801db407600: 8134ff7d (__twofish_enc_blk_3way+0x1b1d/0x1b30)
>>
>> Looks like the x86_64 "3 way" version of Twofish 
>> (twofish-x86_64-asm_64-3way.S)
>> needs to be updated to not use %rbp.
>
>
> This is what is supposed to be fixed with "crypto: x86/twofish-3way -
> Fix %rbp usage", right? Was it merged anywhere?
> This is one of top crashers with 15K crashes.


#syz fix: crypto: x86/twofish-3way - Fix %rbp usage

Re: WARNING: kernel stack regs has bad 'bp' value (2)

2017-12-27 Thread Dmitry Vyukov 
On Thu, Nov 30, 2017 at 10:17 AM, Eric Biggers  wrote:
> On Tue, Nov 28, 2017 at 10:36:01AM -0800, syzbot wrote:
>> WARNING: kernel stack regs at 8801c1e5f468 in syzkaller196611:6199 has
>> bad 'bp' value 0001
>> unwind stack type:0 next_sp:  (null) mask:0x6 graph_idx:0
>> 8801db4075a8: 8801db407630 (0x8801db407630)
>> 8801db4075b0: 8128a84e (__save_stack_trace+0x6e/0xd0)
>> 8801db4075b8:  ...
>> 8801db4075c0: 8801c1e58000 (0x8801c1e58000)
>> 8801db4075c8: 8801c1e6 (0x8801c1e6)
>> 8801db4075d0:  ...
>> 8801db4075d8: 0006 (0x6)
>> 8801db4075e0: 8801c1e4e000 (0x8801c1e4e000)
>> 8801db4075e8: 0101 (0x101)
>> 8801db4075f0:  ...
>> 8801db4075f8: 8801db4075a8 (0x8801db4075a8)
>> 8801db407600: 8134ff7d (__twofish_enc_blk_3way+0x1b1d/0x1b30)
>
> Looks like the x86_64 "3 way" version of Twofish 
> (twofish-x86_64-asm_64-3way.S)
> needs to be updated to not use %rbp.


This is what is supposed to be fixed with "crypto: x86/twofish-3way -
Fix %rbp usage", right? Was it merged anywhere?
This is one of top crashers with 15K crashes.

Re: WARNING: kernel stack regs has bad 'bp' value (2)

2017-11-30 Thread Eric Biggers 
On Tue, Nov 28, 2017 at 10:36:01AM -0800, syzbot wrote:
> WARNING: kernel stack regs at 8801c1e5f468 in syzkaller196611:6199 has
> bad 'bp' value 0001
> unwind stack type:0 next_sp:  (null) mask:0x6 graph_idx:0
> 8801db4075a8: 8801db407630 (0x8801db407630)
> 8801db4075b0: 8128a84e (__save_stack_trace+0x6e/0xd0)
> 8801db4075b8:  ...
> 8801db4075c0: 8801c1e58000 (0x8801c1e58000)
> 8801db4075c8: 8801c1e6 (0x8801c1e6)
> 8801db4075d0:  ...
> 8801db4075d8: 0006 (0x6)
> 8801db4075e0: 8801c1e4e000 (0x8801c1e4e000)
> 8801db4075e8: 0101 (0x101)
> 8801db4075f0:  ...
> 8801db4075f8: 8801db4075a8 (0x8801db4075a8)
> 8801db407600: 8134ff7d (__twofish_enc_blk_3way+0x1b1d/0x1b30)

Looks like the x86_64 "3 way" version of Twofish (twofish-x86_64-asm_64-3way.S)
needs to be updated to not use %rbp.

Eric