Re: crypto: s390 - Fix aes-cbc IV corruption

2013-11-17 Thread Herbert Xu
On Thu, Nov 14, 2013 at 05:10:20PM +0100, Jan Glauber wrote: On Thu, Oct 31, 2013 at 11:25:47AM +0800, Herbert Xu wrote: Hi: Hi Herbert, just seen this as my old email address is dead... Your patch looks fine as it keeps the iv and the key together as required by the instruction. Thanks

Re: crypto: s390 - Fix aes-cbc IV corruption

2013-11-14 Thread Jan Glauber
On Thu, Oct 31, 2013 at 11:25:47AM +0800, Herbert Xu wrote: Hi: Hi Herbert, just seen this as my old email address is dead... Your patch looks fine as it keeps the iv and the key together as required by the instruction. However, I'm curious how this could be racy with threads. The encryption

crypto: s390 - Fix aes-cbc IV corruption

2013-10-30 Thread Herbert Xu
Hi: The cbc-aes-s390 algorithm incorrectly places the IV in the tfm data structure. As the tfm is shared between multiple threads, this introduces a possibility of data corruption. This patch fixes this by moving the parameter block containing the IV and key onto the stack (the block is 48