Re: [PATCH v2] crypto: tcrypt - Fix memory leaks/crashes in multibuffer hash speed test

2016-06-29 Thread Megha Dey
I tested the latest cryptodev tree on my haswell machine and this is what I see: [ 40.402834] modprobe tcrypt mode=422 [ 40.403105] testing speed of multibuffer sha1 (sha1_mb) [ 40.403108] test 0 ( 16 byte blocks, 16 bytes per update, 1 updates): 32271 cycles/operation, 252 cycles/by

Re: [PATCH v2] crypto: tcrypt - Fix memory leaks/crashes in multibuffer hash speed test

2016-06-29 Thread Krzysztof Kozlowski
On 06/29/2016 10:19 AM, Herbert Xu wrote: > On Wed, Jun 29, 2016 at 10:16:10AM +0200, Krzysztof Kozlowski wrote: >> >> Seems to work fine except: >> 1. The updates are always 1. > > Yes the test function only does digest so it's always one update. > >> 2. For bigger blocks it reports always 1 or

Re: [PATCH v2] crypto: tcrypt - Fix memory leaks/crashes in multibuffer hash speed test

2016-06-29 Thread Herbert Xu
On Wed, Jun 29, 2016 at 10:16:10AM +0200, Krzysztof Kozlowski wrote: > > Seems to work fine except: > 1. The updates are always 1. Yes the test function only does digest so it's always one update. > 2. For bigger blocks it reports always 1 or 3 cycles per byte: Yes the average cycles per-byte s

Re: [PATCH v2] crypto: tcrypt - Fix memory leaks/crashes in multibuffer hash speed test

2016-06-29 Thread Krzysztof Kozlowski
On 06/28/2016 02:33 PM, Herbert Xu wrote: > On Tue, Jun 28, 2016 at 12:15:43PM +0200, Krzysztof Kozlowski wrote: >> Oops: > > Thanks, there was a typo where it said k instead of j in the second > loop. > > ---8<--- > This patch resolves a number of issues with the mb speed test > function: > > *

[PATCH v2] crypto: tcrypt - Fix memory leaks/crashes in multibuffer hash speed test

2016-06-28 Thread Herbert Xu
On Tue, Jun 28, 2016 at 12:15:43PM +0200, Krzysztof Kozlowski wrote: > Oops: Thanks, there was a typo where it said k instead of j in the second loop. ---8<--- This patch resolves a number of issues with the mb speed test function: * The tfm is never freed. * Memory is allocated even when we're

Re: crypto: tcrypt - Fix memory leaks/crashes in multibuffer hash speed test

2016-06-28 Thread Krzysztof Kozlowski
On Tue, Jun 28, 2016 at 11:55 AM, Herbert Xu wrote: > This patch resolves a number of issues with the mb speed test > function: > > * The tfm is never freed. > * Memory is allocated even when we're not using mb. > * When an error occurs we don't wait for completion for other requests. > * When an

crypto: tcrypt - Fix memory leaks/crashes in multibuffer hash speed test

2016-06-28 Thread Herbert Xu
This patch resolves a number of issues with the mb speed test function: * The tfm is never freed. * Memory is allocated even when we're not using mb. * When an error occurs we don't wait for completion for other requests. * When an error occurs during allocation we may leak memory. * The test func