Re: crypto_cipher_encrypt_iv and null cipher

2006-06-20 Thread Michael Richardson
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 > "Herbert" == Herbert Xu <[EMAIL PROTECTED]> writes: >> Well, there are not that many general notions of modes, so >> doesn't make this too scalable. I still don't know why anyone >> would use ECB mode in practice. Herbert> Ther

Re: crypto_cipher_encrypt_iv and null cipher

2006-06-20 Thread Herbert Xu
On Tue, Jun 20, 2006 at 11:22:38AM -0400, Michael Richardson wrote: > > Well, there are not that many general notions of modes, so doesn't > make this too scalable. I still don't know why anyone would use ECB > mode in practice. There are other modes like CFB, CTR, OFB, and IGE. While they ma

Re: crypto_cipher_encrypt_iv and null cipher

2006-06-20 Thread Michael Richardson
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 > "Herbert" == Herbert Xu <[EMAIL PROTECTED]> writes: >> Are you sure that you want to have generic CBC code? >> >> For many algorithms, there are optomizations that one can do when >> one is in CBC mode. Herbert> If anything

Re: crypto_cipher_encrypt_iv and null cipher

2006-06-20 Thread Herbert Xu
On Tue, Jun 20, 2006 at 10:30:52AM -0400, Michael Richardson wrote: > > Are you sure that you want to have generic CBC code? > > For many algorithms, there are optomizations that one can do when one is > in CBC mode. If anything the parameterised scheme is going to make it easier to have specif

Re: crypto_cipher_encrypt_iv and null cipher

2006-06-20 Thread Michael Richardson
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Are you sure that you want to have generic CBC code? For many algorithms, there are optomizations that one can do when one is in CBC mode. - -- ] ON HUMILITY: to err is human. To moo, bovine. | firewalls [ ] Michael Richardson,

Re: crypto_cipher_encrypt_iv and null cipher

2006-06-19 Thread Herbert Xu
On Thu, Jun 15, 2006 at 10:34:29AM -0400, Michael Richardson wrote: > > Herbert> Thanks for the patch. However, I won't apply this because > Herbert> it will soon become redundant once I add parameterised > Herbert> algorithms. > > What does that mean? Instead of requesting for "c

Re: crypto_cipher_encrypt_iv and null cipher

2006-06-19 Thread Michael Richardson
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 > "Herbert" == Herbert Xu <[EMAIL PROTECTED]> writes: >> It seems that crypto_cipher_encrypt_iv(); and decrypt_iv(); >> >> BUG_ON() if the cit_mode is MODE_ECB. Okay, that's reasonable. >> >> The problem is that the OCF crypt

Re: crypto_cipher_encrypt_iv and null cipher

2006-06-14 Thread Herbert Xu
On Mon, Jun 12, 2006 at 03:02:04PM -0400, Michael Richardson wrote: > > It seems that >crypto_cipher_encrypt_iv(); and decrypt_iv(); > > BUG_ON() if the cit_mode is MODE_ECB. Okay, that's reasonable. > > The problem is that the OCF cryptosoft interface for OCF sets the mode=0, > now. Since

crypto_cipher_encrypt_iv and null cipher

2006-06-14 Thread Michael Richardson
It seems that crypto_cipher_encrypt_iv(); and decrypt_iv(); BUG_ON() if the cit_mode is MODE_ECB. Okay, that's reasonable. The problem is that the OCF cryptosoft interface for OCF sets the mode=0, now. Since it's a NULL cipher, it doesn't matter what mode, so I've changed it to CBC mode, an