Re: echainiv not working as supposed to be?

2016-09-07 Thread Herbert Xu
On Wed, Sep 07, 2016 at 12:08:10AM +0800, Herbert Xu wrote: > > > So, should echainiv use a per-context per-cpu array instead that -- > > for simplicity -- gets initialised with random bytes and will be > > updated as it's now, just not with a single global per-cpu array, but > > a per-context

Re: echainiv not working as supposed to be?

2016-09-06 Thread Herbert Xu
On Tue, Sep 06, 2016 at 02:24:59PM +0200, Mathias Krause wrote: > > For each request it XORs the salt into the provided IV (req->iv). For > ESP the provided IV is the sequence number or, at least, parts of it. > The thus modified IV gets written into the *destination* buffer > (req->dst) which

echainiv not working as supposed to be?

2016-09-06 Thread Mathias Krause
Hi Herbert, I'm a little bit confused on how echainiv is supposed to work. I think it's doing a few things wrongly, I just can't decide what's actually wrong as the intended mode of operation is unclear to me. At least, as-is, the code isn't quite operating as advertised in the comment at the top