On Tue, Mar 16, 2010 at 07:22:44AM -0700, Shane Wang wrote:
This patch is to fix the vmac algorithm, add more test cases for vmac, and
fix the test failure on some big endian system like s390.
Signed-off-by: Shane Wang shane.w...@intel.com
Patch applied. Thanks a lot for following through
This patch is to fix the vmac algorithm, add more test cases for vmac, and fix
the test failure on some big endian system like s390.
Signed-off-by: Shane Wang shane.w...@intel.com
---
crypto/testmgr.h | 64 --
crypto/vmac.c| 75
That should be simpler and better.
Thanks.
Shane
-Original Message-
From: Herbert Xu [mailto:herb...@gondor.apana.org.au]
Sent: 2010年3月2日 21:57
To: Wang, Shane
Cc: Sebastian Andrzej Siewior; Jan Glauber; Cihula, Joseph; linux-crypto
Subject: Re: [PATCH] to fix vmac test fails on s390
On Tue, Mar 16, 2010 at 01:25:54PM +0800, Wang, Shane wrote:
That should be simpler and better.
OK can you please resubmit the patch?
Thanks,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmVHI~} herb...@gondor.apana.org.au
Home Page: http://gondor.apana.org.au/~herbert/
On Mon, Feb 22, 2010 at 11:21:04AM +0800, Wang, Shane wrote:
@@ -474,7 +475,10 @@ static u64 vmac(unsigned char m[], unsig
}
p = be64_to_cpup(out_p + i);
h = vhash(m, mbytes, (u64 *)0, ctx-__vmac_ctx);
- return p + h;
+ r = p + h;
+ r = le64_to_cpup(r);
+
+
* Wang, Shane | 2010-02-21 13:32:49 [+0800]:
--- a/crypto/vmac.cThu Feb 11 00:45:57 2010 -0800
+++ b/crypto/vmac.cSun Feb 21 02:23:01 2010 -0800
@@ -42,6 +42,8 @@ const u64 m63 = UINT64_C(0x7ff
const u64 m63 = UINT64_C(0x7fff); /* 63-bit mask */
const u64
Updated again and Resend
This patch is to fix the vmac algorithm, add more test cases for vmac, and fix
the test failure on some big endian system like s390.
Signed-off-by: Shane Wang shane.w...@intel.com
crypto/testmgr.h | 64 +---
crypto/vmac.c| 80
Updated Resend
This patch is to fix the vmac algorithm, add more test cases for vmac, and fix
the test failure on some big endian system like s390.
Signed-off-by: Shane Wang shane.w...@intel.com
crypto/testmgr.h | 64 +++--
crypto/vmac.c| 77
Herbert Xu wrote:
Sorry but you can't fix it like this. Your hash output must be
invariant with respect to endianness.
That means, whether I run it on a big-endian machine or a little-
endian one it should produce the same output.
Otherwise this hash will be totally useless as soon as
On Thu, Feb 11, 2010 at 11:18:08AM +0800, Wang, Shane wrote:
static struct hash_testvec aes_vmac128_tv_template[] = {
{
+ .key= \x00\x01\x02\x03\x04\x05\x06\x07
+ \x08\x09\x0a\x0b\x0c\x0d\x0e\x0f,
+ .plaintext = NULL,
+#ifdef
Herbert,
Here is the patch to fix it. I missed an important fact that the digest of vmac
is not a string or a char array, but an 64bit integer.
This patch is to fix the vmac algorithm, add more test cases for vmac, and fix
the test failure on some big endian system like s390.
(the attachment
On Thu, Jan 14, 2010 at 02:05:30PM +, Jan Glauber wrote:
Hi,
Jan 14 14:47:38 h42lp52 kernel: alg: hash: Test 1 failed for vmac(aes-s390)
Jan 14 14:47:38 h42lp52 kernel: : e7 79 33 b7 fd 8a d7 cb
Looking at the digest from the failing test vector:
.digest =
Hi,
Jan 14 14:47:38 h42lp52 kernel: alg: hash: Test 1 failed for vmac(aes-s390)
Jan 14 14:47:38 h42lp52 kernel: : e7 79 33 b7 fd 8a d7 cb
Looking at the digest from the failing test vector:
.digest = \xcb\xd7\x8a\xfd\xb7\x33\x79\xe7,
the output looks somehow familiar... Maybe a missing
13 matches
Mail list logo
