Re: Bug in geode-aes.c ?

2009-11-12 Thread Sergey Mironov
2009/11/12 Sebastian Andrzej Siewior : > * Sergey Mironov | 2009-11-10 17:00:31 [+0300]: > >> 116 static int geode_setkey_cip(struct crypto_tfm *tfm, const u8 *key, >> 117                 unsigned int len) >> 118 { >>... >> >>/** BUG? Should it be 'op->fallback.cip' instead of 'op->fallback.blk' ?

Re: Bug in geode-aes.c ?

2009-11-12 Thread Sergey Mironov
2009/11/12 Sergey Mironov : > 2009/11/12 Sebastian Andrzej Siewior : >> * Sergey Mironov | 2009-11-10 17:00:31 [+0300]: >> >>> 116 static int geode_setkey_cip(struct crypto_tfm *tfm, const u8 *key, >>> 117                 unsigned int len) >>> 118 { >>>... >>> >>>/** BUG? Should it be 'op->fallback

Re: Bug in geode-aes.c ?

2009-11-12 Thread Sebastian Andrzej Siewior
* Sergey Mironov | 2009-11-12 11:36:42 [+0300]: >From 0a61b446585324a3041ef0a138515ef936a14eb7 Mon Sep 17 00:00:00 2001 >From: Sergey Mironov >Date: Thu, 12 Nov 2009 11:30:02 +0300 >Subject: [PATCH] Fixed typo bugs in geod-aes.c > > >Signed-off-by: Sergey Mironov Acked-by: Sebastian Andrzej Siew

Re: Bug in geode-aes.c ?

2009-11-12 Thread Sebastian Andrzej Siewior
* Sergey Mironov | 2009-11-12 11:43:20 [+0300]: >I can't find any "s390" reference in my tree. Probably, i have not got >this branch in my local copy. If you want to fix this please look at arch/s390/crypto/aes_s390.c. That is broken and I mixed it up in fallback_init_cip() as well :) Sebastian

Re: Bug in geode-aes.c ?

2009-11-12 Thread Sebastian Andrzej Siewior
>From 0a61b446585324a3041ef0a138515ef936a14eb7 Mon Sep 17 00:00:00 2001 >From: Sergey Mironov >Date: Thu, 12 Nov 2009 11:30:02 +0300 >Subject: [PATCH] Fixed typo bugs in geod-aes.c On a second look could you please add something like: crypto/geode: access fallback.cip cipher fallback mode |The

Re: Bug in geode-aes.c ?

2009-11-12 Thread Sergey Mironov
2009/11/12 Sebastian Andrzej Siewior : > >From 0a61b446585324a3041ef0a138515ef936a14eb7 Mon Sep 17 00:00:00 2001 >>From: Sergey Mironov >>Date: Thu, 12 Nov 2009 11:30:02 +0300 >>Subject: [PATCH] Fixed typo bugs in geod-aes.c > > On a second look could you please add something like: > > crypto/geod