Re: Fwd: crypto accelerator driver problems

2013-04-25 Thread Herbert Xu
Vakul Garg va...@freescale.com wrote: Herbert Xu herbert at gondor.apana.org.au writes: On Wed, Jan 26, 2011 at 10:26:33AM +0330, Hamid Nassiby wrote: As you know, I posted my problem again to crypto list and no one answered. Now I emphasize one aspect of the problem as a concept

Re: [PATCH 1/9 v2] crypto: ux500/hash - Prepare clock before enabling it

2013-04-25 Thread Linus Walleij
On Fri, Apr 19, 2013 at 2:24 PM, Lee Jones lee.jo...@linaro.org wrote: Slight change of plan for v2. Now we're doing a seperate clk_prepare(), as the clk_enable() in the previous patch turned out to be called inside a spin_lock(). Arnd, can you confirm your Ack please? Do you really want

Re: [PATCH 2/9] crypto: ux500/hash - Set DMA configuration though dma_slave_config()

2013-04-25 Thread Linus Walleij
Pls include magnus.p.pers...@stericsson.com on all these crypto/hash postings. On Thu, Apr 18, 2013 at 12:26 PM, Lee Jones lee.jo...@linaro.org wrote: The DMA controller currently takes configuration information from information passed though dma_channel_request(), but it shouldn't. Using the

Re: [PATCH 4/9 v2] crypto: ux500/cryp - Prepare clock before enabling it

2013-04-25 Thread Linus Walleij
On Fri, Apr 19, 2013 at 2:22 PM, Lee Jones lee.jo...@linaro.org wrote: Slight change of plan for v2. Now we're doing a seperate clk_prepare(), as the clk_enable() in the previous patch turned out to be called inside a spin_lock(). Arnd, can you confirm your Ack please? crypto:

Re: [PATCH 5/9] crypto: ux500/cryp - Fix compile error

2013-04-25 Thread Linus Walleij
On Thu, Apr 18, 2013 at 12:27 PM, Lee Jones lee.jo...@linaro.org wrote: Clearly this driver hasn't been tested, or even enabled in a while. drivers/crypto/ux500/cryp/cryp_core.c:1771:3: error: request for member ‘pm’ in something not a structure or union Cc: Herbert Xu

Re: [PATCH 8/9] crypto: ux500/[cryp|hash] - Show successful start-up in the bootlog

2013-04-25 Thread Linus Walleij
On Thu, Apr 18, 2013 at 12:27 PM, Lee Jones lee.jo...@linaro.org wrote: The Cryp driver is currently silent and the Hash driver prints the name of its probe function unnecessarily. Let's just put a nice descriptive one-liner there instead. Cc: Herbert Xu herb...@gondor.apana.org.au Cc:

[PATCH] ARM: crypto: fix stack frame handling in SHA1 asm code

2013-04-25 Thread Ard Biesheuvel
The current code increases its stack frame size a couple of times throughout the function, but still performs some writes below the stack pointer. This change applies the fix from the original author so all writes to the stack are above the stack pointer. Taken from origin:

Re: [PATCH] Fix prototype definitions of sha256_transform_asm, sha512_transform_asm

2013-04-25 Thread Herbert Xu
On Fri, Apr 19, 2013 at 01:25:12PM -0700, Tim Chen wrote: Herbert, This is a follow on patch to the optimized sha256 and sha512 patch series that's just merged into the crypto-dev. Let me know if you prefer me to respin the patch series. This patch corrects the prototype of

Re: [PATCH] crypto: aesni_intel - fix Kconfig problem with CRYPTO_GLUE_HELPER_X86

2013-04-25 Thread Herbert Xu
On Wed, Apr 10, 2013 at 06:39:20PM +0300, Jussi Kivilinna wrote: The Kconfig setting for glue helper module is CRYPTO_GLUE_HELPER_X86, but recent change for aesni_intel used CRYPTO_GLUE_HELPER instead. Patch corrects this issue. Cc: kbuild-...@01.org Reported-by: kbuild test robot

Re: [PATCH v2 1/4] Wrap crc_t10dif function all to use crypto transform framework

2013-04-25 Thread Herbert Xu
On Wed, Apr 17, 2013 at 09:12:52AM -0700, Tim Chen wrote: When CRC T10 DIF is calculated using the crypto transform framework, we wrap the crc_t10dif function call to utilize it. This allows us to take advantage of any accelerated CRC T10 DIF transform that is plugged into the crypto

Re: [PATCH 6/9] crypto: ux500/cryp - Set DMA configuration though dma_slave_config()

2013-04-25 Thread Lee Jones
On Thu, 25 Apr 2013, Linus Walleij wrote: On Thu, Apr 18, 2013 at 12:27 PM, Lee Jones lee.jo...@linaro.org wrote: The DMA controller currently takes configuration information from information passed though dma_channel_request(), but it shouldn't. Using the API, the DMA channel should

Re: [PATCH 5/9] crypto: ux500/cryp - Fix compile error

2013-04-25 Thread Lee Jones
On Thu, 25 Apr 2013, Linus Walleij wrote: On Thu, Apr 18, 2013 at 12:27 PM, Lee Jones lee.jo...@linaro.org wrote: Clearly this driver hasn't been tested, or even enabled in a while. drivers/crypto/ux500/cryp/cryp_core.c:1771:3: error: request for member ‘pm’ in something not a

Re: [PATCH 1/9 v2] crypto: ux500/hash - Prepare clock before enabling it

2013-04-25 Thread Lee Jones
On Thu, 25 Apr 2013, Linus Walleij wrote: On Fri, Apr 19, 2013 at 2:24 PM, Lee Jones lee.jo...@linaro.org wrote: Slight change of plan for v2. Now we're doing a seperate clk_prepare(), as the clk_enable() in the previous patch turned out to be called inside a spin_lock(). Arnd, can

Re: [PATCH 6/9] crypto: ux500/cryp - Set DMA configuration though dma_slave_config()

2013-04-25 Thread Linus Walleij
On Thu, Apr 25, 2013 at 3:44 PM, Lee Jones lee.jo...@linaro.org wrote: On Thu, 25 Apr 2013, Linus Walleij wrote: On Thu, Apr 18, 2013 at 12:27 PM, Lee Jones lee.jo...@linaro.org wrote: The DMA controller currently takes configuration information from information passed though

Re: [PATCH v2 1/4] Wrap crc_t10dif function all to use crypto transform framework

2013-04-25 Thread Tim Chen
On Thu, 2013-04-25 at 21:22 +0800, Herbert Xu wrote: Please wrap the generic implementation as we do for crc32c. Herbert, I've updated this patch to add the generic crct10dif transform (see below). Let me know if this address your comment. Thanks. Tim When CRC T10 DIF is calculated using

Re: [PATCH 1/2] lib: Add lz4 compressor module

2013-04-25 Thread Chanho Min
gcc seems to define __builtin_clz as __clzsi2 in some architecture. But, kernel doesn't link libgcc.a. If kernel should use gcc's built-in function without libgcc.a, do we need to port __clzsi2 to 'arch/*/lib/*'? This breaks alpha (gcc-4.4.4) as well. Can we please get this fixed promptly?

Re: [PATCH 1/2] lib: Add lz4 compressor module

2013-04-25 Thread Stephen Rothwell
Hi, On Fri, 26 Apr 2013 14:02:01 +0900 Chanho Min chanho@lge.com wrote: @@ -0,0 +1,23 @@ +#include linux/kernel.h + +int __attribute__((weak)) __clzsi2(int val) We have __weak in linux/compiler.h -- Cheers, Stephen Rothwells...@canb.auug.org.au