Re: [PATCH] crypto: caam: fix error reporting

2014-11-03 Thread Cristian Stoica
Hi Kim, On 10/31/2014 08:22 PM, Kim Phillips wrote: On Fri, 31 Oct 2014 18:57:33 +0200 Cristian Stoica cristian.sto...@freescale.com wrote: If this issue was brought up by h/w, the appropriate new error codes should be being introduced. If you have the new error codes please send them to

Re: [PATCH v5 4/4] crypto: Add Allwinner Security System crypto accelerator

2014-11-03 Thread Maxime Ripard
On Fri, Oct 31, 2014 at 06:05:22PM +0800, Herbert Xu wrote: On Fri, Oct 31, 2014 at 10:57:06AM +0100, Maxime Ripard wrote: On a 3.18-rc2 kernel: $ git grep kmap -- crypto/ crypto/ahash.c: walk-data = kmap(walk-pg); crypto/ahash.c:

Re: [PATCH v5 4/4] crypto: Add Allwinner Security System crypto accelerator

2014-11-03 Thread Herbert Xu
On Mon, Nov 03, 2014 at 10:34:46AM +0100, Maxime Ripard wrote: What I mean is that since you are saying that drivers should do the kmap themselves, then *all* of the drivers are broken if they are not using it. And all of them are missing this kmap. kmap is used by the software implementations

Re: [PATCH v2 01/11] crypto: Documentation - crypto API high level spec

2014-11-03 Thread Jonathan Corbet
On Sun, 02 Nov 2014 21:35:11 +0100 Stephan Mueller smuel...@chronox.de wrote: The design of the kernel crypto API as well as hints to program with the kernel crypto API are given. Cool to see this, thanks. Please forgive me if I go into full grumpy editor mode here. There's a lot of good

Re: [PATCH v2 01/11] crypto: Documentation - crypto API high level spec

2014-11-03 Thread Stephan Mueller
Am Montag, 3. November 2014, 08:34:39 schrieb Jonathan Corbet: Hi Jonathan, On Sun, 02 Nov 2014 21:35:11 +0100 Stephan Mueller smuel...@chronox.de wrote: The design of the kernel crypto API as well as hints to program with the kernel crypto API are given. Cool to see this, thanks.

Re: [PATCH v2 01/11] crypto: Documentation - crypto API high level spec

2014-11-03 Thread Herbert Xu
On Mon, Nov 03, 2014 at 03:18:29PM +0100, Stephan Mueller wrote: + * CRYPTO_ALG_TYPE_CIPHERRaw block cipher + * CRYPTO_ALG_TYPE_COMPRESS Compression + * CRYPTO_ALG_TYPE_AEAD Authenticated Encryption with Associated Data (MAC) + * CRYPTO_ALG_TYPE_BLKCIPHER

Re: [PATCH v2 01/11] crypto: Documentation - crypto API high level spec

2014-11-03 Thread Herbert Xu
On Mon, Nov 03, 2014 at 03:18:29PM +0100, Stephan Mueller wrote: + * CRYPTO_ALG_TYPE_DIGESTRaw message digest + * CRYPTO_ALG_TYPE_HASH Alias for CRYPTO_ALG_TYPE_DIGEST + * CRYPTO_ALG_TYPE_SHASH Synchronous multi-block hash + * CRYPTO_ALG_TYPE_AHASH Asynchronous

Re: [PATCH v2 01/11] crypto: Documentation - crypto API high level spec

2014-11-03 Thread Tom Lendacky
On 11/03/2014 08:49 AM, Herbert Xu wrote: On Mon, Nov 03, 2014 at 03:18:29PM +0100, Stephan Mueller wrote: + * CRYPTO_ALG_TYPE_DIGEST Raw message digest + * CRYPTO_ALG_TYPE_HASHAlias for CRYPTO_ALG_TYPE_DIGEST + * CRYPTO_ALG_TYPE_SHASH Synchronous multi-block hash +

Re: [PATCH] arm64/crypto: use crypto instructions for generating AES key schedule

2014-11-03 Thread Steve Capper
On Wed, Oct 22, 2014 at 09:15:32AM +0200, Ard Biesheuvel wrote: This patch implements the AES key schedule generation using ARMv8 Crypto Instructions. It replaces the table based C implementation in aes_generic.ko, which means we can drop the dependency on that module. Signed-off-by: Ard

[PATCH v2] arm64/crypto: use crypto instructions to generate AES key schedule

2014-11-03 Thread Ard Biesheuvel
This patch implements the AES key schedule generation using ARMv8 Crypto Instructions. It replaces the table based C implementation in aes_generic.ko, which means we can drop the dependency on that module. Tested-by: Steve Capper steve.cap...@linaro.org Acked-by: Steve Capper

Re: [PATCH v2 01/11] crypto: Documentation - crypto API high level spec

2014-11-03 Thread Jonathan Corbet
On Mon, 03 Nov 2014 15:18:29 +0100 Stephan Mueller smuel...@chronox.de wrote: These are all useful. But I wonder if it would be worth the effort to turn this inti a proper docbook document that automatically has everything together in one place? How do you suggest that is done? See

Re: [PATCH] crypto: caam: fix error reporting

2014-11-03 Thread Kim Phillips
On Mon, 3 Nov 2014 11:18:36 +0200 Cristian Stoica cristian.sto...@freescale.com wrote: On 10/31/2014 08:22 PM, Kim Phillips wrote: On Fri, 31 Oct 2014 18:57:33 +0200 Cristian Stoica cristian.sto...@freescale.com wrote: If this issue was brought up by h/w, the appropriate new error codes