Re: [PATCH v2 2/5] dt-bindings : Document the STM32F4 CRC32 binding

2017-05-30 Thread Rob Herring
On Sat, May 20, 2017 at 04:32:12PM +0300, Cosar Dindar wrote: > Add device tree binding for STM32F4. > > Signed-off-by: Cosar Dindar > --- > Documentation/devicetree/bindings/crypto/st,stm32-crc.txt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff

[PATCH V2 23/27] Drivers: ccree: ssi_aead.c - align block comments

2017-05-30 Thread Derek Robson
Fixed block comment alignment, Style fix only Found using checkpatch Signed-off-by: Derek Robson --- drivers/staging/ccree/ssi_aead.c | 45 ++-- 1 file changed, 29 insertions(+), 16 deletions(-) diff --git

[PATCH V2 27/27] Drivers: ccree: cc_crypto_ctx.h - align block comments

2017-05-30 Thread Derek Robson
Fixed block comment alignment, Style fix only Found using checkpatch Signed-off-by: Derek Robson --- drivers/staging/ccree/cc_crypto_ctx.h | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/drivers/staging/ccree/cc_crypto_ctx.h

[PATCH V2 03/27] Drivers: ccree: ssi_request_mgr.h - align block comments

2017-05-30 Thread Derek Robson
Fixed block comment alignment, Style fix only Found using checkpatch Signed-off-by: Derek Robson --- drivers/staging/ccree/ssi_request_mgr.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ccree/ssi_request_mgr.h

[PATCH V2 00/27] Drivers: ccree - align block comments

2017-05-30 Thread Derek Robson
Fixed block comments across whole ccree driver Version #1 has some trailing white space issue in a few patches Derek Robson (27): Drivers: ccree: ssi_sysfs.h - align block comments Drivers: ccree: ssi_sysfs.c - align block comments Drivers: ccree: ssi_request_mgr.h - align block comments

[PATCH V2 02/27] Drivers: ccree: ssi_sysfs.c - align block comments

2017-05-30 Thread Derek Robson
Fixed block comment alignment, Style fix only Found using checkpatch Signed-off-by: Derek Robson --- drivers/staging/ccree/ssi_sysfs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/ccree/ssi_sysfs.c b/drivers/staging/ccree/ssi_sysfs.c

[PATCH V2 04/27] Drivers: ccree: ssi_request_mgr.c - align block comments

2017-05-30 Thread Derek Robson
Fixed block comment alignment, Style fix only Found using checkpatch Signed-off-by: Derek Robson --- drivers/staging/ccree/ssi_request_mgr.c | 37 - 1 file changed, 22 insertions(+), 15 deletions(-) diff --git

[PATCH V2 01/27] Drivers: ccree: ssi_sysfs.h - align block comments

2017-05-30 Thread Derek Robson
Fixed block comment alignment, Style fix only Found using checkpatch Signed-off-by: Derek Robson --- drivers/staging/ccree/ssi_sysfs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ccree/ssi_sysfs.h b/drivers/staging/ccree/ssi_sysfs.h

[PATCH V2 14/27] Drivers: ccree: ssi_fips_data.h - align block comments

2017-05-30 Thread Derek Robson
Fixed block comment alignment, Style fix only Found using checkpatch Signed-off-by: Derek Robson --- drivers/staging/ccree/ssi_fips_data.h | 93 +-- 1 file changed, 46 insertions(+), 47 deletions(-) diff --git

[PATCH V2 13/27] Drivers: ccree: ssi_fips_ext.c - align block comments

2017-05-30 Thread Derek Robson
Fixed block comment alignment, Style fix only Found using checkpatch Signed-off-by: Derek Robson --- drivers/staging/ccree/ssi_fips_ext.c | 46 ++-- 1 file changed, 23 insertions(+), 23 deletions(-) diff --git

[PATCH V2 12/27] Drivers: ccree: ssi_fips_ll.c - align block comments

2017-05-30 Thread Derek Robson
Fixed block comment alignment, Style fix only Found using checkpatch Signed-off-by: Derek Robson --- drivers/staging/ccree/ssi_fips_ll.c | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/drivers/staging/ccree/ssi_fips_ll.c

Re: [PATCH v2 12/12] ARM: sun5i: add a cryptographic engine node

2017-05-30 Thread Antoine Tenart
Hi Maxime, On Tue, May 30, 2017 at 08:48:11AM +0200, Maxime Ripard wrote: > On Mon, May 29, 2017 at 10:27:38PM +0200, Antoine Tenart wrote: > > Add a node for the cryptographic engine that can be found on sun5i SoCs. > > This cryptographic engine is compatible with the Allwinner cryptographic > >

[PATCH V2 07/27] Drivers: ccree: ssi_pm.h - align block comments

2017-05-30 Thread Derek Robson
Fixed block comment alignment, Style fix only Found using checkpatch Signed-off-by: Derek Robson --- drivers/staging/ccree/ssi_pm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ccree/ssi_pm.h b/drivers/staging/ccree/ssi_pm.h index

[PATCH V2 06/27] Drivers: ccree: ssi_pm_ext.c - align block comments

2017-05-30 Thread Derek Robson
Fixed block comment alignment, Style fix only Found using checkpatch Signed-off-by: Derek Robson --- drivers/staging/ccree/ssi_pm_ext.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/ccree/ssi_pm_ext.c

[PATCH V2 05/27] Drivers: ccree: ssi_pm_ext.h - align block comments

2017-05-30 Thread Derek Robson
Fixed block comment alignment, Style fix only Found using checkpatch Signed-off-by: Derek Robson --- drivers/staging/ccree/ssi_pm_ext.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ccree/ssi_pm_ext.h

[PATCH V2 09/27] Drivers: ccree: ssi_hash.h - align block comments

2017-05-30 Thread Derek Robson
Fixed block comment alignment, Style fix only Found using checkpatch Signed-off-by: Derek Robson --- drivers/staging/ccree/ssi_hash.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ccree/ssi_hash.h b/drivers/staging/ccree/ssi_hash.h index

[PATCH V2 10/27] Drivers: ccree: ssi_hash.c - align block comments

2017-05-30 Thread Derek Robson
Fixed block comment alignment, Style fix only Found using checkpatch Signed-off-by: Derek Robson --- drivers/staging/ccree/ssi_hash.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/staging/ccree/ssi_hash.c

[PATCH V2 08/27] Drivers: ccree: ssi_ivgen.c - align block comments

2017-05-30 Thread Derek Robson
Fixed block comment alignment, Style fix only Found using checkpatch Signed-off-by: Derek Robson --- drivers/staging/ccree/ssi_ivgen.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/ccree/ssi_ivgen.c

[PATCH V2 21/27] Drivers: ccree: ssi_buffer_mgr.c - align block comments

2017-05-30 Thread Derek Robson
Fixed block comment alignment, Style fix only Found using checkpatch Signed-off-by: Derek Robson --- drivers/staging/ccree/ssi_buffer_mgr.c | 87 +++--- 1 file changed, 49 insertions(+), 38 deletions(-) diff --git

[PATCH V2 22/27] Drivers: ccree: ssi_aead.h - align block comments

2017-05-30 Thread Derek Robson
Fixed block comment alignment, Style fix only Found using checkpatch Signed-off-by: Derek Robson --- drivers/staging/ccree/ssi_aead.h | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/staging/ccree/ssi_aead.h

[PATCH V2 24/27] Drivers: ccree: hash_defs.h - align block comments

2017-05-30 Thread Derek Robson
Fixed block comment alignment, Style fix only Found using checkpatch Signed-off-by: Derek Robson --- drivers/staging/ccree/hash_defs.h | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/staging/ccree/hash_defs.h

[PATCH V2 25/27] Drivers: ccree: cc_regs.h - align block comments

2017-05-30 Thread Derek Robson
Fixed block comment alignment, Style fix only Found using checkpatch Signed-off-by: Derek Robson --- drivers/staging/ccree/cc_regs.h | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/staging/ccree/cc_regs.h

[PATCH V2 26/27] Drivers: ccree: cc_hw_queue_defs.h - align block comments

2017-05-30 Thread Derek Robson
Fixed block comment alignment, Style fix only Found using checkpatch Signed-off-by: Derek Robson --- drivers/staging/ccree/cc_hw_queue_defs.h | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git

[PATCH V2 20/27] Drivers: ccree: ssi_buffer_mgr.h - align block comments

2017-05-30 Thread Derek Robson
Fixed block comment alignment, Style fix only Found using checkpatch Signed-off-by: Derek Robson --- drivers/staging/ccree/ssi_buffer_mgr.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ccree/ssi_buffer_mgr.h

[PATCH V2 19/27] Drivers: ccree: ssi_cipher.h - align block comments

2017-05-30 Thread Derek Robson
Fixed block comment alignment, Style fix only Found using checkpatch Signed-off-by: Derek Robson --- drivers/staging/ccree/ssi_cipher.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ccree/ssi_cipher.h

[PATCH V2 15/27] Drivers: ccree: ssi_fips.h - align block comments

2017-05-30 Thread Derek Robson
Fixed block comment alignment, Style fix only Found using checkpatch Signed-off-by: Derek Robson --- drivers/staging/ccree/ssi_fips.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/ccree/ssi_fips.h b/drivers/staging/ccree/ssi_fips.h

Re: [PATCH v2 12/12] ARM: sun5i: add a cryptographic engine node

2017-05-30 Thread Maxime Ripard
On Mon, May 29, 2017 at 10:27:38PM +0200, Antoine Tenart wrote: > Add a node for the cryptographic engine that can be found on sun5i SoCs. > This cryptographic engine is compatible with the Allwinner cryptographic > accelerator driver. > > Signed-off-by: Antoine Tenart

Re: [PATCH V2 00/27] Drivers: ccree - align block comments

2017-05-30 Thread Antoine Tenart
Hello Derek, On Tue, May 30, 2017 at 06:09:37PM +1200, Derek Robson wrote: > Fixed block comments across whole ccree driver Since all these commits are doing the same logical change across a single driver, you could probably squash them all into a single one. Thanks! Antoine -- Antoine

[PATCH v2 0/3] Add support for Cavium CNN55XX crypto adapters.

2017-05-30 Thread Srikanth Jampala
This series adds support for Cavium CNN55XX crypto adapters. CNN55XX crypto adapters belongs to Cavium NITROX family series, able to accelerates both Symmetric and Asymmetric crypto workloads. These adapters have crypto cores for Symmetric and Asymmetric crypto operations, and needs to load

[PATCH v2 2/3] crypto: cavium - Add debugfs support in CNN55XX driver.

2017-05-30 Thread Srikanth Jampala
Add debugfs support in CNN55XX Physical Function driver. Provides hardware counters and firmware information. Signed-off-by: Srikanth Jampala --- drivers/crypto/cavium/nitrox/nitrox_csr.h | 4 + drivers/crypto/cavium/nitrox/nitrox_dev.h | 4 +

[PATCH v5 04/14] crypto: ecc - rename ecdh_make_pub_key()

2017-05-30 Thread Tudor Ambarus
Rename ecdh_make_pub_key() to ecc_make_pub_key(). ecdh_make_pub_key() is not dh specific and the reference to dh is wrong. Signed-off-by: Tudor Ambarus --- v5 updates the description of the function by replacing "ecdh_make_pub_key()" with "ecc_make_pub_key()". I also

Re: [PATCH v2 00/12] ARM: sun5i: cryptographic engine support

2017-05-30 Thread Corentin Labbe
On Mon, May 29, 2017 at 10:27:26PM +0200, Antoine Tenart wrote: > Hello, > > This series adds the cryptographic engine support to sun5i SoCs. This is > based on top of v4.12-rc1 and was tested on a CHIP. The series begins > with fixes and improvements. The series is available at: >

[PATCH v2 1/3] crypto: cavium - Add support for CNN55XX adapters.

2017-05-30 Thread Srikanth Jampala
Add Physical Function driver support for CNN55XX crypto adapters. CNN55XX adapters belongs to Cavium NITROX family series, which accelerate both Symmetric and Asymmetric crypto workloads. These adapters have crypto engines that need firmware to become operational. Signed-off-by: Srikanth Jampala

Re: [PATCH v3 1/2] crypto: ecdh - add privkey generation support

2017-05-30 Thread Stephan Müller
Am Dienstag, 30. Mai 2017, 16:52:48 CEST schrieb Tudor Ambarus: Hi Tudor, > + if (!params.key || !params.key_size) > + return ecc_gen_privkey(ctx->curve_id, ctx->ndigits, > +ctx->private_key); > + > if (ecc_is_key_valid(ctx->curve_id,

[PATCH v3 1/2] crypto: ecdh - add privkey generation support

2017-05-30 Thread Tudor Ambarus
Add support for generating ecc private keys. Generation of ecc private keys is helpful in a user-space to kernel ecdh offload because the keys are not revealed to user-space. Private key generation is also helpful to implement forward secrecy. If the user provides a NULL ecc private key, the

[PATCH v3 0/2] crypto: ecdh - add privkey generation support

2017-05-30 Thread Tudor Ambarus
Hi, This patch set adds support for generating ecc private keys. ecc private keys are generated using the method of extra random bits, equivalent to that described in FIPS 186-4, Appendix B.4.1. Generation of ecc private keys is helpful in a user-space to kernel ecdh offload because the keys are

[PATCH v3 2/2] crypto: testmgr - add genkey kpp test

2017-05-30 Thread Tudor Ambarus
The test considers a party that already has a private-public key pair and a party that provides a NULL key. The kernel will generate the private-public key pair for the latter, computes the shared secret on both ends and verifies if it's the same. The explicit private-public key pair was copied

Re: [PATCH v3 1/2] crypto: ecdh - add privkey generation support

2017-05-30 Thread Stephan Müller
Am Dienstag, 30. Mai 2017, 17:18:41 CEST schrieb Tudor Ambarus: Hi Tudor, > You missed the return. When generating the key I just exit with the > return value of ecc_gen_privkey(). Rrrright :-) Reviewed-by: Stephan Müller Ciao Stephan