Re: [PATCH v2 1/4] crypto: jz4780-rng: Add JZ4780 PRNG devicetree binding documentation

On Wed, Aug 23, 2017 at 08:27:04AM +0530, PrasannaKumar Muralidharan wrote: > Add devicetree bindings for hardware pseudo random number generator > present in Ingenic JZ4780 SoC. > > Signed-off-by: PrasannaKumar Muralidharan > --- > Changes in v2: > * Add "syscon" in

Re: [PATCH v2 1/4] crypto: jz4780-rng: Add JZ4780 PRNG devicetree binding documentation

Hi Rob, On 26 August 2017 at 03:27, Rob Herring wrote: > On Wed, Aug 23, 2017 at 08:27:04AM +0530, PrasannaKumar Muralidharan wrote: >> Add devicetree bindings for hardware pseudo random number generator >> present in Ingenic JZ4780 SoC. >> >> Signed-off-by: PrasannaKumar

Dear God's Select,

Dear God's Select, I am writing this mail to you with heavy tears In my eyes and great sorrow in my heart, My Name is Mrs.Jaslin Ikhsan, and I am contacting you from my country Tunisia I want to tell you this because I don't have any other option than to tell you as I was touched to open up to

[RFC PATCH 10/12] crypto: crypto4xx: replace crypto4xx_dev's scatter_buffer_size with constant

scatter_buffer_size is always set to PPC4XX_SD_BUFFER_SIZE. I don't think there's any point in keeping the variable around. Signed-off-by: Christian Lamparter --- drivers/crypto/amcc/crypto4xx_core.c | 7 +++ drivers/crypto/amcc/crypto4xx_core.h | 1 - 2 files

[PATCH 06/12] crypto: crypto4xx: fix dynamic_sa_ctl's sa_contents declaration

The driver had a union dynamic_sa_contents in place that described the meaning of the bits in the sa_contents variable. Signed-off-by: Christian Lamparter --- drivers/crypto/amcc/crypto4xx_alg.c | 4 ++-- drivers/crypto/amcc/crypto4xx_sa.c | 12 ++--

[RFC PATCH 08/12] crypto: crypto4xx: enable AES RFC3686, ECB, CFB and OFB offloads

The crypto engine supports more than just aes-cbc. This patch enables the remaining AES block cipher modes that pass the testmanager's test vectors. Signed-off-by: Christian Lamparter --- drivers/crypto/amcc/crypto4xx_alg.c | 66

[RFC PATCH 09/12] crypto: crypto4xx: refactor crypto4xx_copy_pkt_to_dst()

This patch refactors the crypto4xx_copy_pkt_to_dst() to use scatterwalk_map_and_copy() to copy the processed data between the crypto engine's scatter ring buffer and the destination specified by the ablkcipher_request. This also makes the crypto4xx_fill_one_page() function redundant.

[RFC PATCH 12/12] crypto: crypto4xx: pointer arithmetic overhaul

This patch improves the readability of various functions, by replacing various void* pointers declarations with their respective structs *. This makes it possible to go for the eye-friendly array-indexing methods. Signed-off-by: Christian Lamparter ---

[PATCH 07/12] crypto: crypto4xx: move and refactor dynamic_contents helpers

This patch refactors and moves the dynamic_contents helper functions into the crypto4xx_sa.h header file. * get_dynamic_sa_iv_size is no longer needed, as the cryptoapi provides the required IV size information as well. * refactor the function declarations to use the a pointer to the

[PATCH 04/12] crypto: crypto4xx: remove extern statement before function declaration

All function declarations are "extern" by default, there is no need to specify it explicitly. For C99 states in 6.2.2.5: "If the declaration of an identifier for a function has no storage-class specifier, its linkage is determined exactly as if it were declared with the storage-class specifier

[PATCH 02/12] crypto: crypto4xx: remove unused definitions and write-only variables

This patch removes several unused code and definitons (structs, variables, ...). Signed-off-by: Christian Lamparter --- drivers/crypto/amcc/crypto4xx_alg.c | 6 -- drivers/crypto/amcc/crypto4xx_core.c | 2 +- drivers/crypto/amcc/crypto4xx_core.h | 16

[PATCH 01/12] crypto: crypto4xx: remove bad list_del

alg entries are only added to the list, after the registration was successful. If the registration failed, it was never added to the list in the first place. Signed-off-by: Christian Lamparter --- drivers/crypto/amcc/crypto4xx_core.c | 6 ++ 1 file changed, 2

[RFC PATCH 03/12] crypto: crypto4xx: set CRYPTO_ALG_KERN_DRIVER_ONLY flag

The security offload function is performed by a cryptographic engine core attached to the 128-bit PLB (processor local bus) with builtin DMA and interrupt controllers. This, I think, satisfies the requirement for the CRYPTO_ALG_KERN_DRIVER_ONLY flag. Signed-off-by: Christian Lamparter

[PATCH 11/12] crypto: crypto4xx: fix crypto4xx_build_pdr, crypto4xx_build_sdr leak

If one of the later memory allocations in rypto4xx_build_pdr() fails: dev->pdr (and/or) dev->pdr_uinfo wouldn't be freed. crypto4xx_build_sdr() has the same issue with dev->sdr. Signed-off-by: Christian Lamparter --- drivers/crypto/amcc/crypto4xx_core.c | 17

[PATCH 05/12] crypto: crypto4xx: remove double assignment of pd_uinfo->state

crypto4xx_put_pd_to_pdr() already clears the flag. Signed-off-by: Christian Lamparter --- drivers/crypto/amcc/crypto4xx_core.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/crypto/amcc/crypto4xx_core.c b/drivers/crypto/amcc/crypto4xx_core.c index

[PATCH] crypto: padlock-aes: constify x86_cpu_id

x86_cpu_id are not supposed to change at runtime. MODULE_DEVICE_TABLE and x86_match_cpu are working with const x86_cpu_id. So mark the non-const x86_cpu_id structs as const. Signed-off-by: Arvind Yadav --- drivers/crypto/padlock-aes.c | 2 +- 1 file changed, 1

[PATCH] crypto: padlock-sha: constify x86_cpu_id

x86_cpu_id are not supposed to change at runtime. MODULE_DEVICE_TABLE and x86_match_cpu are working with const x86_cpu_id. So mark the non-const x86_cpu_id structs as const. Signed-off-by: Arvind Yadav --- drivers/crypto/padlock-sha.c | 2 +- 1 file changed, 1