Re: DMA error when sg->offset value is greater than PAGE_SIZE in Intel IOMMU

2017-09-20 Thread Herbert Xu
Harsh Jain wrote: > > While debugging DMA mapping error in chelsio crypto driver we observed that > when scatter/gather list received by driver has some entry with page->offset > > 4096 (PAGE_SIZE). It starts giving DMA error.  Without IOMMU it works fine. This is not a

Re: [PATCH] crypto: AF_ALG - update correct dst SGL entry

2017-09-20 Thread Herbert Xu
On Wed, Aug 30, 2017 at 09:17:39AM +0200, Stephan Müller wrote: > When two adjacent TX SGL are processed and parts of both TX SGLs > are pulled into the per-request TX SGL, the wrong per-request > TX SGL entries were updated. > > This fixes a NULL pointer dereference when a cipher implementation

Re: [PATCH 0/6] crypto: talitos - various fixes

2017-09-20 Thread Christophe LEROY
Looks like the linux-crypto list and patchwork was out of order when I sent this. I will send again, sorry for the noise on the other lists. Le 19/09/2017 à 14:58, Christophe Leroy a écrit : This serie provide various fixes on the talitos driver. Christophe Leroy (6): crypto: talitos -

Test

2017-09-20 Thread Christophe LEROY
Sorry for the noise, but I have twice tried to send a PATCH serie to this list with a copy to linuxppc-...@lists.ozlabs.org, it appears properly in the linuxppc list/patchwork but it still doesn't appear on linux-crypto. Is there anything wrong with the list ? Christophe

Re: DMA error when sg->offset value is greater than PAGE_SIZE in Intel IOMMU

2017-09-20 Thread Robin Murphy
On 20/09/17 09:01, Herbert Xu wrote: > Harsh Jain wrote: >> >> While debugging DMA mapping error in chelsio crypto driver we observed that >> when scatter/gather list received by driver has some entry with page->offset >> > 4096 (PAGE_SIZE). It starts giving DMA error. 

[PATCH] crypto: bcm: use of_device_get_match_data

2017-09-20 Thread Corentin Labbe
The usage of of_device_get_match_data reduce the code size a bit. Furthermore, it prevents an improbable dereference when of_match_device() return NULL. Signed-off-by: Corentin Labbe --- drivers/crypto/bcm/cipher.c | 7 ++- 1 file changed, 2 insertions(+), 5

Re: [PATCH] crypto: AF_ALG - remove SGL end indicator when chaining

2017-09-20 Thread Greg KH
On Wed, Sep 20, 2017 at 03:47:46PM +0200, Stephan Mueller wrote: > Am Mittwoch, 20. September 2017, 10:32:09 CEST schrieb Herbert Xu: > > Hi Herbert, > > > > > Hmm, this patch does not apply against the current tree. Is this > > a stable-only patch? > > This would be a stable-only patch. With

[PATCH] crypto: stm32: use of_device_get_match_data

2017-09-20 Thread Corentin Labbe
The usage of of_device_get_match_data reduce the code size a bit. Furthermore, it prevents an improbable dereference when of_match_device() return NULL. Signed-off-by: Corentin Labbe --- drivers/crypto/stm32/stm32-hash.c | 7 ++- 1 file changed, 2 insertions(+), 5

[PATCH] crypto: omap: use of_device_get_match_data

2017-09-20 Thread Corentin Labbe
The usage of of_device_get_match_data reduce the code size a bit. Furthermore, it prevents an improbable dereference when of_match_device() return NULL. Signed-off-by: Corentin Labbe --- drivers/crypto/omap-aes.c | 7 ++- drivers/crypto/omap-des.c | 7 ++-

Re: [PATCH 0/6] crypto: talitos - various fixes

2017-09-20 Thread christophe leroy
What's going wrong ? I have resent it and it the same again, the serie is not dispatched on the linux-crypto list, but when I answer to a mail of the serie, the answer shows up. What could be the issue ? Christophe Le 20/09/2017 à 10:35, Christophe LEROY a écrit : Looks like the linux-crypto

Re: [PATCH] crypto: AF_ALG - remove SGL end indicator when chaining

2017-09-20 Thread Stephan Mueller
Am Mittwoch, 20. September 2017, 10:32:09 CEST schrieb Herbert Xu: Hi Herbert, > > Hmm, this patch does not apply against the current tree. Is this > a stable-only patch? This would be a stable-only patch. With the overhauling of the AF_ALG memory handling, this is a no-issue any more.

Re: DMA error when sg->offset value is greater than PAGE_SIZE in Intel IOMMU

2017-09-20 Thread Harsh Jain
On 20-09-2017 15:42, Robin Murphy wrote: > On 20/09/17 09:01, Herbert Xu wrote: >> Harsh Jain wrote: >>> While debugging DMA mapping error in chelsio crypto driver we observed that >>> when scatter/gather list received by driver has some entry with >>> page->offset > 4096

Re: DMA error when sg->offset value is greater than PAGE_SIZE in Intel IOMMU

2017-09-20 Thread Harsh Jain
On 20-09-2017 13:31, Herbert Xu wrote: > Harsh Jain wrote: >> While debugging DMA mapping error in chelsio crypto driver we observed that >> when scatter/gather list received by driver has some entry with page->offset >> > 4096 (PAGE_SIZE). It starts giving DMA error.