Re: [v3] crypto: ctr - avoid VLA use

2018-04-04 Thread Salvatore Mesoraca
2018-04-03 23:37 GMT+02:00 Laura Abbott : > On 03/30/2018 01:53 AM, Salvatore Mesoraca wrote: >> --- >> crypto/ctr.c | 15 +-- >> 1 file changed, 13 insertions(+), 2 deletions(-) >> >> diff --git a/crypto/ctr.c b/crypto/ctr.c >> index 854d924..49c469d 100644 >>

Re: [PATCH v15 0/9] Add io{read|write}64 to io-64-atomic headers

2018-04-04 Thread Michael Ellerman
Logan Gunthorpe writes: > This is v14 of my cleanup series to push a number of instances of people > defining their own io{read|write}64 functions into common headers seing > they don't exist in non-64bit systems. This series adds inline functions to > the > io-64-nonatomic

[bug report] crypto: chtls - Inline TLS record Tx

2018-04-04 Thread Dan Carpenter
Hello Atul Gupta, The patch 36bedb3f2e5b: "crypto: chtls - Inline TLS record Tx" from Mar 31, 2018, leads to the following static checker warning: drivers/crypto/chelsio/chtls/chtls_io.c:913 tls_header_read() warn: signedness bug returning '(-14)'

[bug report] crypto: chtls - Inline TLS record Tx

2018-04-04 Thread Dan Carpenter
Hello Atul Gupta, The patch 36bedb3f2e5b: "crypto: chtls - Inline TLS record Tx" from Mar 31, 2018, leads to the following static checker warning: drivers/crypto/chelsio/chtls/chtls_io.c:1210 chtls_sendpage() info: ignoring unreachable code.

Re: [crypto-chtls] Supicious code in chtls_io

2018-04-04 Thread Atul Gupta
On 4/4/2018 3:16 AM, Gustavo A. R. Silva wrote: > Hi all, > > While doing some static analysis I came across the following piece of code at > drivers/crypto/chelsio/chtls/chtls_io.c:1203: > > 1203 if (!size) > 1204 break; > 1205 > 1206 if

Re: [PATCH v15 0/9] Add io{read|write}64 to io-64-atomic headers

2018-04-04 Thread Michael Ellerman
Logan Gunthorpe writes: > On 4/4/2018 4:38 AM, Michael Ellerman wrote: ... >> eg. It looks like I could take the two powerpc patches on their own for >> 4.17, and then the rest could go via other trees? > > Yup! If you can take the powerpc patches I can keep trying to get the

[bug report] crypto: chtls - Inline TLS record Rx

2018-04-04 Thread Dan Carpenter
Hello Atul Gupta, The patch b647993fca14: "crypto: chtls - Inline TLS record Rx" from Mar 31, 2018, leads to the following static checker warning: drivers/crypto/chelsio/chtls/chtls_io.c:1412 chtls_pt_recvmsg() warn: inconsistent indenting drivers/crypto/chelsio/chtls/chtls_io.c

[bug report] crypto: chtls - Register chtls with net tls

2018-04-04 Thread Dan Carpenter
Hello Atul Gupta, The patch a08943947873: "crypto: chtls - Register chtls with net tls" from Mar 31, 2018, leads to the following static checker warning: drivers/crypto/chelsio/chtls/chtls_main.c:447 do_chtls_getsockopt() warn: check that 'crypto_info.cipher_type' doesn't leak

[bug report] crypto: chtls - Program the TLS session Key

2018-04-04 Thread Dan Carpenter
Hello Atul Gupta, The patch d25f2f71f653: "crypto: chtls - Program the TLS session Key" from Mar 31, 2018, leads to the following static checker warning: drivers/crypto/chelsio/chtls/chtls_hw.c:239 chtls_key_info() error: '__memcpy()' 'key' too small (2 vs 32)

[bug report] crypto: chtls - Inline TLS record Tx

2018-04-04 Thread Dan Carpenter
Hello Atul Gupta, This is a semi-automatic email about new static checker warnings. The patch 36bedb3f2e5b: "crypto: chtls - Inline TLS record Tx" from Mar 31, 2018, leads to the following Smatch complaint: drivers/crypto/chelsio/chtls/chtls_io.c:1156 chtls_sendpage() warn: variable

Crypto Update for 4.17

2018-04-04 Thread Herbert Xu
Hi Linus: Here is the crypto update for 4.17: API: - Add AEAD support to crypto engine. - Allow batch registration in simd. Algorithms: - Add CFB mode. - Add speck block cipher. - Add sm4 block cipher. - Add new test case for crct10dif. - Improve scheduling latency on ARM. - Add

Re: [PATCH v15 0/9] Add io{read|write}64 to io-64-atomic headers

2018-04-04 Thread Logan Gunthorpe
On 4/4/2018 4:38 AM, Michael Ellerman wrote: What's the plan for getting it merged? Seems we don't have one? Yeah, so far there is no plan. I'm not really sure who's attention I need to get or how to get it. Given it touches two arches and generic stuff and drivers and crypto, it's a bit