In my effort to remove crypto_alloc_cipher() invocations from non-crypto
code, i ran into a DES call in the CIFS driver. This is addressed in
patch #30.
The other patches are cleanups for the quirky DES interface, and lots
of duplication of the weak key checks etc.
Changes since v4:
- Use dedicat
Switch to the refactored DES key verification routines. While at it,
rename the DES encrypt/decrypt routines so they will not conflict with
the DES library later on.
Reviewed-by: Harald Freudenberger
Signed-off-by: Ard Biesheuvel
---
arch/s390/crypto/des_s390.c | 25 +---
1 file
Switch to the refactored DES key verification routines. While at it,
rename the DES encrypt/decrypt routines so they will not conflict with
the DES library later on.
Signed-off-by: Ard Biesheuvel
---
arch/sparc/crypto/des_glue.c | 37 +---
1 file changed, 16 insertions(+), 21 del
The recently added helper routine to perform key strength validation
of triple DES keys is slightly inadequate, since it comes in two versions,
neither of which are highly useful for anything other than skciphers (and
many drivers still use the older blkcipher interfaces).
So let's add a new helpe
Signed-off-by: Ard Biesheuvel
---
drivers/crypto/atmel-tdes.c | 28 +---
1 file changed, 7 insertions(+), 21 deletions(-)
diff --git a/drivers/crypto/atmel-tdes.c b/drivers/crypto/atmel-tdes.c
index 6256883a89ed..1a6c86ae6148 100644
--- a/drivers/crypto/atmel-tdes.c
+++ b/drivers
Cc: Horia Geanta
Signed-off-by: Ard Biesheuvel
---
drivers/crypto/caam/caamalg.c | 49 ++--
drivers/crypto/caam/caamalg_qi.c | 36 +++---
drivers/crypto/caam/caamalg_qi2.c | 36 +-
drivers/crypto/caam/compat.h | 2 +-
4 files changed, 31 insertions(
Signed-off-by: Ard Biesheuvel
---
drivers/crypto/bcm/cipher.c | 79 +---
1 file changed, 17 insertions(+), 62 deletions(-)
diff --git a/drivers/crypto/bcm/cipher.c b/drivers/crypto/bcm/cipher.c
index 1c23e452700b..f85356a48e7e 100644
--- a/drivers/crypto/bcm/cipher.c
+++ b/driver
Signed-off-by: Ard Biesheuvel
---
drivers/crypto/cavium/cpt/cptvf_algs.c | 26
1 file changed, 5 insertions(+), 21 deletions(-)
diff --git a/drivers/crypto/cavium/cpt/cptvf_algs.c
b/drivers/crypto/cavium/cpt/cptvf_algs.c
index ff3cb1f8f2b6..596ce28b957d 100644
--- a/drivers
Signed-off-by: Ard Biesheuvel
---
drivers/crypto/rockchip/rk3288_crypto.h| 2 +-
drivers/crypto/rockchip/rk3288_crypto_ablkcipher.c | 21 +++-
2 files changed, 8 insertions(+), 15 deletions(-)
diff --git a/drivers/crypto/rockchip/rk3288_crypto.h
b/drivers/crypto/roc
Signed-off-by: Ard Biesheuvel
---
drivers/crypto/inside-secure/safexcel_cipher.c | 24 ++--
1 file changed, 7 insertions(+), 17 deletions(-)
diff --git a/drivers/crypto/inside-secure/safexcel_cipher.c
b/drivers/crypto/inside-secure/safexcel_cipher.c
index 5682fe8b606e..16c4d5460
Signed-off-by: Ard Biesheuvel
---
drivers/crypto/ixp4xx_crypto.c | 27 +---
1 file changed, 6 insertions(+), 21 deletions(-)
diff --git a/drivers/crypto/ixp4xx_crypto.c b/drivers/crypto/ixp4xx_crypto.c
index acedafe3fa98..f3c81bdffaf0 100644
--- a/drivers/crypto/ixp4xx_crypto.c
+
Signed-off-by: Ard Biesheuvel
---
drivers/crypto/stm32/stm32-cryp.c | 30
1 file changed, 5 insertions(+), 25 deletions(-)
diff --git a/drivers/crypto/stm32/stm32-cryp.c
b/drivers/crypto/stm32/stm32-cryp.c
index 5cf6679da580..ba5ea6434f9c 100644
--- a/drivers/crypto/stm32/s
Signed-off-by: Ard Biesheuvel
---
drivers/crypto/cavium/nitrox/nitrox_skcipher.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/crypto/cavium/nitrox/nitrox_skcipher.c
b/drivers/crypto/cavium/nitrox/nitrox_skcipher.c
index 7e4a5e69085e..3cdce1f0f257 100644
--- a/d
Signed-off-by: Ard Biesheuvel
---
drivers/crypto/hisilicon/sec/sec_algs.c | 18 +++---
1 file changed, 7 insertions(+), 11 deletions(-)
diff --git a/drivers/crypto/hisilicon/sec/sec_algs.c
b/drivers/crypto/hisilicon/sec/sec_algs.c
index 02768af0dccd..e0508ea160f1 100644
--- a/driver
Signed-off-by: Ard Biesheuvel
---
drivers/crypto/picoxcell_crypto.c | 24 +++-
1 file changed, 8 insertions(+), 16 deletions(-)
diff --git a/drivers/crypto/picoxcell_crypto.c
b/drivers/crypto/picoxcell_crypto.c
index 9a939b4fd32f..3cbefb41b099 100644
--- a/drivers/crypto/picoxce
Signed-off-by: Ard Biesheuvel
---
drivers/crypto/ccp/ccp-crypto-des3.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/crypto/ccp/ccp-crypto-des3.c
b/drivers/crypto/ccp/ccp-crypto-des3.c
index 5f05f834c7cd..d2c49b2f0323 100644
--- a/drivers/crypto/ccp/ccp-crypt
Signed-off-by: Ard Biesheuvel
---
drivers/crypto/marvell/cipher.c | 25 +++-
1 file changed, 8 insertions(+), 17 deletions(-)
diff --git a/drivers/crypto/marvell/cipher.c b/drivers/crypto/marvell/cipher.c
index fa1997e70b63..84ceddfee76b 100644
--- a/drivers/crypto/marvell/cipher
Signed-off-by: Ard Biesheuvel
---
drivers/crypto/n2_core.c | 32 ++--
1 file changed, 9 insertions(+), 23 deletions(-)
diff --git a/drivers/crypto/n2_core.c b/drivers/crypto/n2_core.c
index 760e72a5893b..4765163df6be 100644
--- a/drivers/crypto/n2_core.c
+++ b/drivers/crypto/n2_c
Cc: Corentin Labbe
Acked-by: Corentin Labbe
Signed-off-by: Ard Biesheuvel
---
drivers/crypto/sunxi-ss/sun4i-ss-cipher.c | 26 +---
drivers/crypto/sunxi-ss/sun4i-ss.h| 2 +-
2 files changed, 7 insertions(+), 21 deletions(-)
diff --git a/drivers/crypto/sunxi-ss/sun4i-ss-
Signed-off-by: Ard Biesheuvel
---
drivers/crypto/ccree/cc_aead.c | 24
drivers/crypto/ccree/cc_cipher.c | 15
2 files changed, 8 insertions(+), 31 deletions(-)
diff --git a/drivers/crypto/ccree/cc_aead.c b/drivers/crypto/ccree/cc_aead.c
index a9779a212b18..d3e
Signed-off-by: Ard Biesheuvel
---
drivers/crypto/hifn_795x.c | 32 +---
1 file changed, 8 insertions(+), 24 deletions(-)
diff --git a/drivers/crypto/hifn_795x.c b/drivers/crypto/hifn_795x.c
index 5c3f02e4aece..a18e62df68d9 100644
--- a/drivers/crypto/hifn_795x.c
+++ b/drivers/cry
Signed-off-by: Ard Biesheuvel
---
drivers/crypto/omap-des.c | 27 ++--
1 file changed, 8 insertions(+), 19 deletions(-)
diff --git a/drivers/crypto/omap-des.c b/drivers/crypto/omap-des.c
index 484a693122af..b19d7e5d55ec 100644
--- a/drivers/crypto/omap-des.c
+++ b/drivers/crypto/
Signed-off-by: Ard Biesheuvel
---
drivers/crypto/qce/ablkcipher.c | 55 ++--
1 file changed, 27 insertions(+), 28 deletions(-)
diff --git a/drivers/crypto/qce/ablkcipher.c b/drivers/crypto/qce/ablkcipher.c
index a976210ba41c..7a98bf5cc967 100644
--- a/drivers/crypto/qce/ablkciphe
Remove the old DES3 verification functions that are no longer used.
Signed-off-by: Ard Biesheuvel
---
include/crypto/des.h | 41
1 file changed, 41 deletions(-)
diff --git a/include/crypto/des.h b/include/crypto/des.h
index 72c7c8e5a5a7..31b04ba835b1 100644
--- a/include/cr
Cc: Christophe Leroy
Signed-off-by: Ard Biesheuvel
---
drivers/crypto/talitos.c | 37
1 file changed, 7 insertions(+), 30 deletions(-)
diff --git a/drivers/crypto/talitos.c b/drivers/crypto/talitos.c
index c9d686a0e805..117c831b5ede 100644
--- a/drivers/crypto/talitos.c
+++
Signed-off-by: Ard Biesheuvel
---
drivers/crypto/ux500/cryp/cryp_core.c | 31 +---
1 file changed, 7 insertions(+), 24 deletions(-)
diff --git a/drivers/crypto/ux500/cryp/cryp_core.c
b/drivers/crypto/ux500/cryp/cryp_core.c
index b4beb54c0dbe..e966e9a64501 100644
--- a/drivers/cr
In preparation of moving the shared key expansion routine into the
DES library, move the verification done by __des3_ede_setkey() into
its callers.
Signed-off-by: Ard Biesheuvel
---
arch/x86/crypto/des3_ede_glue.c | 4
crypto/des_generic.c| 10 +-
2 files changed, 9 ins
Another one for the cipher museum: split off DES core processing into
a separate module so other drivers (mostly for crypto accelerators)
can reuse the code without pulling in the generic DES cipher itself.
This will also permit the cipher interface to be made private to the
crypto API itself once
Some legacy code in the CIFS driver uses single DES to calculate
some password hash, and uses the crypto cipher API to do so. Given
that there is no point in invoking an accelerated cipher for doing
56-bit symmetric encryption on a single 8-byte block of input, the
flexibility of the crypto cipher
Signed-off-by: Ard Biesheuvel
---
crypto/des_generic.c | 13 -
include/crypto/des.h | 3 ---
2 files changed, 16 deletions(-)
diff --git a/crypto/des_generic.c b/crypto/des_generic.c
index e021a321f584..6e13a4a29ecb 100644
--- a/crypto/des_generic.c
+++ b/crypto/des_generic.c
@@ -51
Signed-off-by: Ard Biesheuvel
---
arch/x86/crypto/des3_ede_glue.c | 42 +++-
1 file changed, 23 insertions(+), 19 deletions(-)
diff --git a/arch/x86/crypto/des3_ede_glue.c b/arch/x86/crypto/des3_ede_glue.c
index f730a312ce35..89830e531350 100644
--- a/arch/x86/crypto/des3_ede_glu
On Tue, Aug 6, 2019 at 8:54 AM Pascal van Leeuwen wrote:
>
> The following changes since commit dff98c6c57383fe343407bcb7b6e775e0b87274f:
>
> Merge branch 'master' of git://github.com/skeggsb/linux-firmware
> (2019-07-26 07:32:37 -0400)
>
> are available in the git repository at:
>
>
> https:/
On Thu, Aug 15, 2019 at 08:43:38AM +0300, Ard Biesheuvel wrote:
>
> So I will end up with
>
> static inline int verify_skcipher_des_key(struct crypto_skcipher *tfm,
> const u8 *key)
> static inline int verify_skcipher_des3_key(struct crypto_skcipher *tfm,
>const u8 *key)
> static inline int
On Tue, Aug 06, 2019 at 09:46:22AM +0200, Pascal van Leeuwen wrote:
> This is a first baby step towards making the inside-secure crypto driver
> more broadly useful. The current driver only works for Marvell Armada HW
> and requires proprietary firmware, only available under NDA from Marvell,
> to
This patch fixes a printk format warning by replacing %p with %#lx
for dma_addr_t.
Signed-off-by: Herbert Xu
diff --git a/drivers/crypto/hisilicon/qm.c b/drivers/crypto/hisilicon/qm.c
index d72e062..3095284 100644
--- a/drivers/crypto/hisilicon/qm.c
+++ b/drivers/crypto/hisilicon/qm.c
@@ -347,8
On Mon, Aug 05, 2019 at 03:49:55PM +0300, Horia Geantă wrote:
> In the process of turning caam/qi into a library, the check of
> MCFGR[QI] bit has been inadvertently dropped.
> Fix the condition for DPAA 1.x QI detection, which should be:
> MCFGR[QI] && !MCFGR[DPAA2]
>
> A check in the library exi
On Mon, Aug 05, 2019 at 04:32:41PM -0700, Stephen Boyd wrote:
> The hwrng_fill() function can run while devices are suspending and
> resuming. If the hwrng is behind a bus such as i2c or SPI and that bus
> is suspended, the hwrng may hang the bus while attempting to add some
> randomness. It's been
On Thu, Aug 08, 2019 at 04:00:22PM +0800, Chuhong Yuan wrote:
> Reference counters are preferred to use refcount_t instead of
> atomic_t.
> This is because the implementation of refcount_t can prevent
> overflows and detect possible use-after-free.
> So convert atomic_t ref counters to refcount_t.
On Thu, Aug 08, 2019 at 12:17:37PM +, Phani Kiran Hemadri wrote:
> This patch adds support to allocate CNN55XX device AQMQ command queues
> required for submitting asymmetric crypto requests.
>
> Signed-off-by: Phani Kiran Hemadri
> Reviewed-by: Srikanth Jampala
> ---
> drivers/crypto/caviu
On Thu, Aug 08, 2019 at 06:30:11PM +0200, Jonathan Neuschäfer wrote:
> This fixes the following Sphinx warning:
>
> Documentation/crypto/crypto_engine.rst:2:
> WARNING: Explicit markup ends without a blank line; unexpected unindent.
>
> Signed-off-by: Jonathan Neuschäfer
> ---
> Documentation
On Fri, Aug 09, 2019 at 04:49:05PM +0800, YueHaibing wrote:
> crypto/streebog_generic.c:162:17: warning:
> Pi defined but not used [-Wunused-const-variable=]
> crypto/streebog_generic.c:151:17: warning:
> Tau defined but not used [-Wunused-const-variable=]
>
> They are never used, so can be remo
On Fri, Aug 09, 2019 at 04:29:19PM +0800, YueHaibing wrote:
> crypto/aes_generic.c:64:18: warning:
> rco_tab defined but not used [-Wunused-const-variable=]
>
> It is never used, so can be removed.
>
> Reported-by: Hulk Robot
> Signed-off-by: YueHaibing
> ---
> crypto/aes_generic.c | 2 --
>
On Fri, Aug 09, 2019 at 05:51:07PM +0200, Pascal van Leeuwen wrote:
> Return -EINVAL on an attempt to set the authsize to 0 with an auth.
> algorithm with a non-zero digestsize (i.e. anything but digest_null)
> as authenticating the data and then throwing away the result does not
> make any sense a
On Fri, Aug 09, 2019 at 08:14:57PM +0300, Ard Biesheuvel wrote:
> Add support for the missing ciphertext stealing part of the XTS-AES
> specification, which permits inputs of any size >= the block size.
>
> Cc: Pascal van Leeuwen
> Cc: Ondrej Mosnacek
> Tested-by: Milan Broz
> Signed-off-by: Ar
On Wed, Aug 14, 2019 at 05:28:34PM +0800, Zhou Wang wrote:
> Patch 1~3 are fixes about kbuild errors, patch 4,5 are tiny fixes about qm
> and zip.
>
> This series is based on cryptodev-2.6.
>
> Zhou Wang (5):
> crypto: hisilicon - fix kbuild warnings
> crypto: hisilicon - add dependency for C
On Mon, Aug 12, 2019 at 01:59:09AM +0300, Ard Biesheuvel wrote:
> This series resubmits the aegis128 SIMD patches that were reverted due to
> the fact that the compiler's optimization behavior wrt variables with static
> linkage does not turn out to guarantee that function calls that are
> conditio
Hi Mimi,
On Wed, 14 Aug 2019 at 18:54, Mimi Zohar wrote:
>
> Hi Sumit,
>
> On Tue, 2019-08-13 at 13:22 +0530, Sumit Garg wrote:
> > This patch-set is an outcome of discussion here [1]. It has evolved very
> > much since v1 to create, consolidate and generalize trusted keys
> > subsystem.
> >
> >
On 2019/8/15 20:08, Herbert Xu wrote:
> On Wed, Aug 14, 2019 at 05:28:34PM +0800, Zhou Wang wrote:
>> Patch 1~3 are fixes about kbuild errors, patch 4,5 are tiny fixes about qm
>> and zip.
>>
>> This series is based on cryptodev-2.6.
>>
>> Zhou Wang (5):
>> crypto: hisilicon - fix kbuild warnings
On 2019/8/15 20:03, Herbert Xu wrote:
> This patch fixes a printk format warning by replacing %p with %#lx
> for dma_addr_t.
>
> Signed-off-by: Herbert Xu
>
> diff --git a/drivers/crypto/hisilicon/qm.c b/drivers/crypto/hisilicon/qm.c
> index d72e062..3095284 100644
> --- a/drivers/crypto/hisilic
On Thu, 2019-08-15 at 18:33 +0530, Sumit Garg wrote:
> Hi Mimi,
>
> On Wed, 14 Aug 2019 at 18:54, Mimi Zohar wrote:
> >
> > Hi Sumit,
> >
> > On Tue, 2019-08-13 at 13:22 +0530, Sumit Garg wrote:
> > > This patch-set is an outcome of discussion here [1]. It has evolved very
> > > much since v1 to
Context:
We've run into a possible locking issue when using the AMD CCP device
for crypto offload, with the new extra tests, and with lock debugging
enabled.
Pre-reqs:
Enable the crypto self-tests and extra tests
Build the crypto testing module (tcrypt)
Enable the kern
On Thu, Aug 15, 2019 at 10:17:37PM +0800, Zhou Wang wrote:
>
> > - dev_dbg(&qm->pdev->dev, "QM mailbox request to q%u: %u-%pad\n", queue,
> > - cmd, dma_addr);
> > + dev_dbg(&qm->pdev->dev, "QM mailbox request to q%u: %u-%#lxad\n",
> > + queue, cmd, (unsigned long)dma_addr);
This patch fixes a printk format warning by replacing %p with %#llx
for dma_addr_t.
Signed-off-by: Herbert Xu
diff --git a/drivers/crypto/hisilicon/qm.c b/drivers/crypto/hisilicon/qm.c
index d72e062..cfb0210 100644
--- a/drivers/crypto/hisilicon/qm.c
+++ b/drivers/crypto/hisilicon/qm.c
@@ -347,8
This patch fixes a printk format warning by replacing %p with %#llx
for dma_addr_t.
Signed-off-by: Herbert Xu
diff --git a/drivers/crypto/hisilicon/qm.c b/drivers/crypto/hisilicon/qm.c
index d72e062..4ad4de4 100644
--- a/drivers/crypto/hisilicon/qm.c
+++ b/drivers/crypto/hisilicon/qm.c
@@ -347,8
On Thu, Aug 15, 2019 at 10:08:00PM +1000, Herbert Xu wrote:
> On Fri, Aug 09, 2019 at 08:14:57PM +0300, Ard Biesheuvel wrote:
> > Add support for the missing ciphertext stealing part of the XTS-AES
> > specification, which permits inputs of any size >= the block size.
> >
> > Cc: Pascal van Leeuwe
tree:
https://kernel.googlesource.com/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git
master
head: 198429631a85622da1d08d360ef02cfb84c95919
commit: 00ae05db583a7b5d5575bb601158139e25af3b02 [145/162] crypto: hisilicon -
fix kbuild warnings
config: arm64-allyesconfig (attached as .config)
c
On Thu, 15 Aug 2019 at 20:36, Mimi Zohar wrote:
>
> On Thu, 2019-08-15 at 18:33 +0530, Sumit Garg wrote:
> > Hi Mimi,
> >
> > On Wed, 14 Aug 2019 at 18:54, Mimi Zohar wrote:
> > >
> > > Hi Sumit,
> > >
> > > On Tue, 2019-08-13 at 13:22 +0530, Sumit Garg wrote:
> > > > This patch-set is an outcome
On Fri, 16 Aug 2019 at 04:02, Eric Biggers wrote:
>
> On Thu, Aug 15, 2019 at 10:08:00PM +1000, Herbert Xu wrote:
> > On Fri, Aug 09, 2019 at 08:14:57PM +0300, Ard Biesheuvel wrote:
> > > Add support for the missing ciphertext stealing part of the XTS-AES
> > > specification, which permits inputs
On 2019/8/16 6:47, Herbert Xu wrote:
> This patch fixes a printk format warning by replacing %p with %#llx
> for dma_addr_t.
>
> Signed-off-by: Herbert Xu
>
> diff --git a/drivers/crypto/hisilicon/qm.c b/drivers/crypto/hisilicon/qm.c
> index d72e062..4ad4de4 100644
> --- a/drivers/crypto/hisilic
59 matches
Mail list logo
