Re: [PATCH 3.11-rc1] crypto: Fix boot failure due to module dependency.

2013-07-19 Thread Greg Kroah-Hartman
On Fri, Jul 19, 2013 at 11:38:04PM +0200, Rafael J. Wysocki wrote: Alas, this is not the one I'd like to apply. With that patch applied, new device objects are created to avoid binding the processor driver directly to the cpu system device objects, because that apparently confuses udev and

Re: [PATCH 3.11-rc1] crypto: Fix boot failure due to module dependency.

2013-07-19 Thread Greg Kroah-Hartman
On Fri, Jul 19, 2013 at 04:21:09PM -0700, H. Peter Anvin wrote: On 07/19/2013 04:16 PM, Greg Kroah-Hartman wrote: udev isn't doing any module loading, 'modprobe' is just being called for any new module alias that shows up in the system, and all of the drivers that match it then get

Re: [PATCH] Fix late crypto work queue initialization

2014-03-25 Thread Greg Kroah-Hartman
On Tue, Mar 25, 2014 at 04:40:56PM -0700, Tim Chen wrote: On Fri, 2014-03-21 at 22:40 +0800, Herbert Xu wrote: On Mon, Mar 17, 2014 at 04:52:26PM -0700, Tim Chen wrote: The crypto algorithm modules utilizing the crypto daemon could be used early when the system start up. Using

Re: [PATCH] crypto/nx/nx-842: dev_set_drvdata can no longer fail

2014-05-28 Thread Greg Kroah-Hartman
On Wed, May 28, 2014 at 02:02:24PM +0200, Jean Delvare wrote: Don't check if dev_set_drvdata() failed, it can't, and it returns void now. Signed-off-by: Jean Delvare jdelv...@suse.de Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Cc: Robert Jennings r...@linux.vnet.ibm.com Cc: Marcelo

[PATCH 3.16 054/125] crypto: ux500 - make interrupt mode plausible

2014-09-03 Thread Greg Kroah-Hartman
fabio.balti...@linaro.org Cc: Linus Walleij linus.wall...@linaro.org Cc: Herbert Xu herb...@gondor.apana.org.au Cc: David S. Miller da...@davemloft.net Signed-off-by: Herbert Xu herb...@gondor.apana.org.au Signed-off-by: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/crypto/ux500/cryp

[PATCH 3.14 38/88] crypto: ux500 - make interrupt mode plausible

2014-09-03 Thread Greg Kroah-Hartman
fabio.balti...@linaro.org Cc: Linus Walleij linus.wall...@linaro.org Cc: Herbert Xu herb...@gondor.apana.org.au Cc: David S. Miller da...@davemloft.net Signed-off-by: Herbert Xu herb...@gondor.apana.org.au Signed-off-by: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/crypto/ux500/cryp

[PATCH 3.10 27/55] crypto: ux500 - make interrupt mode plausible

2014-09-03 Thread Greg Kroah-Hartman
fabio.balti...@linaro.org Cc: Linus Walleij linus.wall...@linaro.org Cc: Herbert Xu herb...@gondor.apana.org.au Cc: David S. Miller da...@davemloft.net Signed-off-by: Herbert Xu herb...@gondor.apana.org.au Signed-off-by: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/crypto/ux500/cryp

Re: [PATCH 03/13] serial: 8250_dma: Support for deferred probing when requesting DMA channels

2015-05-26 Thread Greg Kroah-Hartman
On Tue, May 26, 2015 at 04:25:58PM +0300, Peter Ujfalusi wrote: Switch to use ma_request_slave_channel_compat_reason() to request the DMA channels. In case of error, return the error code we received including -EPROBE_DEFER I think you typed the function name wrong here :( -- To unsubscribe

Re: [PATCH] random: Don't overwrite CRNG state in crng_initialize()

2017-02-09 Thread Greg Kroah-Hartman
On Thu, Feb 09, 2017 at 02:04:32AM -0700, Alden Tondettar wrote: > On Thu, Feb 09, 2017 at 07:47:25AM +0100, Greg Kroah-Hartman wrote: > > On Wed, Feb 08, 2017 at 08:31:26PM -0700, Alden Tondettar wrote: > > > In short, the situation is: > > > > > > A) No us

Re: [PATCH] random: Don't overwrite CRNG state in crng_initialize()

2017-02-08 Thread Greg Kroah-Hartman
On Wed, Feb 08, 2017 at 08:31:26PM -0700, Alden Tondettar wrote: > In short, the situation is: > > A) No usable hardware RNG or arch_get_random() (or we don't trust it...) Wait, why would you not trust arch_get_random()? Is it broken somehow on some arches? If so, why not fix that as well?

Re: [PATCH] linux/types.h: enable endian checks for all sparse builds

2016-12-08 Thread Greg Kroah-Hartman
On Thu, Dec 08, 2016 at 06:38:11AM +, Bart Van Assche wrote: > On 12/07/16 21:54, Michael S. Tsirkin wrote: > > On Thu, Dec 08, 2016 at 05:21:47AM +, Bart Van Assche wrote: > >> Additionally, there are notable exceptions to the rule that most drivers > >> are endian-clean, e.g.

[PATCH 4.9 62/88] hwrng: geode - Revert managed API changes

2017-03-28 Thread Greg Kroah-Hartman
an <prasannatsmku...@gmail.com> Cc: Wei Yongjun <weiyongj...@huawei.com> Cc: linux-crypto@vger.kernel.org Cc: linux-ge...@lists.infradead.org Signed-off-by: Herbert Xu <herb...@gondor.apana.org.au> Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> --- driver

[PATCH 4.9 61/88] hwrng: amd - Revert managed API changes

2017-03-28 Thread Greg Kroah-Hartman
dharan <prasannatsmku...@gmail.com> Cc: Wei Yongjun <weiyongj...@huawei.com> Cc: linux-crypto@vger.kernel.org Cc: linux-ge...@lists.infradead.org Signed-off-by: Herbert Xu <herb...@gondor.apana.org.au> Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> --- drivers/char/h

[PATCH 4.10 075/111] hwrng: amd - Revert managed API changes

2017-03-28 Thread Greg Kroah-Hartman
dharan <prasannatsmku...@gmail.com> Cc: Wei Yongjun <weiyongj...@huawei.com> Cc: linux-crypto@vger.kernel.org Cc: linux-ge...@lists.infradead.org Signed-off-by: Herbert Xu <herb...@gondor.apana.org.au> Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> --- drivers/ch

[PATCH 4.10 076/111] hwrng: geode - Revert managed API changes

2017-03-28 Thread Greg Kroah-Hartman
an <prasannatsmku...@gmail.com> Cc: Wei Yongjun <weiyongj...@huawei.com> Cc: linux-crypto@vger.kernel.org Cc: linux-ge...@lists.infradead.org Signed-off-by: Herbert Xu <herb...@gondor.apana.org.au> Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> --- driver

Re: [PATCH] crypto: vmx: Remove dubiously licensed crypto code

2017-03-29 Thread Greg Kroah-Hartman
On Wed, Mar 29, 2017 at 02:56:39PM +0200, Michal Suchanek wrote: > While reviewing commit 11c6e16ee13a ("crypto: vmx - Adding asm > subroutines for XTS") which adds the OpenSSL license header to > drivers/crypto/vmx/aesp8-ppc.pl licensing of this driver came into > qestion. The whole license

Re: [PATCH v2 0/9] staging: ccree: add Arm TrustZone CryptoCell REE driver

2017-04-20 Thread Greg Kroah-Hartman
On Thu, Apr 20, 2017 at 04:12:54PM +0300, Gilad Ben-Yossef wrote: > Arm TrustZone CryptoCell 700 is a family of cryptographic hardware > accelerators. It is supported by a long lived series of out of tree > drivers, which I am now in the process of unifying and upstreaming. > This is the first

Re: [PATCH v2 1/9] staging: ccree: introduce CryptoCell HW driver

2017-04-20 Thread Greg Kroah-Hartman
On Thu, Apr 20, 2017 at 04:12:55PM +0300, Gilad Ben-Yossef wrote: > +++ b/drivers/staging/ccree/bsp.h > @@ -0,0 +1,21 @@ > +/* > + * Copyright (C) 2012-2016 ARM Limited or its affiliates. > + * > + * This program is free software; you can redistribute it and/or modify it > + * under the terms of

Re: [PATCH v2 1/9] staging: ccree: introduce CryptoCell HW driver

2017-04-20 Thread Greg Kroah-Hartman
On Thu, Apr 20, 2017 at 04:40:56PM +0300, Gilad Ben-Yossef wrote: > On Thu, Apr 20, 2017 at 4:33 PM, Greg Kroah-Hartman > <gre...@linuxfoundation.org> wrote: > > On Thu, Apr 20, 2017 at 04:12:55PM +0300, Gilad Ben-Yossef wrote: > >> +++ b/drivers/staging/ccr

Re: [PATCH 0/4] staging: add ccree crypto driver

2017-04-18 Thread Greg Kroah-Hartman
On Tue, Apr 18, 2017 at 05:07:50PM +0300, Gilad Ben-Yossef wrote: > Arm TrustZone CryptoCell 700 is a family of cryptographic hardware > accelerators. It is supported by a long lived series of out of tree > drivers, which I am now in the process of unifying and upstreaming. > This is the first

Re: [PATCH v3 11/22] staging: ccree: fix line indentation and breaks

2017-08-16 Thread Greg Kroah-Hartman
On Tue, Aug 15, 2017 at 09:26:39AM +0300, Gilad Ben-Yossef wrote: > Fix wrong indentation and line breaks, including missing tabs, > breaking lines longer then 80 char or wrongly broken. > > Signed-off-by: Gilad Ben-Yossef > --- > drivers/staging/ccree/ssi_driver.c | 107 >

Re: [PATCH 00/12] staging: ccree: coding style fixes

2017-07-14 Thread Greg Kroah-Hartman
On Thu, Jul 13, 2017 at 11:19:50AM +0300, Gilad Ben-Yossef wrote: > Another batch of ccree coding style fixes. > > These goes on top of commit a8c4ae12 ("staging: ccree: Fix alignment issues > in ssi_sysfs.c") > in staging-testing. Odd, some of these did not apply, but others did. Please

Re: [RFC PATCH v12 3/4] Linux Random Number Generator

2017-07-18 Thread Greg Kroah-Hartman
On Tue, Jul 18, 2017 at 10:45:12AM +0200, Stephan Müller wrote: > Am Dienstag, 18. Juli 2017, 10:32:10 CEST schrieb Greg Kroah-Hartman: > > Hi Greg, > > > external references do not last as long as the kernel change log does :( > > What would be the best way to cite a

Re: [RFC PATCH v12 1/4] crypto: make Jitter RNG directly accessible

2017-07-18 Thread Greg Kroah-Hartman
On Tue, Jul 18, 2017 at 10:40:07AM +0200, Stephan Müller wrote: > Am Dienstag, 18. Juli 2017, 10:30:14 CEST schrieb Greg Kroah-Hartman: > > Hi Greg, > > > > +typedef unsigned long long __u64; > > > +typedef long long __s64; > > > >

Re: [RFC PATCH v12 3/4] Linux Random Number Generator

2017-07-18 Thread Greg Kroah-Hartman
On Tue, Jul 18, 2017 at 09:59:09AM +0200, Stephan Müller wrote: > The LRNG with the following properties: > > * noise source: interrupts timing with fast boot time seeding > > * lockless LFSR to collect raw entropy > > * use of standalone ChaCha20 based RNG with the option to use a >

Re: [RFC PATCH v12 3/4] Linux Random Number Generator

2017-07-18 Thread Greg Kroah-Hartman
On Tue, Jul 18, 2017 at 10:45:12AM +0200, Stephan Müller wrote: > Am Dienstag, 18. Juli 2017, 10:32:10 CEST schrieb Greg Kroah-Hartman: > > Hi Greg, > > > external references do not last as long as the kernel change log does :( > > What would be the best way to cite a

Re: [RFC PATCH v12 1/4] crypto: make Jitter RNG directly accessible

2017-07-18 Thread Greg Kroah-Hartman
On Tue, Jul 18, 2017 at 09:57:55AM +0200, Stephan Müller wrote: > --- /dev/null > +++ b/include/crypto/jitterentropy.h > @@ -0,0 +1,80 @@ > +/* > + * Copyright (C) 2017, Stephan Mueller > + * > + * Redistribution and use in source and binary forms, with or without > + *

Re: [RFC PATCH v12 3/4] Linux Random Number Generator

2017-07-19 Thread Greg Kroah-Hartman
On Wed, Jul 19, 2017 at 08:22:18AM +0200, Stephan Müller wrote: > Am Dienstag, 18. Juli 2017, 23:08:16 CEST schrieb Theodore Ts'o: > > Hi Theodore, > > > > I've been trying to take the best features and suggestions from your > > proposal and integrating them into /dev/random already. Things

Re: [PATCH 0/4] staging: ccree: coding style clean ups

2017-07-27 Thread Greg Kroah-Hartman
On Thu, Jul 27, 2017 at 01:43:14PM +0300, Gilad Ben-Yossef wrote: > Misc. coding style fixes for ccree driver. > > These are the missing patches that failed to apply two weeks ago, > rebased onto latest staging-next. > > By the way, I still do not understand why they failed to apply, > as they

Re: [PATCH 1/3] staging: ccree: Replace kzalloc with devm_kzalloc

2017-07-27 Thread Greg Kroah-Hartman
On Thu, Jul 27, 2017 at 05:27:32PM +0300, Gilad Ben-Yossef wrote: > From: Suniel Mahesh > > It is recommended to use managed function devm_kzalloc, which > simplifies driver cleanup paths and driver code. > This patch does the following: > (a) replace kzalloc with

Re: [PATCH 0/2] staging: ccree: Fix coding style and remove warnings

2017-06-29 Thread Greg Kroah-Hartman
On Thu, Jun 29, 2017 at 04:13:38PM +0530, karthik wrote: > On Wednesday 28 June 2017 03:15 PM, Gilad Ben-Yossef wrote: > > Thank you Karthik, > > > > On Wed, Jun 28, 2017 at 12:37 PM, wrote: > > > From: Karthik Tummala > > > > > > This patch series

Re: [PATCH v3 00/22] staging: ccree: fixes and simplifications

2017-08-16 Thread Greg Kroah-Hartman
On Tue, Aug 15, 2017 at 09:26:28AM +0300, Gilad Ben-Yossef wrote: > The series includes various bug fixes, code simplification and style > cleanups. > > Changer from v2: > - Drop M32R as supported architecture, which resolve the kbuild bot > warnings on Joe Perches patch. > - Bug fix that

Re: [PATCH] drivers/staging/ccree: Fixing coding guideline errors

2017-05-16 Thread Greg Kroah-Hartman
On Tue, May 16, 2017 at 01:35:52PM +0530, Pushkar Jambhlekar wrote: > Fixing coding guideline errors reported by 'checkpatch.pl' That is very "vague", you are going to have to be specific here. Also remember you can only do "one type of thing" per patch, and no, "fix all warnings" is not one

Re: [PATCH v2 3/7] staging: ccree: add support for older HW revisions

2017-06-23 Thread Greg Kroah-Hartman
On Thu, Jun 22, 2017 at 04:36:57PM +0300, Gilad Ben-Yossef wrote: > Add support for the older CryptoCell 710 and 630P hardware revisions. No, I do not want to add new features to staging drivers where ever possible. I want you to spend your time fixing up the code to be good enough to get it out

Re: [PATCH v2 5/7] staging: ccree: add clock management support

2017-06-23 Thread Greg Kroah-Hartman
On Thu, Jun 22, 2017 at 04:36:59PM +0300, Gilad Ben-Yossef wrote: > Some SoC which implement CryptoCell have a dedicated clock > tied to it, some do not. Implement clock support if exists > based on device tree data and tie power management to it. > > Signed-off-by: Gilad Ben-Yossef

Re: [PATCH v2 2/7] staging: ccree: register setkey for none hash macs

2017-06-23 Thread Greg Kroah-Hartman
On Thu, Jun 22, 2017 at 04:36:56PM +0300, Gilad Ben-Yossef wrote: > Fix a bug where the transformation init code did > not register a setkey method for none hash based MACs. "none hash based MACs"? Is that the correct language, I don't understand it, sorry, can you expand on it a bit in your v3

Re: [PATCH 02/12] staging: ccree: move to kernel bitfields/bitops

2017-05-29 Thread Greg Kroah-Hartman
On Sun, May 28, 2017 at 05:40:27PM +0300, Gilad Ben-Yossef wrote: > ccree had a lot of boilerplate code for dealing with bitops > and bitfield register access. Move it over to the generic kernel > infrastructure used for doing the same. > > Signed-off-by: Gilad Ben-Yossef >

Re: [PATCH 04/12] staging: ccree: cleanup lli access macro

2017-05-29 Thread Greg Kroah-Hartman
On Sun, May 28, 2017 at 05:40:29PM +0300, Gilad Ben-Yossef wrote: > The Linked List Item descriptors were being accessed via > a baroque set of defines and macro. Re-factor for structs > and inline function for readability and sanity. > > Signed-off-by: Gilad Ben-Yossef >

Re: [PATCH 01/12] staging: ccree: correct coding style violations

2017-05-29 Thread Greg Kroah-Hartman
On Sun, May 28, 2017 at 05:40:26PM +0300, Gilad Ben-Yossef wrote: > cc_crypto_ctx.h had multiple coding style violations reported by > checkpatch. Fix them all. Sorry, no. You need to do only one-thing-per-patch, and "fix all coding style issues is not "one thing". I wouldn't take this kind of

Re: [PATCH v2 02/20] staging: ccree: replace bit shift with BIT macro

2017-06-03 Thread Greg Kroah-Hartman
On Thu, Jun 01, 2017 at 02:02:52PM +0300, Gilad Ben-Yossef wrote: > CC_CTX_SIZE was being defined using a hand rolled bit shift operation. > Replace with use of BIT macro. > > Signed-off-by: Gilad Ben-Yossef > --- > drivers/staging/ccree/cc_crypto_ctx.h | 2 +- > 1 file

Re: [PATCH RFC v2 0/8] get_random_bytes_wait family of APIs

2017-06-06 Thread Greg Kroah-Hartman
On Tue, Jun 06, 2017 at 01:47:25AM +0200, Jason A. Donenfeld wrote: > As this RFC series matures, all the changes are in this branch here, to look > at: > > https://git.zx2c4.com/linux-dev/log/?h=jd/rng-blocker > > Ted -- there's one, in particular, that should probably be picked up >

Re: [PATCH] staging: ccree: Add missing newlines

2017-09-11 Thread Greg Kroah-Hartman
On Sat, Sep 09, 2017 at 11:18:02PM -0700, Joe Perches wrote: > Logging without newlines are still prone to interleaving. > Add newlines where necessary. Doesn't apply to my staging-testing branch, due to other changes in this driver. Can you rebase it onto that branch and resend? thanks, greg

[PATCH 4.9 27/77] [PATCH - RESEND] crypto: AF_ALG - remove SGL terminator indicator when chaining

2017-09-24 Thread Greg Kroah-Hartman
r stable. Fixes: 8ff590903d5fc ("crypto: algif_skcipher - User-space interface for skcipher operations") Signed-off-by: Stephan Mueller <smuel...@chronox.de> Acked-by: Herbert Xu <herb...@gondor.apana.org.au> Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation

[PATCH 4.13 034/109] [PATCH - RESEND] crypto: AF_ALG - remove SGL terminator indicator when chaining

2017-09-24 Thread Greg Kroah-Hartman
arked for stable. Fixes: 8ff590903d5fc ("crypto: algif_skcipher - User-space interface for skcipher operations") Signed-off-by: Stephan Mueller <smuel...@chronox.de> Acked-by: Herbert Xu <herb...@gondor.apana.org.au> Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation

[PATCH 3.18 11/42] [PATCH - RESEND] crypto: AF_ALG - remove SGL terminator indicator when chaining

2017-09-24 Thread Greg Kroah-Hartman
arked for stable. Fixes: 8ff590903d5fc ("crypto: algif_skcipher - User-space interface for skcipher operations") Signed-off-by: Stephan Mueller <smuel...@chronox.de> Acked-by: Herbert Xu <herb...@gondor.apana.org.au> Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation

[PATCH 4.4 27/66] [PATCH - RESEND] crypto: AF_ALG - remove SGL terminator indicator when chaining

2017-09-24 Thread Greg Kroah-Hartman
r stable. Fixes: 8ff590903d5fc ("crypto: algif_skcipher - User-space interface for skcipher operations") Signed-off-by: Stephan Mueller <smuel...@chronox.de> Acked-by: Herbert Xu <herb...@gondor.apana.org.au> Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation

Re: [PATCH 0/3] More code cleanups

2017-11-05 Thread Greg Kroah-Hartman
On Mon, Nov 06, 2017 at 06:55:49AM +, Gilad Ben-Yossef wrote: > Additional code readability and simplification patches. > These goes on top the previous patch set sent to the list. Please label your 0/X patches the same way your patches are, with the prefix of the subsystem, otherwise they

Re: [PATCH 0/3] More code cleanups

2017-11-05 Thread Greg Kroah-Hartman
On Mon, Nov 06, 2017 at 09:41:09AM +0200, Gilad Ben-Yossef wrote: > On Mon, Nov 6, 2017 at 9:38 AM, Greg Kroah-Hartman > <gre...@linuxfoundation.org> wrote: > > On Mon, Nov 06, 2017 at 06:55:49AM +, Gilad Ben-Yossef wrote: > >> Additional code readability

Re: [PATCH 3/3] staging: ccree: simplify ioread/iowrite

2017-11-06 Thread Greg Kroah-Hartman
On Mon, Nov 06, 2017 at 10:59:47AM +0200, Gilad Ben-Yossef wrote: > On Mon, Nov 6, 2017 at 10:37 AM, Tobin C. Harding wrote: > > On Mon, Nov 06, 2017 at 06:55:52AM +, Gilad Ben-Yossef wrote: > >> Registers ioread/iowrite operations were done via macros, > >> sometime using a