Re: [PATCH v3 1/6] tpm-buf: create new functions for handling TPM buffers

2018-03-12 Thread J Freyensee
+int tpm_buf_init(struct tpm_buf *buf, u16 tag, u32 ordinal) +{ + int rc; + + rc = __tpm_buf_init(buf); Assuming that functions like tpm_buf_init() are the top-level API being defined in this patch, shouldn't it check if buf is valid before passing into the internal functions

Re: [PATCH v3 1/6] tpm-buf: create new functions for handling TPM buffers

2018-03-13 Thread J Freyensee
On 3/12/18 10:59 AM, James Bottomley wrote: On Mon, 2018-03-12 at 09:00 -0700, J Freyensee wrote: +int tpm_buf_init(struct tpm_buf *buf, u16 tag, u32 ordinal) +{ + int rc; + + rc = __tpm_buf_init(buf); Assuming that functions like tpm_buf_init() are the top-level API being