Re: [PATCH resend 4.9] hw_random: Don't use a stack buffer in add_early_randomness()

2017-02-03 Thread Matt Mullins
On Sat, Feb 04, 2017 at 11:47:38AM +0800, Yisheng Xie wrote: > On 2016/10/18 1:06, Andy Lutomirski wrote: > > hw_random carefully avoids using a stack buffer except in > > add_early_randomness(). This causes a crash in virtio_rng if > > CONFIG_VMAP_STACK=y. > I try to understand this patch, but I

virtio-rng scatterlist null pointer dereference with VMAP_STACK=y

2016-10-15 Thread Matt Mullins
With VMAP_STACK=y and HW_RANDOM_VIRTIO=y, I get the following crash: [1.470437] BUG: unable to handle kernel NULL pointer dereference at (null) [1.473350] IP: [] sg_init_one+0x65/0x90 [1.474658] PGD 0 [1.475169] Oops: [#1] SMP Entering kdb (current=0x880069b0c980, pid

Re: [PATCH 4.9] hw_random: Don't use a stack buffer in add_early_randomness()

2016-10-16 Thread Matt Mullins
t purpose of virt_to_page(). This boots on the VM from which I had grabbed the stack trace yesterday. Tested-by: Matt Mullins <mmull...@mmlx.us> Looks like an extra quote snuck in your To: line, so I'm not sure if this was distributed as widely as you intended. -- To unsubscribe from this list