atch that makes this
>
> Signed-off-by: Julia Lawall
>
> ---
> Daniel Borkmann suggested that these patches could go through Herbert Xu's
> cryptodev tree.
That's fine by me:
Acked-by: Michael Ellerman
cheers
--
To unsubscribe from this list: send the line "un
Marcelo Cerri writes:
> [ Unknown signature status ]
> On Wed, Sep 28, 2016 at 09:20:15PM +0800, Herbert Xu wrote:
>> On Wed, Sep 28, 2016 at 10:15:51AM -0300, Marcelo Cerri wrote:
>> > Hi Herbert,
>> >
>> > Any thoughts on this one?
>>
>> Can this patch wait until the next merge window? On the
"Naveen N. Rao" writes:
> ..as stray .S files result in build errors, especially when using
> cross-compilers.
They should be cleaned on make clean, so adding them to clean-files
seems correct.
> More specifically, the generated .S files are endian-specific and will break
> subsequent builds ta
ild tree, rather than the source tree.
>
> Signed-off-by: Michael Ellerman
> Signed-off-by: Naveen N. Rao
> ---
> Michael,
> I've added your SOB here though you didn't explicitly include it in your
> previous mail. I hope that's fine from your end.
Yeah that'
Daniel Axtens writes:
> Turning on crypto self-tests on a POWER8 shows:
>
> alg: hash: Test 1 failed for crc32c-vpmsum
> : ff ff ff ff
>
> Comparing the code with the Intel CRC32c implementation on which
> ours is based shows that we are doing an init with 0, not ~0
> as CRC32c re
Herbert Xu writes:
> On Fri, Jul 21, 2017 at 09:57:39PM -0700, Haren Myneni wrote:
>>
>> Configure CRB is moved to nx842_configure_crb() so that it can
>> be used for icswx and VAS exec functions. VAS function will be
>> added later with P9 support.
>>
>> Signed-off-by: Haren Myneni
>
> Your p
Hi Haren,
Some comments inline ...
Haren Myneni writes:
> diff --git a/drivers/crypto/nx/nx-842-powernv.c
> b/drivers/crypto/nx/nx-842-powernv.c
> index c0dd4c7e17d3..13089a0b9dfa 100644
> --- a/drivers/crypto/nx/nx-842-powernv.c
> +++ b/drivers/crypto/nx/nx-842-powernv.c
> @@ -32,6 +33,9 @@ M
Hi Dan,
Thanks for reviewing this series.
Dan Streetman writes:
> On Tue, Aug 29, 2017 at 5:54 PM, Haren Myneni
> wrote:
>> On 08/29/2017 02:23 PM, Benjamin Herrenschmidt wrote:
>>> On Tue, 2017-08-29 at 09:58 -0400, Dan Streetman wrote:
> +
> + ret = -EINVAL;
> + if (c
Haren Myneni writes:
>> On Mon, Aug 28, 2017 at 7:25 PM, Michael Ellerman
>> wrote:
>>> Hi Haren,
>>>
>>> Some comments inline ...
>>>
>>> Haren Myneni writes:
>>>
>>>> diff --git a/drivers/crypto/nx/nx-84
On Thu, 2017-08-31 at 07:11:29 UTC, Haren Myneni wrote:
> Rename nx842_powernv_function to nx842_powernv_exec.
> nx842_powernv_exec points to nx842_exec_icswx and
> will be point to VAS exec function which will be added later
> for P9 NX support.
>
> Signed-off-by: Haren Myneni
Series applied to
On Mon, 2017-09-25 at 06:43:02 UTC, Haren Myneni wrote:
> [PATCH 1/2] crypto/nx: Use percpu send window for NX requests
>
> For P9 NX, the send window is opened for each crypto session and closed
> upon free. But VAS supports 64K windows per chip for all coprocessors
> including in user space supp
gt;
> It looks good to me. Michael?
I didn't get the cover letter, or any of the rest of the series, so although I
saw the patch I had no context. And I didn't have time to chase it up.
At a glance it seems fine, so:
Acked-by: Michael Ellerman
cheers
--
To unsubsc
On Tue, 2016-19-07 at 04:03:53 UTC, Alastair D'Silva wrote:
> From: Alastair D'Silva
>
> This patch utilises the GENERIC_CPU_AUTOPROBE infrastructure
> to automatically load the vmx_crypto module if the CPU supports
> it.
>
> Signed-off-by: Alastair D'Silva
Applied to powerpc next, thanks.
ht
On Tue, 2016-19-07 at 04:03:52 UTC, Alastair D'Silva wrote:
> From: Alastair D'Silva
>
> This patch provides the necessary infrastructure to allow drivers
> to be automatically loaded via UDEV. It implements the minimum
> required to be able to use module_cpu_feature_match to trigger
> the GENERI
Anton Blanchard writes:
> From: Anton Blanchard
>
> This patch utilises the GENERIC_CPU_AUTOPROBE infrastructure
> to automatically load the crc32c-vpmsum module if the CPU supports
> it.
>
> Signed-off-by: Anton Blanchard
> ---
> arch/powerpc/crypto/crc32c-vpmsum_glue.c | 3 ++-
> 1 file chan
Anton Blanchard writes:
> Hi Michael,
>
>> Is VEC_CRYPTO the right feature?
>>
>> That's new power8 crypto stuff.
>
> The vpmsum* instructions are part of the same pipeline as the vcipher*
> instructions, introduced in POWER8.
OK.
>> I thought this only used VMX? (but I haven't looked closely)
The optimised crc32c implementation depends on VMX (aka. Altivec)
instructions, so the kernel must be built with Altivec support in order
for the crc32c code to build.
Fixes: 6dd7a82cc54e ("crypto: powerpc - Add POWER8 optimised crc32c")
Acked-by: Anton Blanchard
Signed-off-by: Michae
On Thu, 2016-04-08 at 06:38:15 UTC, Anton Blanchard wrote:
> From: Anton Blanchard
>
> This patch utilises the GENERIC_CPU_AUTOPROBE infrastructure
> to automatically load the crc32c-vpmsum module if the CPU supports
> it.
>
> Signed-off-by: Anton Blanchard
Applied to powerpc fixes, thanks.
h
On Tue, 2016-06-09 at 08:28:39 UTC, PrasannaKumar Muralidharan wrote:
> Checkpatch.pl warns about usage of asm/io.h. Use linux/io.h instead.
>
> Signed-off-by: PrasannaKumar Muralidharan
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/63019f3cab99c7acd27df5a5b8
cheers
--
To u
Herbert Xu writes:
> On Tue, Sep 06, 2016 at 01:58:39PM +0530, PrasannaKumar Muralidharan wrote:
>> Checkpatch.pl warns about usage of asm/io.h. Use linux/io.h instead.
>>
>> Signed-off-by: PrasannaKumar Muralidharan
>
> Patch applied. Thanks.
Oops I merged it too, my bad.
Hopefully git will
On Thu, 2015-07-02 at 15:40 -0700, Nishanth Aravamudan wrote:
> While we never would successfully load on the wrong machine type, there
> is extra output by default regardless of machine type.
>
> For instance, on a PowerVM LPAR, we see the following:
>
> nx_compress_powernv: loading
> nx_compres
On Mon, 2015-07-06 at 10:06 -0700, Nishanth Aravamudan wrote:
> On 03.07.2015 [11:30:32 +1000], Michael Ellerman wrote:
> > On Thu, 2015-07-02 at 15:40 -0700, Nishanth Aravamudan wrote:
> > > While we never would successfully load on the wrong machine type, there
> > >
d325c): undefined reference to `.enable_kernel_altivec'
aes.c:(.text+0x2d326c): undefined reference to `.enable_kernel_vsx'
Signed-off-by: Michael Ellerman
---
v2: Spell out VSX, and CC linux-crypto.
drivers/crypto/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
On Thu, 2015-09-10 at 17:26 +0800, Herbert Xu wrote:
> On Wed, Sep 09, 2015 at 06:22:35PM +1000, Michael Ellerman wrote:
> > This code uses FP (floating point), Altivec and VSX (Vector-Scalar
> > Extension). It can just depend on CONFIG_VSX though, because that
> > alre
enable_kernel_vsx() was added to turn on
VSX instructions for vmx-crypto.
Signed-off-by: Leonidas S. Barbosa
Signed-off-by: Herbert Xu
Fixes: 8676590a1593 ("crypto: vmx - Adding AES routines for VMX module")
Cc: sta...@vger.kernel.org # 4.2
Signed-off-by: Michael Ellerman
---
drivers/crypto
.
This patch uncomment enable_kernel_vsx() routine and makes it available.
Signed-off-by: Leonidas S. Barbosa
Signed-off-by: Herbert Xu
Cc: sta...@vger.kernel.org # 4.2
Signed-off-by: Michael Ellerman
---
arch/powerpc/include/asm/switch_to.h | 1 +
arch/powerpc/kernel/process.c| 3 ---
2
.
This patch uncomment enable_kernel_vsx() routine and makes it available.
Signed-off-by: Leonidas S. Barbosa
Signed-off-by: Herbert Xu
Cc: sta...@vger.kernel.org # 4.1
Signed-off-by: Michael Ellerman
---
arch/powerpc/include/asm/switch_to.h | 1 +
arch/powerpc/kernel/process.c| 3 ---
2
VSX instructions for vmx-crypto.
Signed-off-by: Leonidas S. Barbosa
Signed-off-by: Herbert Xu
Fixes: 8676590a1593 ("crypto: vmx - Adding AES routines for VMX module")
Cc: sta...@vger.kernel.org # 4.1
Signed-off-by: Michael Ellerman
---
drivers/crypto/vmx/aes.c | 3 +++
drivers/
Daniel Axtens writes:
> When CRC32c was included in the kernel, Anton ripped out
> the #ifdefs around reflected polynomials, because CRC32c
> is always reflected. However, not all CRCs use reflection
> so we'd like to make it optional.
>
> Restore the REFLECT parts from Anton's original CRC32
> i
Daniel Axtens writes:
> The core nuts and bolts of the crc32c vpmsum algorithm will
> also work for a number of other CRC algorithms with different
> polynomials. Factor out the function into a new asm file.
>
> To handle multiple users of the function, a user simply
> provides constants, defines
Hi Haren,
A few comments ...
Haren Myneni writes:
> diff --git a/arch/powerpc/include/asm/vas.h b/arch/powerpc/include/asm/vas.h
> index 4e5a470..7315621 100644
> --- a/arch/powerpc/include/asm/vas.h
> +++ b/arch/powerpc/include/asm/vas.h
> @@ -19,6 +19,8 @@
> #define VAS_RX_FIFO_SIZE_MIN (1 <
Haren Myneni writes:
> [PATCH 1/5] crypto/nx: Rename nx842_powernv_function as icswx function
>
> nx842_powernv_function is points to nx842_icswx_function and
> will be point to VAS function which will be added later for
> P9 NX support.
I know it's nit-picking but can you give it a better name
Haren Myneni writes:
> [PATCH 2/5] crypto/nx: Create nx842_cfg_crb function
>
> Configure CRB is moved to nx842_cfg_crb() so that it can be
> used for icswx function and VAS function which will be added
> later.
Buy a vowel! :)
nx842_configure_crb() is fine.
cheers
Haren Myneni writes:
> [PATCH 5/5] crypto/nx: Add P9 NX specific error codes for 842 engine
>
> This patch adds changes for checking P9 specific 842 engine
> error codes. These errros are reported in co-processor status
> block (CSB) for failures.
But you just enabled support on P9 in patch 4.
Haren Myneni writes:
> [PATCH 3/5] crypto/nx: Create nx842_delete_coproc function
>
> Move deleting coprocessor info upon exit or failure to
> nx842_delete_coproc().
Naming again, this deletes *all* the coprocs, so the name should be
plural.
cheers
Laurentiu Tudor writes:
> Hi Michael,
>
> Just a couple of basic things to check:
> - was the dtb updated to the newest?
Possibly not, it's an automated build/boot, I'll have to check what it
does with the dtb.
> - is the qman node present? This should be easily visible in
> /proc/device-t
Laurentiu Tudor writes:
> On 04/05/2017 01:06 PM, Michael Ellerman wrote:
>> Laurentiu Tudor writes:
>>
>>> Hi Michael,
>>>
>>> Just a couple of basic things to check:
>>>- was the dtb updated to the newest?
>>
>> Possibl
bug switch to make it active and all enables should be paired with
disables.
Fixes: b01df1c16c9a ("crypto: powerpc - Add CRC-T10DIF acceleration")
Acked-by: Daniel Axtens
Signed-off-by: Michael Ellerman
---
arch/powerpc/crypto/crct10dif-vpmsum_glue.c | 3 +++
1 file changed, 3 insertio
Thiago Jung Bauermann writes:
> On the OpenPOWER platform, secure boot and trusted boot are being
> implemented using IMA for taking measurements and verifying signatures.
I still want you to implement arch_kexec_kernel_verify_sig() as well :)
cheers
Thiago Jung Bauermann writes:
> Michael Ellerman writes:
>
>> Thiago Jung Bauermann writes:
>>
>>> On the OpenPOWER platform, secure boot and trusted boot are being
>>> implemented using IMA for taking measurements and verifying signatures.
Theodore Ts'o writes:
> On Tue, Jun 06, 2017 at 07:48:04PM +0200, Jason A. Donenfeld wrote:
>> This enables an important dmesg notification about when drivers have
>> used the crng without it being seeded first. Prior, these errors would
>> occur silently, and so there hasn't been a great way of d
Theodore Ts'o writes:
> On Mon, Jun 19, 2017 at 10:57:18PM +0200, Jason A. Donenfeld wrote:
>>
>> With rc6 already released and rc7 coming up, I'd really appreciate you
>> stepping in here and either ACKing the above commit, or giving your
>> two cents about it in case I need to roll something d
"Jason A. Donenfeld" writes:
> This enables an important dmesg notification about when drivers have
> used the crng without it being seeded first. Prior, these errors would
> occur silently, and so there hasn't been a great way of diagnosing these
> types of bugs for obscure setups. By adding thi
gned-off-by: Logan Gunthorpe
> Cc: Benjamin Herrenschmidt
> Cc: Paul Mackerras
> Cc: Michael Ellerman
> Cc: Nicholas Piggin
> Cc: Suresh Warrier
> Cc: "Oliver O'Halloran"
> ---
> arch/powerpc/include/asm/io.h | 4 ++--
> 1 file changed, 2 insertions(+),
Logan Gunthorpe writes:
> On 18/07/17 11:57 PM, Michael Ellerman wrote:
>> Seems fair enough, have you tested it at all?
>
> It's only been compile tested and the kbuild robot has beat up on it a bit.
OK. I don't think I see any way it can break anything, so feel fr
On Thu, 2012-07-19 at 09:42 -0500, Seth Jennings wrote:
> This patch adds the driver for interacting with the 842
> compression accelerator on IBM Power7+ systems.
...
> +struct nx842_slentry {
> + unsigned long ptr; /* Absolute address (use virt_to_abs()) */
> /+unsigned long len;
> +};
On Fri, 2012-07-20 at 09:01 -0500, Seth Jennings wrote:
> On 07/20/2012 12:33 AM, Michael Ellerman wrote:
> > On Thu, 2012-07-19 at 09:42 -0500, Seth Jennings wrote:
> >> This patch adds the driver for interacting with the 842
> >> compression acceler
.
Signed-off-by: Michael Ellerman
---
drivers/crypto/nx/nx-842.c | 34 ++
1 file changed, 18 insertions(+), 16 deletions(-)
diff --git a/drivers/crypto/nx/nx-842.c b/drivers/crypto/nx/nx-842.c
index 9da0fb2..0ce6257 100644
--- a/drivers/crypto/nx/nx-842.c
+++ b/drivers
Hi Herbert,
We're planning on removing virt_to_abs() from the powerpc tree this
cycle. So if you can take this patch in your tree everything should
continue building when the two trees merge.
cheers
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a messa
Hi Fin,
I don't know anything about crypto so I can only critique you on your
patch submission technique :) ...
On Wed, Aug 07, 2013 at 06:15:50PM -0500, Fionnuala Gunter wrote:
> This patch fixes a bug that is triggered when cts(cbc(aes)) is used with
> nx-crypto driver on input larger than 32
On Sat, 18 Jul 2020 12:39:58 +0200, Alexander A. Klimov wrote:
> Rationale:
> Reduces attack surface on kernel devs opening the links for MITM
> as HTTPS traffic is much harder to manipulate.
>
> Deterministic algorithm:
> For each file:
> If not .svg:
> For each line:
> If doesn't con
ions=1000
> cryptomgr.panic_on_fail=1"
Thanks for testing.
I gave it a quick spin on a Power9 and it showed no issues.
Acked-by: Michael Ellerman (powerpc)
cheers
Logan Gunthorpe writes:
> This is v14 of my cleanup series to push a number of instances of people
> defining their own io{read|write}64 functions into common headers seing
> they don't exist in non-64bit systems. This series adds inline functions to
> the
> io-64-nonatomic headers and then clea
Logan Gunthorpe writes:
> On 4/4/2018 4:38 AM, Michael Ellerman wrote:
...
>> eg. It looks like I could take the two powerpc patches on their own for
>> 4.17, and then the rest could go via other trees?
>
> Yup! If you can take the powerpc patches I can keep trying to get the
vger.kernel.org # v4.8+
Signed-off-by: Michael Ellerman
---
drivers/crypto/vmx/aes_xts.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/crypto/vmx/aes_xts.c b/drivers/crypto/vmx/aes_xts.c
index 8cd6e62e4c90..8bd9aff0f55f 100644
--- a/drivers/crypto/vmx/aes_xts.c
+++ b/drivers/crypt
es: cc333cd68dfa ("crypto: vmx - Adding GHASH routines for VMX module")
Cc: sta...@vger.kernel.org # v4.1+
Signed-off-by: Michael Ellerman
---
drivers/crypto/vmx/aes.c | 2 --
drivers/crypto/vmx/aes_cbc.c | 3 ---
drivers/crypto/vmx/aes_ctr.c | 2 --
drivers/crypto/vmx/ghash.c | 2 --
4 f
Herbert Xu writes:
> On Thu, May 03, 2018 at 10:29:29PM +1000, Michael Ellerman wrote:
>> In the vmx AES init routines we do a printk(KERN_INFO ...) to report
>> the fallback implementation we're using.
>>
>> However with a slow console this can significant
Herbert Xu writes:
> On Mon, May 06, 2019 at 08:53:17AM -0700, Eric Biggers wrote:
>>
>> Any progress on this? Someone just reported this again here:
>> https://bugzilla.kernel.org/show_bug.cgi?id=203515
>
> Guys if I don't get a fix for this soon I'll have to disable CTR
> in vmx.
No objection
ange in the interim to expose this?
> ---
>
> Tested on BE and LE in qemu-tcg, so more testing would be lovely.
I tested this on power8 with fuzz_iterations=1, no problems.
Previously it would fail very quickly.
Tested-by: Michael Ellerman
cheers
> diff --git a/drivers/crypto
s/crypto/vmx/aes_cbc.c | 14 +-
> drivers/crypto/vmx/aes_ctr.c | 14 +-
> drivers/crypto/vmx/aes_xts.c | 14 +-
> drivers/crypto/vmx/vmx.c | 14 +-
> 5 files changed, 5 insertions(+), 65 deletions(-)
Looks good to me.
Reviewed-by: Michael Ellerman
cheers
the stack and into the request context of the parent algorithm.
>
> I tested this in a PowerPC VM with CONFIG_CRYPTO_MANAGER_EXTRA_TESTS=y.
I booted it a few times on a Power9 bare metal machine with
panic_on_fail=1 and fuzz_iterations=400, no issues.
Tested-by: Michael Ellerman
cheers
Haren Myneni writes:
>
> System gets checkstop if RxFIFO overruns with more requests than the
> maximum possible number of CRBs in FIFO at the same time. So find max
> CRBs from FIFO size and set it to receive window credits.
>
> CC: sta...@vger.kernel.org # v4.14+
> Signed-off-by:Haren M
Herbert Xu writes:
> Haren Myneni wrote:
>>
>> System gets checkstop if RxFIFO overruns with more requests than the
>> maximum possible number of CRBs in FIFO at the same time. The max number
>> of requests per window is controlled by window credits. So find max
>> CRBs from FIFO size and set
Herbert Xu writes:
> On Fri, Jun 28, 2019 at 11:43:16AM +1000, Michael Ellerman wrote:
>>
>> No. I assumed you'd take it because it's in drivers/crypto.
>>
>> If you want me to take it that's fine, just let me know.
>
> No that's fine Michael. I'll pick it up.
Thanks.
cheers
Yang Li writes:
> In one of the error paths of the for_each_child_of_node() loop,
> add missing call to of_node_put().
>
> Fix the following coccicheck warning:
> ./drivers/crypto/nx/nx-common-powernv.c:927:1-23: WARNING: Function
> "for_each_child_of_node" should have of_node_put() before return
Uwe Kleine-König writes:
> The driver core ignores the return value of struct bus_type::remove()
> because there is only little that can be done. To simplify the quest to
> make this function return void, let struct vio_driver::remove() return
> void, too. All users already unconditionally return
.hiXi.hi
> + vpmsumd $Xh,$IN,$Hh # H.hi·Xi.hi
>add$inp,$inp,r0
>
> vpmsumd $t2,$Xl,$xC2# 1st phase
Acked-by: Michael Ellerman (powerpc)
cheers
On Wed, 2018-06-13 at 07:28:57 UTC, Haren Myneni wrote:
> Export opal_check_token symbol for modules to check the availability
> of OPAL calls before using them.
>
> Signed-off-by: Haren Myneni
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/6e708000ec2c93c2bde6a46aa2d6c3
che
On Wed, 2018-06-13 at 07:32:40 UTC, Haren Myneni wrote:
> NX increments readOffset by FIFO size in receive FIFO control register
> when CRB is read. But the index in RxFIFO has to match with the
> corresponding entry in FIFO maintained by VAS in kernel. Otherwise NX
> may be processing incorrect CR
Christophe Leroy writes:
> Le 11/04/2021 à 02:31, Haren Myneni a écrit :
>>
>> Using the same /dev/crypto/nx-gzip interface for both powerNV and
>> pseries. So this patcb moves VAS API to powerpc platform indepedent
>> directory. The actual functionality is not changed in this patch.
>
> This pat
: Benjamin Herrenschmidt
> Cc: Paul Mackerras
> Cc: Michael Ellerman
> Cc: Arnd Bergmann
> Cc: Suresh Warrier
> Cc: Nicholas Piggin
> ---
> arch/powerpc/include/asm/io.h | 2 +
> include/asm-generic/iomap.h | 22 ++
> lib/iomap.c |
Christophe Leroy writes:
> Le 04/01/2019 à 16:24, Horia Geanta a écrit :
>> On 1/4/2019 5:17 PM, Horia Geanta wrote:
>>> On 12/21/2018 10:07 AM, Christophe Leroy wrote:
>>> [snip]
IV cannot be on stack when CONFIG_VMAP_STACK is selected because the stack
cannot be DMA mapped anymore.
>>>
72 matches
Mail list logo
