答复: [PATCH] crypto: fix comparison of unsigned expression warnings

2019-10-07 Thread tiantao (H)
Hi, I found this warning using the command "make coccicheck COCCI=scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci MODE=patch" Best -邮件原件- 发件人: Gilad Ben-Yossef [mailto:gi...@benyossef.com] 发送时间: 2019年10月2日 18:00 收件人: tiantao (H) 抄送: Herbert Xu ; David Miller ; Li

Re: [PATCH] crypto: ccp - Fix to return the correct return value

2021-04-14 Thread tiantao (H)
在 2021/4/15 6:48, Tom Lendacky 写道: On 4/14/21 4:17 AM, Tian Tao wrote: ccp_dev_suspend and ccp_dev_resume return 0 on error, which causes ret to equal 0 in sp_suspend and sp_resume, making the if condition impossible to use. Why do you think that is an error and why do you think it should ret