Re: [PATCH] crypto: omap-sham: remove unnecessary static in omap_sham_remove()

[Herbert Xu]

Gustavo A. R. Silva  wrote:
> Remove unnecessary static on local variable dd. Such variable
> is initialized before being used, on every execution path throughout
> the function. The static has no benefit and, removing it reduces the
> object file size.
> 
> This issue was detected using Coccinelle and the following semantic patch:
> https://github.com/GustavoARSilva/coccinelle/blob/master/static/static_unused.cocci
> 
> In the following log you can see a difference in the object file size.
> This log is the output of the size command, before and after the code
> change:
> 
> before:
>   textdata bss dec hex filename
>  26135   11944 128   38207953f drivers/crypto/omap-sham.o
> 
> after:
>   textdata bss dec hex filename
>  26084   11856  64   380049474 drivers/crypto/omap-sham.o
> 
> Signed-off-by: Gustavo A. R. Silva 

Patch applied.  Thanks.
-- 
Email: Herbert Xu 
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

[PATCH] crypto: omap-sham: remove unnecessary static in omap_sham_remove()

[Gustavo A. R. Silva]

Remove unnecessary static on local variable dd. Such variable
is initialized before being used, on every execution path throughout
the function. The static has no benefit and, removing it reduces the
object file size.

This issue was detected using Coccinelle and the following semantic patch:
https://github.com/GustavoARSilva/coccinelle/blob/master/static/static_unused.cocci

In the following log you can see a difference in the object file size.
This log is the output of the size command, before and after the code
change:

before:
   textdata bss dec hex filename
  26135   11944 128   38207953f drivers/crypto/omap-sham.o

after:
   textdata bss dec hex filename
  26084   11856  64   380049474 drivers/crypto/omap-sham.o

Signed-off-by: Gustavo A. R. Silva 
---
 drivers/crypto/omap-sham.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/crypto/omap-sham.c b/drivers/crypto/omap-sham.c
index 9ad9d39..c40ac30 100644
--- a/drivers/crypto/omap-sham.c
+++ b/drivers/crypto/omap-sham.c
@@ -2133,7 +2133,7 @@ static int omap_sham_probe(struct platform_device *pdev)
 
 static int omap_sham_remove(struct platform_device *pdev)
 {
-   static struct omap_sham_dev *dd;
+   struct omap_sham_dev *dd;
int i, j;
 
dd = platform_get_drvdata(pdev);
-- 
2.5.0