Re: [PATCH] crypto: public_key: select CRYPTO_AKCIPHER2
On Wednesday 18 May 2016 22:50:31 Herbert Xu wrote: > On Wed, May 18, 2016 at 04:12:44PM +0200, Arnd Bergmann wrote: > > In some rare randconfig builds, we can end up with > > ASYMMETRIC_PUBLIC_KEY_SUBTYPE enabled but CRYPTO_AKCIPHER2 disabled, > > which fails to link because of the reference to crypto_alloc_akcipher: > > This symbol is not meant to be selected by crypto users. Please > select CRYPTO_AKCIPHER instead. > Ok, sent a v2 now. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] crypto: public_key: select CRYPTO_AKCIPHER2
On Wed, May 18, 2016 at 04:12:44PM +0200, Arnd Bergmann wrote: > In some rare randconfig builds, we can end up with > ASYMMETRIC_PUBLIC_KEY_SUBTYPE enabled but CRYPTO_AKCIPHER2 disabled, > which fails to link because of the reference to crypto_alloc_akcipher: This symbol is not meant to be selected by crypto users. Please select CRYPTO_AKCIPHER instead. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] crypto: public_key: select CRYPTO_AKCIPHER2
In some rare randconfig builds, we can end up with ASYMMETRIC_PUBLIC_KEY_SUBTYPE enabled but CRYPTO_AKCIPHER2 disabled, which fails to link because of the reference to crypto_alloc_akcipher: crypto/built-in.o: In function `public_key_verify_signature': :(.text+0x110e4): undefined reference to `crypto_alloc_akcipher' This adds a Kconfig 'select' statement to ensure the dependency is always there. Signed-off-by: Arnd Bergmann --- crypto/asymmetric_keys/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/crypto/asymmetric_keys/Kconfig b/crypto/asymmetric_keys/Kconfig index e28e912000a7..c93723a852d9 100644 --- a/crypto/asymmetric_keys/Kconfig +++ b/crypto/asymmetric_keys/Kconfig @@ -13,6 +13,7 @@ config ASYMMETRIC_PUBLIC_KEY_SUBTYPE tristate "Asymmetric public-key crypto algorithm subtype" select MPILIB select CRYPTO_HASH_INFO + select CRYPTO_AKCIPHER2 help This option provides support for asymmetric public key type handling. If signature generation and/or verification are to be used, -- 2.7.0 -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
