Re: [PATCH v9 crypto 06/12] cxgb4: LLD driver changes to enable TLS

2018-03-08 Thread Atul Gupta
On 3/7/2018 6:29 PM, Sabrina Dubroca wrote: > 2018-03-06, 21:09:25 +0530, Atul Gupta wrote: >> Read FW capability. Read key area size. Dump the TLS record count. > That's not a really helpful commit message. Have a look at other > commit messages and try to be more descriptive. > It's also not

Re: [PATCH v9 crypto 06/12] cxgb4: LLD driver changes to enable TLS

2018-03-07 Thread Sabrina Dubroca
2018-03-06, 21:09:25 +0530, Atul Gupta wrote: > Read FW capability. Read key area size. Dump the TLS record count. That's not a really helpful commit message. Have a look at other commit messages and try to be more descriptive. It's also not clear if those changes belong together in one patch,

[PATCH v9 crypto 06/12] cxgb4: LLD driver changes to enable TLS

2018-03-06 Thread Atul Gupta
Read FW capability. Read key area size. Dump the TLS record count. Signed-off-by: Atul Gupta --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 32 +--- drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.h | 7 ++ drivers/net/ethernet/chelsio/cxgb4/sge.c| 98