Re: [PATCH] Documentation: hw_random: Fix issue related to feeding entropy pool

2017-09-22 Thread PrasannaKumar Muralidharan
Hi Herbert,

On 22 September 2017 at 14:47, Herbert Xu  wrote:
> PrasannaKumar Muralidharan  wrote:
>> There is no need to use rng-tools for feeding random data into kernel
>> entropy pool as hw_random core handles it. Documentation suggested that
>> rng-tools is required which is incorrect. So remove it.
>>
>> Signed-off-by: PrasannaKumar Muralidharan 
>
> Hmm, the tool still exists and can still be used to feed /dev/random.
>
> Feeding /dev/random directly from the kernel is just one way of
> using hwrng.

But it is the default way.

> So rather than removing it perhaps you can modify it to state that
> the kernel can now feed /dev/random as an option.

As it is not required I think stating it is going to create confusion.
Users may not know whether rng-tools is optional or necessary for
feeding kernel entropy pool.

Thanks,
PrasannaKumar


Re: [PATCH] Documentation: hw_random: Fix issue related to feeding entropy pool

2017-09-22 Thread Herbert Xu
PrasannaKumar Muralidharan  wrote:
> There is no need to use rng-tools for feeding random data into kernel
> entropy pool as hw_random core handles it. Documentation suggested that
> rng-tools is required which is incorrect. So remove it.
> 
> Signed-off-by: PrasannaKumar Muralidharan 

Hmm, the tool still exists and can still be used to feed /dev/random.

Feeding /dev/random directly from the kernel is just one way of
using hwrng.

So rather than removing it perhaps you can modify it to state that
the kernel can now feed /dev/random as an option.

Cheers,
-- 
Email: Herbert Xu 
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt