Re: [PATCH] crypto: ccp - Fix to return the correct return value

2021-04-14 Thread tiantao (H)
在 2021/4/15 6:48, Tom Lendacky 写道: On 4/14/21 4:17 AM, Tian Tao wrote: ccp_dev_suspend and ccp_dev_resume return 0 on error, which causes ret to equal 0 in sp_suspend and sp_resume, making the if condition impossible to use. Why do you think that is an error and why do you think it should ret

Re: [PATCH] crypto: ccp - Fix to return the correct return value

2021-04-14 Thread Tom Lendacky
On 4/14/21 4:17 AM, Tian Tao wrote: > ccp_dev_suspend and ccp_dev_resume return 0 on error, which causes > ret to equal 0 in sp_suspend and sp_resume, making the if condition > impossible to use. Why do you think that is an error and why do you think it should return -ENXIO? Since ccp_dev_suspend(