Hi Theodore, I love your patch! Perhaps something to improve:
[auto build test WARNING on char-misc/char-misc-testing] [also build test WARNING on v4.16 next-20180413] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Theodore-Ts-o/random-fix-crng_ready-test/20180414-055120 config: i386-randconfig-x014-201814 (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 All warnings (new ones prefixed by >>): drivers/char/random.c: In function 'numa_crng_init': >> drivers/char/random.c:813:1: warning: no return statement in function >> returning non-void [-Wreturn-type] static int numa_crng_init(void) {} ^~~~~~ vim +813 drivers/char/random.c 789 790 #ifdef CONFIG_NUMA 791 static void numa_crng_init(void) 792 { 793 int i; 794 struct crng_state *crng; 795 struct crng_state **pool; 796 797 pool = kcalloc(nr_node_ids, sizeof(*pool), GFP_KERNEL|__GFP_NOFAIL); 798 for_each_online_node(i) { 799 crng = kmalloc_node(sizeof(struct crng_state), 800 GFP_KERNEL | __GFP_NOFAIL, i); 801 spin_lock_init(&crng->lock); 802 crng_initialize(crng); 803 pool[i] = crng; 804 } 805 mb(); 806 if (cmpxchg(&crng_node_pool, NULL, pool)) { 807 for_each_node(i) 808 kfree(pool[i]); 809 kfree(pool); 810 } 811 } 812 #else > 813 static int numa_crng_init(void) {} 814 #endif 815 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
