Re: [PATCH 4/6] fscrypt: verify that the correct master key was supplied

2017-07-14 Thread Eric Biggers
Hi Jeff, On Fri, Jul 14, 2017 at 01:34:48PM -0400, Jeffrey Walton wrote: > On Wed, Jul 12, 2017 at 5:00 PM, Eric Biggers wrote: > > From: Eric Biggers > > > > > > Solve the problem for v2 encryption policies by storing a "hash" of the > > master encryption key in the encryption xattr and ver

Re: [PATCH 4/6] fscrypt: verify that the correct master key was supplied

2017-07-14 Thread Jeffrey Walton
On Wed, Jul 12, 2017 at 5:00 PM, Eric Biggers wrote: > From: Eric Biggers > > > Solve the problem for v2 encryption policies by storing a "hash" of the > master encryption key in the encryption xattr and verifying it before > accepting the user-provided key. > ... Forgive my ignorance... Doe

Re: [PATCH 4/6] fscrypt: verify that the correct master key was supplied

2017-07-14 Thread Michael Halcrow
On Wed, Jul 12, 2017 at 02:00:33PM -0700, Eric Biggers wrote: > From: Eric Biggers > > Currently, while a fscrypt master key is required to have a certain > description in the keyring, its payload is never verified to be correct. > While sufficient for well-behaved userspace, this is insecure in