Re: [PATCH V2] staging: ccree: Fix format/argument mismatches

2017-08-06 Thread Gilad Ben-Yossef 
On Thu, Aug 3, 2017 at 4:49 PM, Joe Perches  wrote:
> On Thu, 2017-08-03 at 17:09 +0800, kbuild test robot wrote:
>> Hi Joe,
>>
>> [auto build test WARNING on staging/staging-testing]
>> [also build test WARNING on next-20170803]
>> [cannot apply to v4.13-rc3]
>> [if your patch is applied to the wrong git tree, please drop us a note to 
>> help improve the system]
>
> Pretty odd that m32r has ioread32 as _readl and so unsigned long
> Seems silly to have to cast it.

Yes, that does seem silly.

>
> Gilad, is this actually a supported platform for ccree?

Yes, since CryptoCell can be baked into any silicon that can be made
to talk AMBA, even though
I don't know of a specific platform that carries both M32R cores and CryptoCell.

That doesn't seem like a unique problem to ccree though, do other
drivers do this cast?
In that case, maybe we need to add a printk format like for dma addresses.

I wanted to add the M32R kernel mailing list but it seems the arch has
been orphaned and the web site
is a  a maze of twisty little 404s, all alike. Is that thing still alive?


Gilad

-- 
Gilad Ben-Yossef
Chief Coffee Drinker

"If you take a class in large-scale robotics, can you end up in a
situation where the homework eats your dog?"
 -- Jean-Baptiste Queru

Re: [PATCH V2] staging: ccree: Fix format/argument mismatches

2017-08-03 Thread Joe Perches 
On Thu, 2017-08-03 at 17:09 +0800, kbuild test robot wrote:
> Hi Joe,
> 
> [auto build test WARNING on staging/staging-testing]
> [also build test WARNING on next-20170803]
> [cannot apply to v4.13-rc3]
> [if your patch is applied to the wrong git tree, please drop us a note to 
> help improve the system]

Pretty odd that m32r has ioread32 as _readl and so unsigned long
Seems silly to have to cast it.

Gilad, is this actually a supported platform for ccree?

> url:
> https://github.com/0day-ci/linux/commits/Joe-Perches/staging-ccree-Fix-format-argument-mismatches/20170731-191055
> config: m32r-allmodconfig (attached as .config)
> compiler: m32r-linux-gcc (GCC) 6.2.0
> reproduce:
> wget 
> https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O 
> ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # save the attached .config to linux build tree
> make.cross ARCH=m32r 
> 
> All warnings (new ones prefixed by >>):
> 
>In file included from include/linux/kernel.h:13:0,
> from drivers/staging/ccree/ssi_driver.c:17:
>drivers/staging/ccree/ssi_driver.c: In function 'init_cc_regs':
> > > drivers/staging/ccree/ssi_driver.c:180:16: warning: format '%X' expects 
> > > argument of type 'unsigned int', but argument 2 has type 'long unsigned 
> > > int' [-Wformat=]
> 
>  SSI_LOG_DEBUG("AXIM_CFG=0x%08X\n", 
> CC_HAL_READ_REGISTER(CC_REG_OFFSET(CRY_KERNEL, AXIM_CFG)));

Re: [PATCH V2] staging: ccree: Fix format/argument mismatches

2017-08-03 Thread kbuild test robot 
Hi Joe,

[auto build test WARNING on staging/staging-testing]
[also build test WARNING on next-20170803]
[cannot apply to v4.13-rc3]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:
https://github.com/0day-ci/linux/commits/Joe-Perches/staging-ccree-Fix-format-argument-mismatches/20170731-191055
config: m32r-allmodconfig (attached as .config)
compiler: m32r-linux-gcc (GCC) 6.2.0
reproduce:
wget 
https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=m32r 

All warnings (new ones prefixed by >>):

   In file included from include/linux/kernel.h:13:0,
from drivers/staging/ccree/ssi_driver.c:17:
   drivers/staging/ccree/ssi_driver.c: In function 'init_cc_regs':
>> drivers/staging/ccree/ssi_driver.c:180:16: warning: format '%X' expects 
>> argument of type 'unsigned int', but argument 2 has type 'long unsigned int' 
>> [-Wformat=]
 SSI_LOG_DEBUG("AXIM_CFG=0x%08X\n", 
CC_HAL_READ_REGISTER(CC_REG_OFFSET(CRY_KERNEL, AXIM_CFG)));
   ^
   include/linux/printk.h:136:11: note: in definition of macro 'no_printk'
   printk(fmt, ##__VA_ARGS__); \
  ^~~
>> drivers/staging/ccree/ssi_driver.c:180:2: note: in expansion of macro 
>> 'SSI_LOG_DEBUG'
 SSI_LOG_DEBUG("AXIM_CFG=0x%08X\n", 
CC_HAL_READ_REGISTER(CC_REG_OFFSET(CRY_KERNEL, AXIM_CFG)));
 ^
   In file included from drivers/staging/ccree/ssi_driver.c:64:0:
   drivers/staging/ccree/ssi_driver.c: In function 'init_cc_resources':
   include/linux/kern_levels.h:4:18: warning: format '%X' expects argument of 
type 'unsigned int', but argument 4 has type 'long unsigned int' [-Wformat=]
#define KERN_SOH "\001"  /* ASCII Start Of Header */
 ^
   drivers/staging/ccree/ssi_driver.h:95:9: note: in definition of macro 
'SSI_LOG'
 printk(level "cc715ree::%s: " format, __func__, ##__VA_ARGS__)
^
   include/linux/kern_levels.h:13:19: note: in expansion of macro 'KERN_SOH'
#define KERN_INFO KERN_SOH "6" /* informational */
  ^~~~
   drivers/staging/ccree/ssi_driver.c:319:10: note: in expansion of macro 
'KERN_INFO'
 SSI_LOG(KERN_INFO, "ARM CryptoCell %s Driver: HW version 0x%08X, Driver 
version %s\n", SSI_DEV_NAME_STR,
 ^

vim +180 drivers/staging/ccree/ssi_driver.c

abefd674 Gilad Ben-Yossef 2017-04-23  @17  #include 
abefd674 Gilad Ben-Yossef 2017-04-23   18  #include 
abefd674 Gilad Ben-Yossef 2017-04-23   19  
abefd674 Gilad Ben-Yossef 2017-04-23   20  #include 
abefd674 Gilad Ben-Yossef 2017-04-23   21  #include 
abefd674 Gilad Ben-Yossef 2017-04-23   22  #include 
abefd674 Gilad Ben-Yossef 2017-04-23   23  #include 
fe0a1951 Gilad Ben-Yossef 2017-04-23   24  #include 
abefd674 Gilad Ben-Yossef 2017-04-23   25  #include 
abefd674 Gilad Ben-Yossef 2017-04-23   26  #include 
302ef8eb Gilad Ben-Yossef 2017-04-23   27  #include 
abefd674 Gilad Ben-Yossef 2017-04-23   28  
abefd674 Gilad Ben-Yossef 2017-04-23   29  #include 
abefd674 Gilad Ben-Yossef 2017-04-23   30  #include 
abefd674 Gilad Ben-Yossef 2017-04-23   31  #include 
abefd674 Gilad Ben-Yossef 2017-04-23   32  #include 
abefd674 Gilad Ben-Yossef 2017-04-23   33  #include 
abefd674 Gilad Ben-Yossef 2017-04-23   34  #include 
abefd674 Gilad Ben-Yossef 2017-04-23   35  #include 
abefd674 Gilad Ben-Yossef 2017-04-23   36  #include 
abefd674 Gilad Ben-Yossef 2017-04-23   37  #include 
abefd674 Gilad Ben-Yossef 2017-04-23   38  #include 
abefd674 Gilad Ben-Yossef 2017-04-23   39  #include 
abefd674 Gilad Ben-Yossef 2017-04-23   40  #include 
abefd674 Gilad Ben-Yossef 2017-04-23   41  #include 
abefd674 Gilad Ben-Yossef 2017-04-23   42  #include 
abefd674 Gilad Ben-Yossef 2017-04-23   43  #include 
abefd674 Gilad Ben-Yossef 2017-04-23   44  #include 
abefd674 Gilad Ben-Yossef 2017-04-23   45  #include 
abefd674 Gilad Ben-Yossef 2017-04-23   46  #include 
abefd674 Gilad Ben-Yossef 2017-04-23   47  #include 
abefd674 Gilad Ben-Yossef 2017-04-23   48  #include 
abefd674 Gilad Ben-Yossef 2017-04-23   49  #include 
abefd674 Gilad Ben-Yossef 2017-04-23   50  #include 
abefd674 Gilad Ben-Yossef 2017-04-23   51  
abefd674 Gilad Ben-Yossef 2017-04-23   52  /* cache.h required for 
L1_CACHE_ALIGN() and cache_line_size() */
abefd674 Gilad Ben-Yossef 2017-04-23   53  #include 
abefd674 Gilad Ben-Yossef 2017-04-23   54  #include 
abefd674 Gilad Ben-Yossef 2017-04-23   55  #include 
abefd674 Gilad Ben-Yossef 2017-04-23   56  #include 
abefd674 Gilad Ben-Yossef 2017-04-23   57  #include 
abefd674 Gilad Ben-Yossef 2017-04-23   58  #include 
abefd674 Gilad Ben-Yossef 2017-04-23   59  #include 
675ef02f Gilad Ben-Yossef 2017-06-25   60  #include 
d255b343 Gilad Ben-Yossef 2017-06-25   61  #include 
abefd674 Gilad Ben-Yossef 2017-04-23   62  
abefd674 Gilad