Re: [PATCH v6 1/7] drm/tilcdc: ensure nonatomic iowrite64 is not used

2017-08-05 Thread Jyri Sarha
On 08/04/17 16:03, Tomi Valkeinen wrote: > On 03/08/17 21:30, Logan Gunthorpe wrote: >> Add a check to ensure iowrite64 is only used if it is atomic. >> >> It was decided in [1] that the tilcdc driver should not be using an >> atomic operation (so it was left out of this patchset). However, it

Re: [PATCH v6 1/7] drm/tilcdc: ensure nonatomic iowrite64 is not used

2017-08-04 Thread Logan Gunthorpe
On 04/08/17 07:03 AM, Tomi Valkeinen wrote: > I haven't really followed the discussion on this, but if the tilcdc's > use of iowrite64 causes (real) problems/complications elsewhere, I think > we could drop it. Well, that's up to you. The patch I submitted should still be correct though, and if

Re: [PATCH v6 1/7] drm/tilcdc: ensure nonatomic iowrite64 is not used

2017-08-04 Thread Tomi Valkeinen
On 03/08/17 21:30, Logan Gunthorpe wrote: > Add a check to ensure iowrite64 is only used if it is atomic. > > It was decided in [1] that the tilcdc driver should not be using an > atomic operation (so it was left out of this patchset). However, it turns > out that through the drm code, a