Re: [PATCH] documentation: ntb.txt correct grammar "however"

On Sat, Jun 04, 2016 at 03:34:01PM -0400, Justin Keller wrote: > Correct the grammar around the word however. > > Signed-off-by: Justin Keller > > --- > > index 1d9bbab..5d43510 100644 > --- a/Documentation/ntb.txt > +++ b/Documentation/ntb.txt > @@ -35,7 +35,7 @@

Re: [PATCH 1/2] usb: configfs: allow UDC binding rule configured as binding to *any* UDC

On Tue 2016-05-03 11:04:24, changbin...@intel.com wrote: > From: "Du, Changbin" > > On most platforms, there is only one device controller available. > In this case, we desn't care the UDC's name. So let's ignore the > name by setting 'UDC' to 'any'. And also we can change

[PATCH v3 22/30] staging: unisys: visorbus: Move visorbus-unique functions to private header

From: David Binder Moves function prototypes that are unique to visorbus from include/visorbus.h to visorbus/visorbus_private.h. Signed-off-by: David Binder Signed-off-by: David Kershner Reviewed-by: Tim Sell

[PATCH v3 19/30] staging: unisys: visorbus: fix commenting in visorbus_main.c

From: David Binder This patch ONLY touches comment lines, i.e., NO executable code is affected. * All functions worthy of documenting now use standard kerneldoc formatting. * Improper uses of kerneldoc formatting were converted to standard multi-line comments. *

[PATCH v3 27/30] staging: unisys: Move vbushelper.h to visorbus directory

Only visorbus needs this header file so move it to visorbus directory. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/{include => visorbus}/vbushelper.h | 0 1 file changed, 0 insertions(+), 0 deletions(-)

[PATCH v3 24/30] staging: unisys: visorbus: Remove notifier-related code from visorbus

From: David Binder When this functionality was first implemented, visorchipset and visorbus were separate drivers, which necessitated a registration mechanism for them to communicate. More-recently, visorchipset and visorbus were combined into a single driver, and now

[PATCH v3 28/30] include: linux: visorbus: Add visorbus to include/linux directory

Update include/linux to include the s-Par associated common include header files needed for the s-Par visorbus. Since we have now moved the include directories over to include/linux/visorbus this patch makes all of the visor drivers visorbus, visorinput, visornic, and visorhba use the new include

[PATCH v3 14/30] staging: unisys: visorbus: Remove unnecessary EXPORT_SYMBOL statements

From: Bryan Thompson The driver that is now visorbus started out as multiple separate drivers, and when they were merged the EXPORT_SYMBOL statements that were required for separate drivers were left in the code. This patch removes those now unnecessary exports.

[PATCH v3 10/30] staging: unisys: visorinput: remove unnecessary locking

From: Tim Sell Locking in the _interrupt() function is NOT necessary so long as we ensure that interrupts have been stopped whenever we need to pause or resume the device, which we now do. While a device is paused, we ensure that interrupts stay disabled, i.e. that the

[PATCH v3 29/30] Documentation: Move visorbus documentation from staging to Documentation/

This patch simple does a git mv of the drivers/staging/unisys/Documentation directory to Documentation. Renames overview.txt to visorbus.txt and renames sysfs-platform-visorchipset to the correct name sysfs-bus-visorbus. Signed-off-by: David Kershner Reviewed-by: Tim

[PATCH v3 23/30] staging: unisys: visorbus: rectify kerneldoc comment for struct

From: David Binder Fixes the kerneldoc comment for struct visor_device - the struct members were not listed with the appropriate @ prefix. Signed-off-by: David Binder Signed-off-by: David Kershner ---

[PATCH v3 16/30] staging: unisys: Remove reference to unused STANDALONE_CLIENT

From: Bryan Thompson The STANDALONE_CLIENT define is no longer used by Unisys driver code. Signed-off-by: Bryan Thompson Signed-off-by: David Kershner Reviewed-by: Tim Sell ---

[PATCH v3 06/30] staging: unisys: visorbus: modify format string to match argument

From: David Binder Modifies the format string of snprintf to expect an unsigned int instead of a signed one, per the supplied argument. Signed-off-by: David Binder Signed-off-by: David Kershner Reviewed-by: Tim Sell

[PATCH v3 30/30] drivers: Add visorbus to the drivers directory

visorbus is currently located at drivers/staging/visorbus, this patch moves it to drivers/virt. Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/Kconfig| 3 +--

[PATCH v3 12/30] staging: unisys: visorbus: remove periodic_work.h/.c

From: Tim Sell These files were made no-longer-necessary by recent commits. Signed-off-by: Tim Sell Signed-off-by: David Kershner --- drivers/staging/unisys/include/periodic_work.h | 40 -

[PATCH v3 13/30] staging: unisys: visorbus: Make visordriver_callback_lock a mutex

From: Bryan Thompson visordriver_callback_lock is just a binary semaphore that logically makes more sense as a mutex. Signed-off-by: Bryan Thompson Signed-off-by: David Kershner Reviewed-by: Tim Sell

[PATCH v3 05/30] staging: unisys: visorbus: remove unused struct

From: David Binder Removes unused struct definition, channel_size_info, in response to findings by SonarQube. Signed-off-by: David Binder Signed-off-by: David Kershner Reviewed-by: Tim Sell

[PATCH v3 03/30] staging: unisys: iovmcall_gnuc.h change -1 return values

From: Erik Arfvidson This patch changes the vague -1 return values to -EPERM. This operation is not supported is a good alternative to -1 because the return is basically telling the caller that the processor doesn't support vmcall operations. Signed-off-by: Erik

[PATCH v3 15/30] staging: unisys: visorbus: Remove unused functions

From: Bryan Thompson Remove visorbus_clear_channel, visorchannel_signalqueue_slots_avail, visorchannel_signalqueue_max_slots, visorchannel_clear, and visorchannel_debug which are no longer called by any driver. Signed-off-by: Bryan Thompson

[PATCH v3 17/30] staging: unisys: visorbus: remove unused parameter from function

From: Tim Sell The off parameter to visorchannel_create_guts() was never used, so it was removed. Signed-off-by: Tim Sell Signed-off-by: David Kershner --- drivers/staging/unisys/visorbus/visorchannel.c | 7 +++

[PATCH v3 18/30] staging: unisys: visorbus: fix commenting in vbusdevinfo.h

From: David Binder This patch ONLY touches comment lines, i.e., NO executable code is affected. * All functions worthy of documenting now use standard kerneldoc formatting. * Multi-line comments were tweaked so as to use appropriate conventions. * Minor typos were

[PATCH v3 07/30] staging: unisys: visornic: Correct comment spelling mistake

From: David Binder Fixes a comment spelling mistake in visornic. Signed-off-by: David Binder Signed-off-by: David Kershner Reviewed-by: Tim Sell ---

[PATCH v3 26/30] staging: unisys: visorbus: fix visorbus_private.h comments

From: Tim Sell This patch ONLY touches comment lines, i.e., NO executable code is affected. Comments were fixed in visorbus_private.h: * Minor typos were corrected. * Useless comments were removed. Signed-off-by: Tim Sell Signed-off-by: David

[PATCH v3 08/30] staging: unisys: include: Remove thread-related enum members

From: David Binder Code relating to ktheads was previously removed from s-Par driver code. This patch cleans up lingering remnants of kthreads by removing thread- related enum types. Signed-off-by: David Binder Signed-off-by: David Kershner

[PATCH v3 20/30] staging: unisys: visorbus: fix visorchannel.c comments

From: David Binder This patch ONLY touches comment lines, i.e., NO executable code is affected. Comments were fixed in visorchannel.c: * All functions worthy of documenting now use standard kerneldoc formatting. * Multi-line comments were tweaked so as to use

[PATCH v3 11/30] staging: unisys: visorbus: use kernel timer instead of workqueue

From: Tim Sell A kernel timer is now used as the vehicle to periodically call the channel_interrupt function of registered visor drivers, instead of a workqueue. This simplifies a lot of things by making periodic_work.c and periodic_work.h no longer necessary. This

[PATCH v3 21/30] staging: unisys: visorbus: Rectify commenting in visorchipset.c

From: David Binder Adds kerneldoc formatting to appropriate functions. Other multi-line comments now use proper formatting. Signed-off-by: David Binder Signed-off-by: David Kershner Reviewed-by: Tim Sell

[PATCH v3 00/30] Fixed issues raised by tglx, then move visorbus to drivers/virt

tglx: The following patchset fixes issues you raised during your code review of visorbus on 5/18. Converts visorbus to use a kernel timer for periodic device-specific callbacks instead of a workqueue, making the implementation in periodic_work.c and periodic_work.h no longer necessary. These

Re: [PATCH 00/10] Documentation/Sphinx

On Fri, 03 Jun 2016, Jonathan Corbet wrote: > On Fri, 3 Jun 2016 22:24:03 +0200 > Daniel Vetter wrote: > >> > This is maybe a job for a separate tool. A related issue is the (fairly >> > frequent) "oh look, none of the comments in $FILE are being used" >>

Re: [PATCH v2 00/38] Documentation/sphinx

On Sat, Jun 04, 2016 at 02:37:01PM +0300, Jani Nikula wrote: > Jon, this is v2 of [1] and [2], with a considerable amount of polish and > fixes added. We started dogfooding this within drm-intel, and Daniel has > reviewed the lot and contributed a number of fixes, most notably > accurate file and

[PATCH v2 02/38] kernel-doc: support printing exported and non-exported symbols

Currently we use docproc to figure out which symbols are exported, and then docproc calls kernel-doc on specific functions, to get documentation on exported functions. According to git blame and docproc comments, this is due to historical reasons, as functions and their corresponding

[PATCH v2 06/38] Documentation/sphinx: configure the kernel-doc extension

Tell Sphinx where to find the extension, and pass on the kernel src tree and kernel-doc paths to the extension. With this, any .rst files under Documentation may contain the kernel-doc rst directive to include kernel-doc documentation from any source file. While building, it may be handy to pass

[PATCH v2 08/38] sphinx: cheesy script to convert .tmpl files

From: Jonathan Corbet This script uses pandoc to convert existing DocBook template files to RST templates. A couple of sed scripts are need to massage things both before and after the conversion, but the result is then usable with no hand editing. [Jani: Change usage to tmplcvt

[PATCH v2 10/38] Documentation/sphinx: nicer referencing of struct in docbook->rst conversion

Add "struct" in the label of the reference. Signed-off-by: Jani Nikula --- Documentation/sphinx/convert_template.sed | 10 +++--- Documentation/sphinx/post_convert.sed | 10 +++--- 2 files changed, 14 insertions(+), 6 deletions(-) diff --git

[PATCH v2 15/38] kernel-doc/rst: references are more universal than structs

It's possible to use to reference structs, enums, typedefs, etc. in the Sphinx C domain. Thus do not prefix the links with "struct". Signed-off-by: Jani Nikula --- scripts/kernel-doc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/scripts/kernel-doc

[PATCH v2 14/38] kernel-doc/rst: reference functions according to C domain spec

The Sphinx C domain spec says function references should include the parens (). Signed-off-by: Jani Nikula --- scripts/kernel-doc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/kernel-doc b/scripts/kernel-doc index 659d529b99d8..e8651d7cf1cd

[PATCH v2 09/38] sphinx: update docbook->rst conversion script match C domain spec

Function references should include the parens (), struct references should not include "struct". Signed-off-by: Jani Nikula --- Documentation/sphinx/convert_template.sed | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH v2 16/38] kernel-doc/rst: add support for foo and foo references

Let the user use " foo" and " foo" to reference foo. The difference to using "union ", "typedef ", or just "" (which are valid too) is that "union" and "typedef" become part of the link text. Signed-off-by: Jani Nikula --- scripts/kernel-doc | 4 1 file changed, 4

[PATCH v2 12/38] kernel-doc: add names for output selection

Make the output selection a bit more readable by adding constants for the various types of output selection. While at it, actually call the variable for choosing what to output $output_selection. No functional changes. Signed-off-by: Jani Nikula --- scripts/kernel-doc |

[PATCH v2 19/38] kernel-doc/rst: highlight function/struct/enum purpose lines too

Let the user use @foo, , %baz, etc. in the first kernel-doc purpose line too. Signed-off-by: Jani Nikula --- scripts/kernel-doc | 37 + 1 file changed, 25 insertions(+), 12 deletions(-) diff --git a/scripts/kernel-doc

Re: [PATCH 00/10] Documentation/Sphinx

On Sat, 04 Jun 2016, Jonathan Corbet wrote: > On Mon, 30 May 2016 23:05:34 +0300 > Jani Nikula wrote: > >> To be clear, the "sphinx-for-docs-next" branch of [1], [2] is what I >> propose to merge at this time. There's the Sphinx configuration, kernel >>

[PATCH v2 31/38] kernel-doc: reset contents and section harder

If the documentation comment does not have params or sections, the section heading may leak from the previous documentation comment. Signed-off-by: Jani Nikula --- scripts/kernel-doc | 3 +++ 1 file changed, 3 insertions(+) diff --git a/scripts/kernel-doc

[PATCH v2 29/38] kernel-doc: limit the "section header:" detection to a select few

kernel-doc currently identifies anything matching "section header:" (specifically a string of word characters and spaces followed by a colon) as a new section in the documentation comment, and renders the section header accordingly. Unfortunately, this turns all uses of colon into sections,

[PATCH v2 25/38] kernel-doc: improve handling of whitespace on the first line param description

Handle whitespace on the first line of param text as if it was the empty string. There is no need to add the newline in this case. This improves the rst output in particular, where blank lines may be problematic in parameter lists. Signed-off-by: Jani Nikula ---

[PATCH v2 24/38] kernel-doc/rst: change the output layout

Move away from field lists, and simply use **strong emphasis** for section headings on lines of their own. Do not use rst section headings, because their nesting depth depends on the surrounding context, which kernel-doc has no knowledge of. Also, they do not need to end up in any table of

[PATCH v2 21/38] kernel-doc: fix wrong code indentation

No functional changes. Signed-off-by: Jani Nikula --- scripts/kernel-doc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/kernel-doc b/scripts/kernel-doc index f795660dfc7b..c154c3205df1 100755 --- a/scripts/kernel-doc +++ b/scripts/kernel-doc

[PATCH v2 22/38] kernel-doc/rst: blank lines in output are not needed

Current approach leads to two blank lines, while one is enough. Signed-off-by: Jani Nikula --- scripts/kernel-doc | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/scripts/kernel-doc b/scripts/kernel-doc index c154c3205df1..a89ff3ca366c 100755 ---

[PATCH v2 26/38] kernel-doc: strip leading whitespace from continued param descs

If a param description spans multiple lines, check any leading whitespace in the first continuation line, and remove same amount of whitespace from following lines. This allows indentation in the multi-line parameter descriptions for aesthetical reasons while not causing accidentally significant

[PATCH v2 30/38] kernel-doc: concatenate contents of colliding sections

If there are multiple sections with the same section name, the current implementation results in several sections by the same heading, with the content duplicated from the last section to all. Even if there's the error message, a more graceful approach is to combine all the identically named

[PATCH v2 20/38] kernel-doc: do not regard $, %, or & prefixes as special in section names

The use of these is confusing in the script, and per this grep, they're not used anywhere anyway: $ git grep " \* [%$&][a-zA-Z0-9_]*:" -- *.[ch] | grep -v "\$\(Id\|Revision\|Date\)" While at it, throw out the constants array, nothing is ever put there again. Signed-off-by: Jani Nikula

[PATCH v2 23/38] kernel-doc: strip leading blank lines from inline doc comments

The inline member markup allows whitespace lines before the actual documentation starts. Strip the leading blank lines. This improves the rst output. Signed-off-by: Jani Nikula --- scripts/kernel-doc | 4 1 file changed, 4 insertions(+) diff --git

[PATCH v2 28/38] kernel-doc/rst: remove fixme comment

Yes, for our purposes the type should contain typedef. Signed-off-by: Jani Nikula --- scripts/kernel-doc | 1 - 1 file changed, 1 deletion(-) diff --git a/scripts/kernel-doc b/scripts/kernel-doc index 19cee0cd53a3..425a94be04f6 100755 --- a/scripts/kernel-doc +++

[PATCH v2 37/38] scripts/kernel-doc: Add option to inject line numbers

From: Daniel Vetter Opt-in since this wreaks the rst output and must be removed by consumers again. This is useful to adjust the linenumbers for included kernel-doc snippets in shinx. With that sphinx error message will be accurate when there's issues with the rst-ness of

[PATCH v2 34/38] scripts/kernel-doc: Remove duplicated DOC: start handling

From: Daniel Vetter Further up in the state machinery we switch from STATE_NAME to STATE_DOCBLOCK when we match /$doc_block/. Which means this block of code here is entirely unreachable, unless there are multiple DOC: sections within a single kernel-doc comment. Getting

[PATCH v2 00/38] Documentation/sphinx

Jon, this is v2 of [1] and [2], with a considerable amount of polish and fixes added. We started dogfooding this within drm-intel, and Daniel has reviewed the lot and contributed a number of fixes, most notably accurate file and line number references from Sphinx build errors/warnings to the

Re: [PATCH 21/23] arm64: ilp32: introduce ilp32-specific handlers for sigframe and ucontext

Hi, I found an issue of unwind with the following code. The correct backtrace should be: (gdb) where #0 0x004004d0 in my_sig (sig=11) at test_force3.c:16 #1 #2 func2 (num=0) at test_force3.c:22 #3 0x00400540 in func1 (num=1) at test_force3.c:28 #4 0x00400574 in main (argc=1, argv=0xffd7bc04) at

Re: [PATCH 05/10] Documentation/sphinx: add Sphinx kernel-doc directive extension

Am 03.06.2016 um 22:35 schrieb Jonathan Corbet : > On Fri, 20 May 2016 16:39:36 +0300 > Jani Nikula wrote: > >> Add an extension to handle kernel-doc directives, to call kernel-doc >> according to the arguments and parameters given to the reStructuredText