RE: [PATCH v5 6/8] thunderbolt: Networking transmit and receive

On Sun, Jul 31 2016, 09:45 PM, David Miller wrote: > From: "Levy, Amir (Jer)" > Date: Sun, 31 Jul 2016 10:15:52 + > > > The network stack thinks it is Ethernet, it might not accept Runt > > frames, so the driver pads the frame in receive. > > The network stack

Re: [PATCH v5 6/8] thunderbolt: Networking transmit and receive

From: "Levy, Amir (Jer)" Date: Sun, 31 Jul 2016 10:15:52 + > The network stack thinks it is Ethernet, it might not accept Runt > frames, so the driver pads the frame in receive. The network stack doesn't care about this at all. It's wasted effort on your part. --

RE: [PATCH v5 4/8] thunderbolt: Communication with the ICM (firmware)

On Sat, Jul 30 2016, 12:03 AM, Stephen Hemminger wrote: > On Thu, 28 Jul 2016 11:15:17 +0300 > Amir Levy wrote: > > > +int nhi_send_message(struct tbt_nhi_ctxt *nhi_ctxt, enum pdf_value > pdf, > > +u32 msg_len, const u8 *msg, bool ignore_icm_resp) { > >

RE: [PATCH v5 5/8] thunderbolt: Networking state machine

On Thu, Jul 28 2016, 02:35 PM, Lukas Wunner wrote: > On Thu, Jul 28, 2016 at 11:15:18AM +0300, Amir Levy wrote: > > + nhi_ctxt->net_devices[ > > + port_num].medium_sts = > > Looks like a carriage return slipped in here. Will be fixed.

RE: [PATCH v5 4/8] thunderbolt: Communication with the ICM (firmware)

On Sat, Jul 30 2016, 12:48 AM, Greg KH wrote: > On Fri, Jul 29, 2016 at 02:02:24PM -0700, Stephen Hemminger wrote: > > On Thu, 28 Jul 2016 11:15:17 +0300 > > Amir Levy wrote: > > > > > +static LIST_HEAD(controllers_list); static > > >

RE: [PATCH v5 6/8] thunderbolt: Networking transmit and receive

On Sat, Jul 30 2016, 12:07 AM, Stephen Hemminger wrote: > On Thu, 28 Jul 2016 11:15:19 +0300 > Amir Levy wrote: > > > + /* pad short packets */ > > + if (unlikely(skb->len < ETH_ZLEN)) { > > + int pad_len = ETH_ZLEN - skb->len; > > +