[PATCH 4/6] drm/doc: Consistent kerneldoc include order

2016-12-18 Thread Daniel Vetter
First overview text (if there is any), then headers (since generally you want to start out with the data structures), then all the other stuff with functions. Most of this is pre-shpinx, since with the old docbook only the overview stuff was pulled in directly. Everything else was put in a per-sec

[PATCH 6/6] drm/doc: atomic overview, with graph

2016-12-18 Thread Daniel Vetter
I want to split up a few more things and document some details better (like how exactly to subclass drm_atomic_state). And maybe also split up the helpers a bit per-topic, but this should be a ok-ish start for better atomic overview. One thing I failed at is getting DOT to layout the overview grap

[PATCH 0/6] diagrams for drm docs

2016-12-18 Thread Daniel Vetter
Hi all, So this is my first stab at doing some overview diagrams for drm. Pretty much like what it looks like, both input and output. Well there's one layout issue where I couldn't convince DOT to do what I want it to do. All based on Markus' kernel-figures script. I think the script needs a bit

[PATCH 5/6] drm/doc: diagram for mode objects and properties

2016-12-18 Thread Daniel Vetter
Resulted in confusion a few times in the past. Cc: Laurent Pinchart Cc: Manasi Navare Signed-off-by: Daniel Vetter --- Documentation/gpu/drm-kms.rst | 22 ++ 1 file changed, 22 insertions(+) diff --git a/Documentation/gpu/drm-kms.rst b/Documentation/gpu/drm-kms.rst index 0

[PATCH 3/6] drm/doc: Add KMS overview graphs

2016-12-18 Thread Daniel Vetter
Oh, the shiny and pretties! Cc: Laurent Pinchart Signed-off-by: Daniel Vetter --- Documentation/gpu/drm-kms-helpers.rst | 4 ++ Documentation/gpu/drm-kms.rst | 132 ++ 2 files changed, 136 insertions(+) diff --git a/Documentation/gpu/drm-kms-helpers.rs

[PATCH 2/6] HACKS: pass stderr along in kfigure.py

2016-12-18 Thread Daniel Vetter
Some addition comments on the implementation: - Also needs to be hacked up for svg conversion. - Inline kernel-render creates temp files and caches them, doesn't seem that good an idea. Probably should switch over to using pipes. - Reimplements sphinx' depency tracking. Might be fixable if we jus

[PATCH] drm/doc: atomic overview, with graph

2016-12-18 Thread Daniel Vetter
I want to split up a few more things and document some details better (like how exactly to subclass drm_atomic_state). And maybe also split up the helpers a bit per-topic, but this should be a ok-ish start for better atomic overview. One thing I failed at is getting DOT to layout the overview grap

[PATCH 1/6] docs-rst: automatically convert Graphviz and SVG images

2016-12-18 Thread Daniel Vetter
From: Markus Heiser This patch brings scalable figure, image handling and a concept to embed *render* markups: * DOT (http://www.graphviz.org) * SVG For image handling use the 'image' replacement:: .. kernel-image:: svg_image.svg :alt:simple SVG image For figure handling use t

Re: [RFC 1/1] MicroSemi Switchtec management interface driver

2016-12-18 Thread Greg Kroah-Hartman
On Sun, Dec 18, 2016 at 10:20:47AM -0700, Logan Gunthorpe wrote: > Hi Greg, > > Thanks for the quick review! > > On 18/12/16 12:51 AM, Greg Kroah-Hartman wrote: > > On Sat, Dec 17, 2016 at 10:09:22AM -0700, Logan Gunthorpe wrote: > > > +struct switchtec_dev { > > > + struct pci_dev *pdev; > > > +

Re: [PATCH] pci-error-recover: doc cleanup

2016-12-18 Thread Cao jin
Sorry for late. On 12/09/2016 10:37 PM, Jonathan Corbet wrote: > On Fri, 9 Dec 2016 14:37:47 +0800 > Cao jin wrote: > >> I am little confused too, even not sure if we are talking the same >> *fatal error*, I am talking the fatal error defined in PCI Express spec, >> chapter 6.2.2.2.1: > > There

Re: [PATCH] docs: sphinx-extensions: make rstFlatTable work with docutils 0.13

2016-12-18 Thread Jonathan Corbet
On Sun, 18 Dec 2016 13:11:46 +0300 Dmitry Shachnev wrote: > In docutils 0.13, the return type of get_column_widths method of the > Table directive has changed [1], which breaks our flat-table directive > and leads to a TypeError when trying to build the docs [2]. > > This patch adds support for

[PATCH] Documentation: Fix a typo in IPMI.txt.

2016-12-18 Thread Rami Rosen
This patch fixes a trivial type in IPMI.txt. Signed-off-by: Rami Rosen --- Documentation/IPMI.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/IPMI.txt b/Documentation/IPMI.txt index 7229230..6962cab 100644 --- a/Documentation/IPMI.txt +++ b/Documentation/IP

Re: [RFC 1/1] MicroSemi Switchtec management interface driver

2016-12-18 Thread Logan Gunthorpe
Hi Greg, Thanks for the quick review! On 18/12/16 12:51 AM, Greg Kroah-Hartman wrote: On Sat, Dec 17, 2016 at 10:09:22AM -0700, Logan Gunthorpe wrote: +struct switchtec_dev { + struct pci_dev *pdev; + struct msix_entry *msix; + struct device *dev; + struct kref kref;

Re: Docutils 0.13 API change break rstFlatTable extension used by Linux kernel documentation: get_column_widths changes

2016-12-18 Thread Jonathan Corbet
On Sun, 18 Dec 2016 14:52:49 +0100 Salvatore Bonaccorso wrote: > (I have not found if that was already reported, apologies if I missed > aprevious report on this already): > > As reported via https://sourceforge.net/p/docutils/bugs/303/ changes > to Docutils's, in particular to the get_column_wi

Docutils 0.13 API change break rstFlatTable extension used by Linux kernel documentation: get_column_widths changes

2016-12-18 Thread Salvatore Bonaccorso
Hi (I have not found if that was already reported, apologies if I missed aprevious report on this already): As reported via https://sourceforge.net/p/docutils/bugs/303/ changes to Docutils's, in particular to the get_column_widths() method causes the Kernel documentation failing to build via sphi

[PATCH] docs: sphinx-extensions: make rstFlatTable work with docutils 0.13

2016-12-18 Thread Dmitry Shachnev
In docutils 0.13, the return type of get_column_widths method of the Table directive has changed [1], which breaks our flat-table directive and leads to a TypeError when trying to build the docs [2]. This patch adds support for the new return type, while keeping support for older docutils versions

Re: [RFC 1/1] MicroSemi Switchtec management interface driver

2016-12-18 Thread Greg Kroah-Hartman
On Sat, Dec 17, 2016 at 10:09:22AM -0700, Logan Gunthorpe wrote: > +struct switchtec_dev { > + struct pci_dev *pdev; > + struct msix_entry *msix; > + struct device *dev; > + struct kref kref; Why do you have a pointer to a device, yet a kref as well? Just have this structure embed