Re: [PATCH v5 untested] kvm: better MWAIT emulation for guests

2017-03-15 Thread Michael S. Tsirkin
On Wed, Mar 15, 2017 at 07:35:34PM -0400, Gabriel L. Somlo wrote: > On Wed, Mar 15, 2017 at 11:22:18PM +0200, Michael S. Tsirkin wrote: > > Guests running Mac OS 5, 6, and 7 (Leopard through Lion) have a problem: > > unless explicitly provided with kernel command line argument > > "idlehalt=0"

Re: [PATCH v5 untested] kvm: better MWAIT emulation for guests

2017-03-15 Thread Gabriel L. Somlo
On Wed, Mar 15, 2017 at 11:22:18PM +0200, Michael S. Tsirkin wrote: > Guests running Mac OS 5, 6, and 7 (Leopard through Lion) have a problem: > unless explicitly provided with kernel command line argument > "idlehalt=0" they'd implicitly assume MONITOR and MWAIT availability, > without checking

Re: [PATCH v4] kvm: better MWAIT emulation for guests

2017-03-15 Thread Gabriel L. Somlo
On Wed, Mar 15, 2017 at 09:46:18PM +0100, Radim Krčmář wrote: > 2017-03-15 16:21-0400, Gabriel L. Somlo: > > On Wed, Mar 15, 2017 at 09:13:49PM +0100, Radim Krčmář wrote: > >> 2017-03-15 21:28+0200, Michael S. Tsirkin: > >> > Guests running Mac OS 5, 6, and 7 (Leopard through Lion) have a problem:

Re: [PATCH v10 03/11] mux: minimal mux subsystem and gpio-based mux controller

2017-03-15 Thread Peter Rosin
On 2017-03-10 12:09, Peter Rosin wrote: > Add a new minimalistic subsystem that handles multiplexer controllers. > When multiplexers are used in various places in the kernel, and the > same multiplexer controller can be used for several independent things, > there should be one place to implement

Re: [Outreachy kernel] [PATCH] Documentation: Fix typos

2017-03-15 Thread Jonathan Corbet
On Wed, 15 Mar 2017 14:56:20 -0700 Alison Schofield wrote: > I'm wondering if there is one 'official' dictionary linux kernel > follows? No, I don't think there's really a need for one. If we can get a minimum of documentation without obvious errors, we'll be ahead of

Re: [Outreachy kernel] [PATCH] Documentation: Fix typos

2017-03-15 Thread Julia Lawall
On Wed, 15 Mar 2017, Alison Schofield wrote: > On Wed, Mar 15, 2017 at 09:07:56PM +0100, Julia Lawall wrote: > > > > > > On Wed, 15 Mar 2017, Tamara Diaconita wrote: > > > > > Fix typos in sync_file.txt to make documentation grammatically correct. > > > > It's a bit picky, but you are not

Re: [Outreachy kernel] [PATCH] Documentation: Fix typos

2017-03-15 Thread Alison Schofield
On Wed, Mar 15, 2017 at 09:07:56PM +0100, Julia Lawall wrote: > > > On Wed, 15 Mar 2017, Tamara Diaconita wrote: > > > Fix typos in sync_file.txt to make documentation grammatically correct. > > It's a bit picky, but you are not making the text grammatically correct, > You are fixing spelling

[PATCH v5 untested] kvm: better MWAIT emulation for guests

2017-03-15 Thread Michael S. Tsirkin
Guests running Mac OS 5, 6, and 7 (Leopard through Lion) have a problem: unless explicitly provided with kernel command line argument "idlehalt=0" they'd implicitly assume MONITOR and MWAIT availability, without checking CPUID. We currently emulate that as a NOP but on VMX we can do better: let

Re: [PATCH v4] kvm: better MWAIT emulation for guests

2017-03-15 Thread Gabriel L. Somlo
On Wed, Mar 15, 2017 at 09:13:49PM +0100, Radim Krčmář wrote: > 2017-03-15 21:28+0200, Michael S. Tsirkin: > > Guests running Mac OS 5, 6, and 7 (Leopard through Lion) have a problem: > > unless explicitly provided with kernel command line argument > > "idlehalt=0" they'd implicitly assume MONITOR

Re: [PATCH v4] kvm: better MWAIT emulation for guests

2017-03-15 Thread Gabriel L. Somlo
On Wed, Mar 15, 2017 at 04:21:41PM -0400, Gabriel L. Somlo wrote: > > > > - do you see VM exits on the "hung" VCPU? > > how would I go about looking ? > > > - what is your CPU model? > > $ cat /proc/cpuinfo > ... > processor : 3 > vendor_id : GenuineIntel > cpu family : 6 >

Re: [PATCH v4] kvm: better MWAIT emulation for guests

2017-03-15 Thread Radim Krčmář
2017-03-15 21:28+0200, Michael S. Tsirkin: > Guests running Mac OS 5, 6, and 7 (Leopard through Lion) have a problem: > unless explicitly provided with kernel command line argument > "idlehalt=0" they'd implicitly assume MONITOR and MWAIT availability, > without checking CPUID. > > We currently

Re: [PATCH] kvm: better MWAIT emulation for guests

2017-03-15 Thread Michael S. Tsirkin
On Wed, Mar 15, 2017 at 03:43:03PM -0400, Gabriel L. Somlo wrote: > Applies cleanly over git://git.kernel.org/pub/scm/virt/kvm/kvm.git, > but then I get: > > CC [M] arch/x86/kvm/x86.o > In file included from arch/x86/kvm/x86.c:28:0: > arch/x86/kvm/x86.h: In function ‘kvm_mwait_in_guest’: >

Re: [Outreachy kernel] [PATCH] Documentation: Fix typos

2017-03-15 Thread Julia Lawall
On Wed, 15 Mar 2017, Tamara Diaconita wrote: > Fix typos in sync_file.txt to make documentation grammatically correct. It's a bit picky, but you are not making the text grammatically correct, You are fixing spelling mistakes, but not changing any aspect of the grammar. julia > >

Re: [PATCH] kvm: better MWAIT emulation for guests

2017-03-15 Thread Gabriel L. Somlo
Applies cleanly over git://git.kernel.org/pub/scm/virt/kvm/kvm.git, but then I get: CC [M] arch/x86/kvm/x86.o In file included from arch/x86/kvm/x86.c:28:0: arch/x86/kvm/x86.h: In function ‘kvm_mwait_in_guest’: arch/x86/kvm/x86.h:231:34: error: ‘CPUID_MWAIT_LEAF’ undeclared (first use in this

Re: [PATCH] kvm: better MWAIT emulation for guests

2017-03-15 Thread Michael S. Tsirkin
On Wed, Mar 15, 2017 at 03:01:12PM -0400, Gabriel L. Somlo wrote: > On Wed, Mar 15, 2017 at 08:29:23PM +0200, Michael S. Tsirkin wrote: > > On Wed, Mar 15, 2017 at 02:14:26PM -0400, Gabriel L. Somlo wrote: > > > Michael, > > > > > > I tested this on OS X 10.7 (Lion), the last version that doesn't

[PATCH v4] kvm: better MWAIT emulation for guests

2017-03-15 Thread Michael S. Tsirkin
Guests running Mac OS 5, 6, and 7 (Leopard through Lion) have a problem: unless explicitly provided with kernel command line argument "idlehalt=0" they'd implicitly assume MONITOR and MWAIT availability, without checking CPUID. We currently emulate that as a NOP but on VMX we can do better: let

Re: [PATCH] kvm: better MWAIT emulation for guests

2017-03-15 Thread Michael S. Tsirkin
On Wed, Mar 15, 2017 at 03:01:12PM -0400, Gabriel L. Somlo wrote: > On Wed, Mar 15, 2017 at 08:29:23PM +0200, Michael S. Tsirkin wrote: > > On Wed, Mar 15, 2017 at 02:14:26PM -0400, Gabriel L. Somlo wrote: > > > Michael, > > > > > > I tested this on OS X 10.7 (Lion), the last version that doesn't

Re: [PATCH] kvm: better MWAIT emulation for guests

2017-03-15 Thread Gabriel L. Somlo
On Wed, Mar 15, 2017 at 08:29:23PM +0200, Michael S. Tsirkin wrote: > On Wed, Mar 15, 2017 at 02:14:26PM -0400, Gabriel L. Somlo wrote: > > Michael, > > > > I tested this on OS X 10.7 (Lion), the last version that doesn't check > > CPUID for MWAIT support. > > > > I used the latest kvm from

Re: [PATCH] kvm: better MWAIT emulation for guests

2017-03-15 Thread Michael S. Tsirkin
On Wed, Mar 15, 2017 at 02:14:26PM -0400, Gabriel L. Somlo wrote: > Michael, > > I tested this on OS X 10.7 (Lion), the last version that doesn't check > CPUID for MWAIT support. > > I used the latest kvm from git://git.kernel.org/pub/scm/virt/kvm/kvm.git > first as-is, then with your v2 MWAIT

Re: [PATCH] kvm: better MWAIT emulation for guests

2017-03-15 Thread Gabriel L. Somlo
Michael, I tested this on OS X 10.7 (Lion), the last version that doesn't check CPUID for MWAIT support. I used the latest kvm from git://git.kernel.org/pub/scm/virt/kvm/kvm.git first as-is, then with your v2 MWAIT patch applied. Single-(V)CPU guest works as expected (but then again,

[PATCH] Documentation: Fix typos

2017-03-15 Thread Tamara Diaconita
Fix typos in sync_file.txt to make documentation grammatically correct. Signed-off-by: Tamara Diaconita --- Documentation/sync_file.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/sync_file.txt b/Documentation/sync_file.txt index

Re: [PATCH] Documentation: Fix typos

2017-03-15 Thread Jonathan Corbet
On Wed, 15 Mar 2017 19:54:07 +0200 Tamara Diaconita wrote: > Fix typos in vfio-mediated-device.txt to make documentation > grammatically correct. Can you put the file name (or some other indication of what's being patched) in the subject line, so the patches can be

[PATCH] Documentation: Fix typos

2017-03-15 Thread Tamara Diaconita
Fix typos in vfio-mediated-device.txt to make documentation grammatically correct. Signed-off-by: Tamara Diaconita --- Documentation/vfio-mediated-device.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/vfio-mediated-device.txt

Re: [PATCH v2 0/33] KVM: MIPS: Add VZ support

2017-03-15 Thread Ralf Baechle
On Tue, Mar 14, 2017 at 10:15:07AM +, James Hogan wrote: I'm happy with the series and it to go through the KVM tree. There is some potencial for merge conflicts but those should be reasonably trivial. Acked-by: Ralf Baechle Ralf -- To unsubscribe from this list:

Re: [PATCH v7 1/3] x86/mm: Adapt MODULES_END based on Fixmap section size

2017-03-15 Thread Boris Ostrovsky
On 03/14/2017 01:05 PM, Thomas Garnier wrote: > This patch aligns MODULES_END to the beginning of the Fixmap section. > It optimizes the space available for both sections. The address is > pre-computed based on the number of pages required by the Fixmap > section. > > It will allow GDT remapping