Re: [v8 1/4] mm, oom: refactor the oom_kill_process() function

2017-09-11 Thread David Rientjes
On Mon, 11 Sep 2017, Roman Gushchin wrote: > The oom_kill_process() function consists of two logical parts: > the first one is responsible for considering task's children as > a potential victim and printing the debug information. > The second half is responsible for sending SIGKILL to all >

Re: [v8 3/4] mm, oom: add cgroup v2 mount option for cgroup-aware OOM killer

2017-09-11 Thread David Rientjes
On Mon, 11 Sep 2017, Roman Gushchin wrote: > Add a "groupoom" cgroup v2 mount option to enable the cgroup-aware > OOM killer. If not set, the OOM selection is performed in > a "traditional" per-process way. > > The behavior can be changed dynamically by remounting the cgroupfs. I can't imagine

Re: [v8 0/4] cgroup-aware OOM killer

2017-09-11 Thread David Rientjes
On Mon, 11 Sep 2017, Roman Gushchin wrote: > This patchset makes the OOM killer cgroup-aware. > > v8: > - Do not kill tasks with OOM_SCORE_ADJ -1000 > - Make the whole thing opt-in with cgroup mount option control > - Drop oom_priority for further discussions Nack, we specifically require

[no subject]

2017-09-11 Thread Paul R
I have an import proposal for you.. -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[v8 2/4] mm, oom: cgroup-aware OOM killer

2017-09-11 Thread Roman Gushchin
Traditionally, the OOM killer is operating on a process level. Under oom conditions, it finds a process with the highest oom score and kills it. This behavior doesn't suit well the system with many running containers: 1) There is no fairness between containers. A small container with few large

[v8 3/4] mm, oom: add cgroup v2 mount option for cgroup-aware OOM killer

2017-09-11 Thread Roman Gushchin
Add a "groupoom" cgroup v2 mount option to enable the cgroup-aware OOM killer. If not set, the OOM selection is performed in a "traditional" per-process way. The behavior can be changed dynamically by remounting the cgroupfs. Signed-off-by: Roman Gushchin Cc: Michal Hocko

[v8 4/4] mm, oom, docs: describe the cgroup-aware OOM killer

2017-09-11 Thread Roman Gushchin
Document the cgroup-aware OOM killer. Signed-off-by: Roman Gushchin Cc: Michal Hocko Cc: Vladimir Davydov Cc: Johannes Weiner Cc: Tetsuo Handa Cc: Andrew Morton

[v8 0/4] cgroup-aware OOM killer

2017-09-11 Thread Roman Gushchin
This patchset makes the OOM killer cgroup-aware. v8: - Do not kill tasks with OOM_SCORE_ADJ -1000 - Make the whole thing opt-in with cgroup mount option control - Drop oom_priority for further discussions - Kill the whole cgroup if oom_group is set and it's memory.max is reached -

Re: [v7 5/5] mm, oom: cgroup v2 mount option to disable cgroup-aware OOM killer

2017-09-11 Thread Roman Gushchin
On Mon, Sep 11, 2017 at 11:05:59AM +0200, Michal Hocko wrote: > On Thu 07-09-17 12:14:57, Johannes Weiner wrote: > > On Wed, Sep 06, 2017 at 10:28:59AM +0200, Michal Hocko wrote: > > > On Tue 05-09-17 17:53:44, Johannes Weiner wrote: > > > > The cgroup-awareness in the OOM killer is exactly the

Re: [v7 5/5] mm, oom: cgroup v2 mount option to disable cgroup-aware OOM killer

2017-09-11 Thread Michal Hocko
On Thu 07-09-17 12:14:57, Johannes Weiner wrote: > On Wed, Sep 06, 2017 at 10:28:59AM +0200, Michal Hocko wrote: > > On Tue 05-09-17 17:53:44, Johannes Weiner wrote: > > > The cgroup-awareness in the OOM killer is exactly the same thing. It > > > should have been the default from the beginning,

Re: [v7 2/5] mm, oom: cgroup-aware OOM killer

2017-09-11 Thread Michal Hocko
On Thu 07-09-17 11:18:18, Cristopher Lameter wrote: > On Mon, 4 Sep 2017, Roman Gushchin wrote > > > To address these issues, cgroup-aware OOM killer is introduced. > > You are missing a major issue here. Processes may have allocation > constraints to memory nodes, special DMA zones etc etc. OOM