Re: [PATCH 8/8] docs: kernel-doc: Don't mangle literal code blocks in comments

2018-02-07 Thread Tobin C. Harding
On Wed, Feb 07, 2018 at 10:26:24AM -0700, Jonathan Corbet wrote: [snip] >if (desperate) >run_in_circles(); this is gold :) -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger

Re: [PATCH 7/8] docs: kernel-doc: Finish moving STATE_* code out of process_file()

2018-02-07 Thread Tobin C. Harding
On Wed, Feb 07, 2018 at 10:26:23AM -0700, Jonathan Corbet wrote: > Move STATE_INLINE and STATE_DOCBLOCK code out of process_file(), which now > actually fits on a single screen. Delete an unused variable and add a > couple of comments while I'm at it. > > Signed-off-by: Jonathan Corbet > --- >

Re: [PATCH 0/8] Clean up kernel-doc and fix literal-block handling

2018-02-07 Thread Tobin C. Harding
On Wed, Feb 07, 2018 at 10:26:16AM -0700, Jonathan Corbet wrote: > So once upon a time I set out to fix the problem reported by Tobin wherein > a literal block within a kerneldoc comment would be corrupted in > processing. On the way, though, I got annoyed at the way I have to learn > how kernel-d

Re: Documentation: networking: ixgb: Remove reference to IXGB_NAPI

2018-02-07 Thread Brown, Aaron F
> -Original Message- > Date: Mon, 29 Jan 2018 12:17:54 + > From: Corentin Labbe > List-Id: Intel Wired Ethernet Linux Kernel Driver Development > > > NAPI is enabled by default and IXGB_NAPI was removed since > commit 6d37ab282e24 ("ixgb: make NAPI the only option and the default")

Re: [PATCH v11 00/10] Application Data Integrity feature introduced by SPARC M7

2018-02-07 Thread Eric W. Biederman
Khalid Aziz writes: > On 02/07/2018 12:38 AM, ebied...@xmission.com wrote: >> Khalid Aziz writes: >> >>> On 02/01/2018 07:29 PM, ebied...@xmission.com wrote: Khalid Aziz writes: > V11 changes: > This series is same as v10 and was simply rebased on 4.15 kernel. Can > mm mai

[PATCH 1/8] docs: kernel-doc: Get rid of xml_escape() and friends

2018-02-07 Thread Jonathan Corbet
XML escaping is a worry that came with DocBook, which we no longer have any dealings with. So get rid of the useless xml_escape()/xml_unescape() functions. No change to the generated output. Signed-off-by: Jonathan Corbet --- scripts/kernel-doc | 65

[PATCH 5/8] docs: kernel-doc: Move STATE_BODY processing to a separate function

2018-02-07 Thread Jonathan Corbet
Also group the pseudo-global $leading_space variable with its peers. Signed-off-by: Jonathan Corbet --- scripts/kernel-doc | 193 - 1 file changed, 101 insertions(+), 92 deletions(-) diff --git a/scripts/kernel-doc b/scripts/kernel-doc index a

[PATCH 3/8] docs: kernel-doc: Move STATE_NORMAL processing into its own function

2018-02-07 Thread Jonathan Corbet
Begin the process of splitting up the nearly 500-line process_file() function by moving STATE_NORMAL processing to a separate function. Signed-off-by: Jonathan Corbet --- scripts/kernel-doc | 21 - 1 file changed, 16 insertions(+), 5 deletions(-) diff --git a/scripts/kernel-

[PATCH 4/8] docs: kernel-doc: Move STATE_NAME processing into its own function

2018-02-07 Thread Jonathan Corbet
Move this code out of process_file() in the name of readability and maintainability. Signed-off-by: Jonathan Corbet --- scripts/kernel-doc | 137 - 1 file changed, 72 insertions(+), 65 deletions(-) diff --git a/scripts/kernel-doc b/scripts/ker

[PATCH 2/8] docs: kernel-doc: Rename and split STATE_FIELD

2018-02-07 Thread Jonathan Corbet
STATE_FIELD describes a parser state that can handle any part of a kerneldoc comment body; rename it to STATE_BODY to reflect that. The $in_purpose variable was a hidden substate of STATE_FIELD; get rid of it and make a proper state (STATE_BODY_MAYBE) instead. This will make the subsequent proces

[PATCH 6/8] docs: kernel-doc: Move STATE_PROTO processing into its own function

2018-02-07 Thread Jonathan Corbet
Move the top-level prototype-processing code out of process_file(). Signed-off-by: Jonathan Corbet --- scripts/kernel-doc | 46 -- 1 file changed, 28 insertions(+), 18 deletions(-) diff --git a/scripts/kernel-doc b/scripts/kernel-doc index a6a7bb46ea2

[PATCH 8/8] docs: kernel-doc: Don't mangle literal code blocks in comments

2018-02-07 Thread Jonathan Corbet
It can be useful to put code snippets into kerneldoc comments; that can be done with the "::" operator at the end of a line like this:: if (desperate) run_in_circles(); kernel-doc currently fails to understand these literal blocks and applies its normal markup to them, which is then tre

[PATCH 7/8] docs: kernel-doc: Finish moving STATE_* code out of process_file()

2018-02-07 Thread Jonathan Corbet
Move STATE_INLINE and STATE_DOCBLOCK code out of process_file(), which now actually fits on a single screen. Delete an unused variable and add a couple of comments while I'm at it. Signed-off-by: Jonathan Corbet --- scripts/kernel-doc | 145 ++---

[PATCH 0/8] Clean up kernel-doc and fix literal-block handling

2018-02-07 Thread Jonathan Corbet
So once upon a time I set out to fix the problem reported by Tobin wherein a literal block within a kerneldoc comment would be corrupted in processing. On the way, though, I got annoyed at the way I have to learn how kernel-doc works from the beginning every time I tear into it. As a result, seve

Re: [PATCH v11 00/10] Application Data Integrity feature introduced by SPARC M7

2018-02-07 Thread Khalid Aziz
On 02/07/2018 12:38 AM, ebied...@xmission.com wrote: Khalid Aziz writes: On 02/01/2018 07:29 PM, ebied...@xmission.com wrote: Khalid Aziz writes: V11 changes: This series is same as v10 and was simply rebased on 4.15 kernel. Can mm maintainers please review patches 2, 7, 8 and 9 which are