Re: [PATCH v4 6/7] ocxl: Add an IOCTL so userspace knows what OCXL features are available

2018-05-10 Thread Michael Ellerman
"Alastair D'Silva" writes: > diff --git a/include/uapi/misc/ocxl.h b/include/uapi/misc/ocxl.h > index 8d2748e69c84..bb80f294b429 100644 > --- a/include/uapi/misc/ocxl.h > +++ b/include/uapi/misc/ocxl.h > @@ -72,5 +75,6 @@ struct ocxl_ioctl_irq_fd { > #define

Re: [PATCH v3 5/7] ocxl: Expose the thread_id needed for wait on POWER9

2018-05-10 Thread Michael Ellerman
"Alastair D'Silva" writes: > diff --git a/include/uapi/misc/ocxl.h b/include/uapi/misc/ocxl.h > index 0af83d80fb3e..8d2748e69c84 100644 > --- a/include/uapi/misc/ocxl.h > +++ b/include/uapi/misc/ocxl.h > @@ -48,6 +48,15 @@ struct ocxl_ioctl_metadata { > __u64

Re: [PATCH] bpf, doc: clarification for the meaning of 'id'

2018-05-10 Thread Daniel Borkmann
On 05/10/2018 05:09 AM, Wang YanQing wrote: > For me, as a reader whose mother language isn't English, the > old words bring a little difficulty to catch the meaning, this > patch rewords the subsection in a more clarificatory way. > > This patch also add blank lines as separator at two places >

Re: [PATCH v2 00/11] Fix some doc build warnings/errors and broken links

2018-05-10 Thread Mauro Carvalho Chehab
Em Thu, 10 May 2018 14:22:35 -0600 Jonathan Corbet escreveu: > On Wed, 9 May 2018 10:18:43 -0300 > Mauro Carvalho Chehab wrote: > > > Patches 1 to 5 on this series contain the patches that weren't yet > > applied from the past patch series and touch

Re: [PATCH v2 00/11] Fix some doc build warnings/errors and broken links

2018-05-10 Thread Jonathan Corbet
On Wed, 9 May 2018 10:18:43 -0300 Mauro Carvalho Chehab wrote: > Patches 1 to 5 on this series contain the patches that weren't yet > applied from the past patch series and touch only at Documentation. > There are two changes there: > patch 2: fixed the description

Re: [PATCH -mm] mm, THP, doc: Add document for thp_swpout/thp_swpout_fallback

2018-05-10 Thread Jonathan Corbet
On Wed, 9 May 2018 16:23:41 +0800 "Huang, Ying" wrote: > From: Huang Ying > > Add document for newly added thp_swpout, thp_swpout_fallback fields in > /proc/vmstat. > > Signed-off-by: "Huang, Ying" > Cc: "Kirill A. Shutemov"

Re: [PATCH] Documentation/process/posting: wrap text at 80 cols

2018-05-10 Thread Jonathan Corbet
On Thu, 10 May 2018 20:37:37 +0100 Justin Skists wrote: > Trivial patch to adjust the text formatting to wrap at 80 columns. No > actual content has changed. > > Signed-off-by: Justin Skists Applied, thanks. jon -- To unsubscribe from

Re: [PATCH v2 02/11] docs: admin-guide: add cgroup-v2 documentation

2018-05-10 Thread Jonathan Corbet
On Thu, 10 May 2018 11:40:18 -0700 Tejun Heo wrote: > On Wed, May 09, 2018 at 10:18:45AM -0300, Mauro Carvalho Chehab wrote: > > The cgroup-v2.txt is already in ReST format. So, move it to the > > admin-guide, where it belongs. > > > > Cc: Tejun Heo > > Cc: Li

[PATCH] Documentation/process/posting: wrap text at 80 cols

2018-05-10 Thread Justin Skists
Trivial patch to adjust the text formatting to wrap at 80 columns. No actual content has changed. Signed-off-by: Justin Skists --- Documentation/process/5.Posting.rst | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git

Re: [PATCH v2 02/11] docs: admin-guide: add cgroup-v2 documentation

2018-05-10 Thread Tejun Heo
On Wed, May 09, 2018 at 10:18:45AM -0300, Mauro Carvalho Chehab wrote: > The cgroup-v2.txt is already in ReST format. So, move it to the > admin-guide, where it belongs. > > Cc: Tejun Heo > Cc: Li Zefan > Cc: Johannes Weiner >

Re: [PATCH 13/18] wait: wait.h: Get rid of a kernel-doc/Sphinx warnings

2018-05-10 Thread Mauro Carvalho Chehab
Em Thu, 10 May 2018 18:52:20 +0200 Andrea Parri escreveu: > On Thu, May 10, 2018 at 07:15:59AM -0600, Jonathan Corbet wrote: > > On Thu, 10 May 2018 14:23:35 +0200 > > Andrea Parri wrote: > > > > > only > > > remember that

Re: [PATCH 13/18] wait: wait.h: Get rid of a kernel-doc/Sphinx warnings

2018-05-10 Thread Mauro Carvalho Chehab
Em Thu, 10 May 2018 13:42:58 -0300 Mauro Carvalho Chehab escreveu: > Em Thu, 10 May 2018 09:38:46 -0600 > Jonathan Corbet escreveu: > > > On Thu, 10 May 2018 11:21:13 -0300 > > Mauro Carvalho Chehab wrote: > > > > > The

Re: [PATCH 13/18] wait: wait.h: Get rid of a kernel-doc/Sphinx warnings

2018-05-10 Thread Andrea Parri
On Thu, May 10, 2018 at 07:15:59AM -0600, Jonathan Corbet wrote: > On Thu, 10 May 2018 14:23:35 +0200 > Andrea Parri wrote: > > > only > > remember that other people (including some developers running into the > > "disadventure" of opening an RST doc. from

Re: [RFC PATCH 1/2] scripts/kernel-doc: Auto-detect common code-blocks

2018-05-10 Thread Jonathan Corbet
On Thu, 10 May 2018 09:34:56 -0700 Matthew Wilcox wrote: > I think this is a bit fragile. Why not just search for ':\n'? Is > there ever a case where we want to write: > > /** > * foo is a bar: > * wibble > */ > and have wibble not be a code-block? Yeah, we might want

Re: [PATCH 13/18] wait: wait.h: Get rid of a kernel-doc/Sphinx warnings

2018-05-10 Thread Mauro Carvalho Chehab
Em Thu, 10 May 2018 09:38:46 -0600 Jonathan Corbet escreveu: > On Thu, 10 May 2018 11:21:13 -0300 > Mauro Carvalho Chehab wrote: > > > The problem with a hint-based mechanism is that it will generate > > false hints. If added, we may end by needing

Re: [RFC PATCH 1/2] scripts/kernel-doc: Auto-detect common code-blocks

2018-05-10 Thread Matthew Wilcox
On Thu, May 10, 2018 at 10:38:16AM -0400, Mauro Carvalho Chehab wrote: > Comments that end with a comma and have certain keywords > should be presented as code-blocks I think this is a bit fragile. Why not just search for ':\n'? Is there ever a case where we want to write: /** * foo is a bar:

Re: [RFC PATCH 2/2] wait: add a keyword to indicate a diagram code block on a kernel-doc

2018-05-10 Thread Randy Dunlap
On 05/10/2018 07:38 AM, Mauro Carvalho Chehab wrote: > When handling code-blocks, usual parsing should be disabled. > Indicate it by using the keyword disagram. diagram. Please add such keyword(s) to one of Documentation/doc-guide/{kernel-doc,sphinx}.rst. >

Re: [PATCH 13/18] wait: wait.h: Get rid of a kernel-doc/Sphinx warnings

2018-05-10 Thread Jonathan Corbet
On Thu, 10 May 2018 11:21:13 -0300 Mauro Carvalho Chehab wrote: > The problem with a hint-based mechanism is that it will generate > false hints. If added, we may end by needing to add extra tags to > disable the hints mechanism where it gets wrong, or to periodically

[RFC PATCH 1/2] scripts/kernel-doc: Auto-detect common code-blocks

2018-05-10 Thread Mauro Carvalho Chehab
Comments that end with a comma and have certain keywords should be presented as code-blocks Signed-off-by: Mauro Carvalho Chehab --- scripts/kernel-doc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/scripts/kernel-doc b/scripts/kernel-doc index

[RFC PATCH 2/2] wait: add a keyword to indicate a diagram code block on a kernel-doc

2018-05-10 Thread Mauro Carvalho Chehab
When handling code-blocks, usual parsing should be disabled. Indicate it by using the keyword disagram. Signed-off-by: Mauro Carvalho Chehab --- include/linux/wait.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/wait.h

Re: [PATCH 13/18] wait: wait.h: Get rid of a kernel-doc/Sphinx warnings

2018-05-10 Thread Mauro Carvalho Chehab
Em Thu, 10 May 2018 07:30:12 -0600 Jonathan Corbet escreveu: > On Thu, 10 May 2018 06:38:05 -0300 > Mauro Carvalho Chehab wrote: > > > (Peter said): > > > Independent of any philosophical discussion not allowing a setence to > > > end with a single

Re: [PATCH 13/18] wait: wait.h: Get rid of a kernel-doc/Sphinx warnings

2018-05-10 Thread Jonathan Corbet
On Thu, 10 May 2018 07:30:12 -0600 Jonathan Corbet wrote: > > (Peter said): > > > Independent of any philosophical discussion not allowing a setence to > > > end with a single ':' is completely idiotic. Please fix the tooling > > > instead to allow it, as it is very important

Re: [PATCH 13/18] wait: wait.h: Get rid of a kernel-doc/Sphinx warnings

2018-05-10 Thread Jonathan Corbet
On Thu, 10 May 2018 06:38:05 -0300 Mauro Carvalho Chehab wrote: > (Peter said): > > Independent of any philosophical discussion not allowing a setence to > > end with a single ':' is completely idiotic. Please fix the tooling > > instead to allow it, as it is very

Re: [PATCH 13/18] wait: wait.h: Get rid of a kernel-doc/Sphinx warnings

2018-05-10 Thread Jonathan Corbet
On Thu, 10 May 2018 14:23:35 +0200 Andrea Parri wrote: > only > remember that other people (including some developers running into the > "disadventure" of opening an RST doc. from their preferred text editor > and being brought to conclude: "WTH! I need to

Re: [PATCH 13/18] wait: wait.h: Get rid of a kernel-doc/Sphinx warnings

2018-05-10 Thread Mauro Carvalho Chehab
Em Thu, 10 May 2018 14:20:36 +0200 Peter Zijlstra escreveu: > On Thu, May 10, 2018 at 06:38:05AM -0300, Mauro Carvalho Chehab wrote: > > Em Thu, 10 May 2018 01:38:38 -0700 > > Christoph Hellwig escreveu: > > > > > > * Use either while holding

Re: [PATCH 13/18] wait: wait.h: Get rid of a kernel-doc/Sphinx warnings

2018-05-10 Thread Andrea Parri
On Wed, May 09, 2018 at 08:45:18AM -0600, Jonathan Corbet wrote: > On Wed, 9 May 2018 10:41:20 +0200 > Peter Zijlstra wrote: > > > > This is easily done by using "::" instead of just ":". > > > > And I'll voice my objection once again. This makes a regular comment > >

Re: [PATCH 13/18] wait: wait.h: Get rid of a kernel-doc/Sphinx warnings

2018-05-10 Thread Peter Zijlstra
On Thu, May 10, 2018 at 06:38:05AM -0300, Mauro Carvalho Chehab wrote: > Em Thu, 10 May 2018 01:38:38 -0700 > Christoph Hellwig escreveu: > > > > * Use either while holding wait_queue_head::lock or when used for > > > wakeups > > > - * with an extra smp_mb() like: > > > +

Re: [PATCH 18/18] w1: w1_io.c: fix a kernel-doc warning

2018-05-10 Thread Evgeniy Polyakov
Hi 09.05.2018, 16:11, "Jonathan Corbet" : > On Wed, 9 May 2018 09:32:18 -0300 > Mauro Carvalho Chehab wrote: > >>  > Looks good to me, thank you! >>  > What tree should this be forwarded to, or folks from linux doc will pick >> it up? >>  > >>  >

Re: [RFC 01/10] PCI: dwc: Add MSI-X callbacks handler

2018-05-10 Thread Gustavo Pimentel
Hi Alan, Sorry for the delay on the response, I only have time to proper analyze this now. On 24/04/2018 10:15, Alan Douglas wrote: > Hi, > > On 10 April 2018 18:15 Gustavo Pimentel wrote: >> Changes the pcie_raise_irq function signature, namely the interrupt_num >> variable type from u8 to

Re: [PATCH 13/18] wait: wait.h: Get rid of a kernel-doc/Sphinx warnings

2018-05-10 Thread Mauro Carvalho Chehab
Em Thu, 10 May 2018 01:38:38 -0700 Christoph Hellwig escreveu: > > * Use either while holding wait_queue_head::lock or when used for wakeups > > - * with an extra smp_mb() like: > > + * with an extra smp_mb() like:: > > Independent of any philosophical discussion not

Re: [PATCH 13/18] wait: wait.h: Get rid of a kernel-doc/Sphinx warnings

2018-05-10 Thread Christoph Hellwig
> * Use either while holding wait_queue_head::lock or when used for wakeups > - * with an extra smp_mb() like: > + * with an extra smp_mb() like:: Independent of any philosophical discussion not allowing a setence to end with a single ':' is completely idiotic. Please fix the tooling instead