Re: [PATCH] VFIO: Fix Documentation

2018-04-30 Thread Alex Williamson
On Fri, 20 Apr 2018 18:07:27 +0800 "dongbo (E)" wrote: > From: Dong Bo > > Signed-off-by: Dong Bo > --- Hi Dong Bo, The patch is corrupted, please resend and also include a commit log, something as simple as "Update vfio_add_group_dev description to match the current API" would be fine. Tha

Re: [PATCH] pci-error-recover: doc cleanup

2016-12-09 Thread Alex Williamson
On Fri, 9 Dec 2016 14:44:25 +0800 Linas Vepstas wrote: > On Fri, Dec 9, 2016 at 2:37 PM, Cao jin wrote: > > > > > > On 12/09/2016 02:24 PM, Linas Vepstas wrote: > >> I suppose I'm confused, but I recall that link resets are non-fatal. > >> Fatal errors typically require that the the pci adapte

Re: [PATCH RESEND v2 0/8] Cache-coherent DMA access using UIO

2016-08-11 Thread Alex Williamson
On Thu, 11 Aug 2016 10:06:19 +0530 Anup Patel wrote: > Hi Alex, > > On Thu, Aug 11, 2016 at 9:46 AM, Alex Williamson > wrote: > > On Thu, 11 Aug 2016 09:30:19 +0530 > > Anup Patel wrote: > > > >> Hi Arnd, > >> > >> On Wed, Aug 10,

Re: [PATCH RESEND v2 0/8] Cache-coherent DMA access using UIO

2016-08-10 Thread Alex Williamson
On Thu, 11 Aug 2016 09:30:19 +0530 Anup Patel wrote: > Hi Arnd, > > On Wed, Aug 10, 2016 at 9:25 PM, Arnd Bergmann wrote: > > On Monday, August 8, 2016 11:22:29 AM CEST Anup Patel wrote: > >> The goal of this patchset is to improve UIO framework and UIO dmem > >> driver to allow cache-coheren

Re: [RFC v6 00/10] vfio-pci: Allow to mmap sub-page MMIO BARs and MSI-X table

2016-04-26 Thread Alex Williamson
On Mon, 25 Apr 2016 18:05:53 +0800 Yongji Xie wrote: > Hi Alex, > > Any comment? TBH, I shuffled this to the bottom of the review pile because you're depending on a patch series for ARM MSI mapping that's still very much in flux. You've really got 3 or 4 separate patch series here that should

Re: [PATCH RFC 2/3] vfio: report group noiommu status

2016-04-18 Thread Alex Williamson
On Mon, 18 Apr 2016 12:58:20 +0300 "Michael S. Tsirkin" wrote: > When using vfio, callers might want to know whether device is added to a > regular group or an non-iommu group. > > Report this status from vfio_add_group_dev. > > Signed-off-by: Michael S. Tsirkin > --- What about making an int

Re: [RFC v5 7/7] vfio-pci: Allow to mmap MSI-X table if interrupt remapping is supported

2016-04-06 Thread Alex Williamson
On Tue, 5 Apr 2016 21:46:44 +0800 Yongji Xie wrote: > This patch enables mmapping MSI-X tables if > hardware supports interrupt remapping which > can ensure that a given pci device can only > shoot the MSIs assigned for it. > > Signed-off-by: Yongji Xie > --- > drivers/vfio/pci/vfio_pci.c

Re: [RFC PATCH v4 6/7] vfio-pci: Allow to mmap MSI-X table if IOMMU_CAP_INTR_REMAP was set

2016-03-20 Thread Alex Williamson
[cc+ Eric, Will] On Mon, 7 Mar 2016 15:48:37 +0800 Yongji Xie wrote: > Current vfio-pci implementation disallows to mmap MSI-X > table in case that user get to touch this directly. > > But we should allow to mmap these MSI-X tables if IOMMU > supports interrupt remapping which can ensure that

Re: [RFC PATCH v4 7/7] powerpc/powernv/pci-ioda: Add IOMMU_CAP_INTR_REMAP for IODA host bridge

2016-03-19 Thread Alex Williamson
On Mon, 7 Mar 2016 15:48:38 +0800 Yongji Xie wrote: > This patch adds IOMMU_CAP_INTR_REMAP for IODA host bridge so that > we can mmap MSI-X table in vfio driver. > > Signed-off-by: Yongji Xie > --- > arch/powerpc/platforms/powernv/pci-ioda.c | 17 + > 1 file changed, 17 inse

Re: [RFC PATCH v4 4/7] PCI: Modify resource_alignment to support multiple devices

2016-03-19 Thread Alex Williamson
On Mon, 7 Mar 2016 15:48:35 +0800 Yongji Xie wrote: > When vfio passthrough a PCI device of which MMIO BARs > are smaller than PAGE_SIZE, guest will not handle the > mmio accesses to the BARs which leads to mmio emulations > in host. > > This is because vfio will not allow to passthrough one >

Re: [RFC PATCH v4 3/7] PCI: Ignore resource_alignment if PCI_PROBE_ONLY was set

2016-03-19 Thread Alex Williamson
On Mon, 7 Mar 2016 15:48:34 +0800 Yongji Xie wrote: > The resource_alignment will releases memory resources > allocated by firmware so that kernel can reassign new > resources later on. But this will cause the problem > that no resources can be allocated by kernel if > PCI_PROBE_ONLY was set, e.

Re: [RFC PATCH v4 4/7] PCI: Modify resource_alignment to support multiple devices

2016-03-19 Thread Alex Williamson
On Thu, 17 Mar 2016 19:28:34 +0800 Yongji Xie wrote: > On 2016/3/17 0:30, Alex Williamson wrote: > > On Mon, 7 Mar 2016 15:48:35 +0800 > > Yongji Xie wrote: > > > >> When vfio passthrough a PCI device of which MMIO BARs > >> are smaller than PAGE_SI

Re: [RFC PATCH v4 5/7] vfio-pci: Allow to mmap sub-page MMIO BARs if the mmio page is exclusive

2016-03-19 Thread Alex Williamson
On Mon, 7 Mar 2016 15:48:36 +0800 Yongji Xie wrote: > Current vfio-pci implementation disallows to mmap > sub-page(size < PAGE_SIZE) MMIO BARs because these BARs' mmio > page may be shared with other BARs. > > But we should allow to mmap these sub-page MMIO BARs if PCI > resource allocator can

Re: [RFC PATCH v4 7/7] powerpc/powernv/pci-ioda: Add IOMMU_CAP_INTR_REMAP for IODA host bridge

2016-03-18 Thread Alex Williamson
On Thu, 17 Mar 2016 19:38:29 +0800 Yongji Xie wrote: > On 2016/3/17 0:32, Alex Williamson wrote: > > On Mon, 7 Mar 2016 15:48:38 +0800 > > Yongji Xie wrote: > > > >> This patch adds IOMMU_CAP_INTR_REMAP for IODA host bridge so that > >>

Re: [RFC PATCH v3 3/5] PCI: Add host bridge attribute to indicate filtering of MSIs is supported

2016-01-29 Thread Alex Williamson
- Original Message - > On 2016/1/29 6:46, Alex Williamson wrote: > > On Fri, 2016-01-15 at 15:06 +0800, Yongji Xie wrote: > >> MSI-X tables are not allowed to be mmapped in vfio-pci > >> driver in case that user get to touch this directly. > >> Thi

Re: [RFC PATCH v3 1/5] PCI: Add support for enforcing all MMIO BARs to be page aligned

2016-01-29 Thread Alex Williamson
On Fri, 2016-01-29 at 18:37 +0800, Yongji Xie wrote: > On 2016/1/29 6:46, Alex Williamson wrote: > > On Fri, 2016-01-15 at 15:06 +0800, Yongji Xie wrote: > > > When vfio passthrough a PCI device of which MMIO BARs > > > are smaller than PAGE_SIZE, guest will not handle

Re: [RFC PATCH v3 5/5] vfio-pci: Allow to mmap MSI-X table if host bridge supports filtering of MSIs

2016-01-28 Thread Alex Williamson
On Fri, 2016-01-15 at 15:06 +0800, Yongji Xie wrote: > Current vfio-pci implementation disallows to mmap MSI-X > table in case that user get to touch this directly. >  > But we should allow to mmap these MSI-X tables if the PCI > host bridge supports filtering of MSIs. >  > Signed-off-by: Yongji Xi

Re: [RFC PATCH v3 1/5] PCI: Add support for enforcing all MMIO BARs to be page aligned

2016-01-28 Thread Alex Williamson
On Fri, 2016-01-15 at 15:06 +0800, Yongji Xie wrote: > When vfio passthrough a PCI device of which MMIO BARs > are smaller than PAGE_SIZE, guest will not handle the > mmio accesses to the BARs which leads to mmio emulations > in host. >  > This is because vfio will not allow to passthrough one > BA

Re: [RFC PATCH v3 3/5] PCI: Add host bridge attribute to indicate filtering of MSIs is supported

2016-01-28 Thread Alex Williamson
On Fri, 2016-01-15 at 15:06 +0800, Yongji Xie wrote: > MSI-X tables are not allowed to be mmapped in vfio-pci > driver in case that user get to touch this directly. > This will cause some performance issues when when PCI > adapters have critical registers in the same page as > the MSI-X table. >  >