Re: [PATCH v5.1 0/6] drm: bridge: dw-hdmi: Add support for Custom PHYs

2017-04-03 Thread Archit Taneja
Hi, On 03/31/2017 07:55 PM, Neil Armstrong wrote: The Amlogic GX SoCs implements a Synopsys DesignWare HDMI TX Controller in combination with a very custom PHY. Thanks to Laurent Pinchart's changes, the HW report the following : Detected HDMI TX controller v2.01a with HDCP (meson_dw_hdmi_phy)

Re: [PATCH v3 3/6] documentation: media: Add documentation for new RGB and YUV bus formats

2017-03-16 Thread Archit Taneja
On 3/7/2017 10:12 PM, Neil Armstrong wrote: Add documentation for added Bus Formats to describe RGB and YUS formats used s/YUS/YUV as input to the Synopsys DesignWare HDMI TX Controller. Signed-off-by: Neil Armstrong ---

Re: [PATCH v3 5/6] drm: bridge: dw-hdmi: Add Documentation on supported input formats

2017-03-16 Thread Archit Taneja
On 3/7/2017 10:12 PM, Neil Armstrong wrote: This patch adds a new DRM documentation entry and links to the input format table added in the dw_hdmi header. Signed-off-by: Neil Armstrong --- Documentation/gpu/dw-hdmi.rst | 15 +++

Re: [PATCH v6 09/11] drm/hisilicon: Add support for external bridge

2016-02-29 Thread Archit Taneja
On 2/26/2016 2:10 PM, Xinliang Liu wrote: Add support for external HDMI bridge. v6: None. v5: None. v4: None. v3: - Fix a typo: s/exteranl/external. v2: - Remove abtraction layer. Reviewed-by: Archit Taneja <arch...@codeaurora.org> Signed-off-by: Xinliang Liu <xinliang@l

Re: [PATCH v6 08/11] drm/hisilicon: Add designware dsi host driver

2016-02-29 Thread Archit Taneja
On 2/26/2016 2:10 PM, Xinliang Liu wrote: Add DesignWare dsi host driver for hi6220 SoC. v6: None. v5: None. v4: None. v3: None. v2: - Remove abtraction layer. Reviewed-by: Archit Taneja <arch...@codeaurora.org> Signed-off-by: Xinliang Liu <xinliang@linaro.org> --- dri

Re: [PATCH v6 07/11] drm/hisilicon: Add designware dsi encoder driver

2016-02-29 Thread Archit Taneja
On 2/26/2016 2:10 PM, Xinliang Liu wrote: Add DesignWare MIPI DSI Host Controller v1.02 encoder driver for hi6220 SoC. v6: - Change "pclk_dsi" to "pclk". v5: None. v4: None. v3: - Rename file name to dw_drm_dsi.c - Make encoder type as DRM_MODE_ENCODER_DSI. - A few cleanup. v2: - Remove

Re: [PATCH v6 05/11] drm/hisilicon: Add vblank driver for ADE

2016-02-29 Thread Archit Taneja
On 2/26/2016 2:10 PM, Xinliang Liu wrote: Add vblank irq handle. v6: None. v5: None. v4: None. v3: - Remove hisi_get_crtc_from_index func. - A few cleanup. v2: - Remove abtraction layer. Signed-off-by: Xinliang Liu ---

Re: [PATCH v6 03/11] drm/hisilicon: Add crtc driver for ADE

2016-02-29 Thread Archit Taneja
if (!ctx->power_on) + (void)ade_power_up(ctx); +} + +static void ade_crtc_atomic_flush(struct drm_crtc *crtc, + struct drm_crtc_state *old_state) + +{ + struct ade_crtc *acrtc = to_ade_crtc(crtc); + struct ade_hw_ctx *ctx = acrtc->c

Re: [PATCH v6 04/11] drm/hisilicon: Add plane driver for ADE

2016-02-29 Thread Archit Taneja
On 2/26/2016 2:10 PM, Xinliang Liu wrote: Add plane funcs and helper funcs for ADE. v6: None. v5: None. v4: None. v3: - A few cleanup. v2: - Remove abtraction layer. Signed-off-by: Xinliang Liu --- drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 535

Re: [PATCH v6 02/11] drm/hisilicon: Add hisilicon kirin drm master driver

2016-02-26 Thread Archit Taneja
Hi, I had some minor comments. Sorry about sharing this late. Otherwise, the looks good to me. On 02/26/2016 02:10 PM, Xinliang Liu wrote: Add kirin DRM master driver for hi6220 SoC which used in HiKey board. Add dumb buffer feature. Add prime dmabuf feature. v6: None. v5: None. v4: None. v3:

Re: [PATCH v4 01/11] drm/hisilicon: Add device tree binding for hi6220 display subsystem

2016-02-08 Thread Archit Taneja
Hi, On 02/06/2016 08:54 AM, Xinliang Liu wrote: Add ADE display controller binding doc. Add DesignWare DSI Host Controller v1.20a binding doc. v4: - Describe more specific of clocks and ports. - Fix indentation. v3: - Make ade as the drm master node. - Use assigned-clocks to set clock rate. -

Re: [PATCH v4 03/11] drm/hisilicon: Add crtc driver for ADE

2016-02-08 Thread Archit Taneja
On 02/06/2016 08:54 AM, Xinliang Liu wrote: Add crtc funcs and helper funcs for ADE. v4: None. v3: - Make ade as the master driver. - Use port to connect with encoder. - A few cleanup. v2: - Remove abtraction layer. Signed-off-by: Xinliang Liu ---